All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/7] ARM: dts: sun9i: Add A80 Optimus Board support
Date: Mon, 29 Sep 2014 11:53:44 +0200	[thread overview]
Message-ID: <20140929095344.GE4388@lukather> (raw)
In-Reply-To: <CAGb2v65Yu=3rgQ+G6USJubKOPzcMJ5bqhe7d9wrYjpT9aFaZuw@mail.gmail.com>

On Sat, Sep 27, 2014 at 09:10:48PM +0800, Chen-Yu Tsai wrote:
> On Thu, Sep 25, 2014 at 9:34 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Wed, Sep 24, 2014 at 10:48:58PM +0800, Chen-Yu Tsai wrote:
> >> The A80 Optimus Board is was launched with the Allwinner A80 SoC.
> >> It was jointly developed by Allwinner and Merrii.
> >>
> >> This board has a UART port, a JTAG connector, USB host ports, a USB
> >> 3.0 OTG connector, an HDMI output, a micro SD slot, 8G NAND flash,
> >> 4G DRAM, a camera sensor interface, a WiFi/BT combo chip, a headphone
> >> jack, IR receiver, and additional GPIO headers.
> >>
> >> This patch adds only basic support.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >> ---
> >>  arch/arm/boot/dts/Makefile              |  2 +
> >>  arch/arm/boot/dts/sun9i-a80-optimus.dts | 66 +++++++++++++++++++++++++++++++++
> >>  2 files changed, 68 insertions(+)
> >>  create mode 100644 arch/arm/boot/dts/sun9i-a80-optimus.dts
> >>
> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> >> index 2f42b18..098f319 100644
> >> --- a/arch/arm/boot/dts/Makefile
> >> +++ b/arch/arm/boot/dts/Makefile
> >> @@ -424,6 +424,8 @@ dtb-$(CONFIG_MACH_SUN7I) += \
> >>       sun7i-a20-pcduino3.dtb
> >>  dtb-$(CONFIG_MACH_SUN8I) += \
> >>       sun8i-a23-ippo-q8h-v5.dtb
> >> +dtb-$(CONFIG_MACH_SUN9I) += \
> >> +     sun9i-a80-optimus.dtb
> >>  dtb-$(CONFIG_ARCH_TEGRA) += tegra20-harmony.dtb \
> >>       tegra20-iris-512.dtb \
> >>       tegra20-medcom-wide.dtb \
> >> diff --git a/arch/arm/boot/dts/sun9i-a80-optimus.dts b/arch/arm/boot/dts/sun9i-a80-optimus.dts
> >> new file mode 100644
> >> index 0000000..f83abab
> >> --- /dev/null
> >> +++ b/arch/arm/boot/dts/sun9i-a80-optimus.dts
> >> @@ -0,0 +1,66 @@
> >> +/*
> >> + * Copyright 2014 Chen-Yu Tsai
> >> + *
> >> + * Chen-Yu Tsai <wens@csie.org>
> >> + *
> >> + * This file is dual-licensed: you can use it either under the terms
> >> + * of the GPL or the X11 license, at your option. Note that this dual
> >> + * licensing only applies to this file, and not this project as a
> >> + * whole.
> >> + *
> >> + *  a) This library is free software; you can redistribute it and/or
> >> + *     modify it under the terms of the GNU General Public License as
> >> + *     published by the Free Software Foundation; either version 2 of the
> >> + *     License, or (at your option) any later version.
> >> + *
> >> + *     This library is distributed in the hope that it will be useful,
> >> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> >> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> >> + *     GNU General Public License for more details.
> >> + *
> >> + *     You should have received a copy of the GNU General Public
> >> + *     License along with this library; if not, write to the Free
> >> + *     Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
> >> + *     MA 02110-1301 USA
> >> + *
> >> + * Or, alternatively,
> >> + *
> >> + *  b) Permission is hereby granted, free of charge, to any person
> >> + *     obtaining a copy of this software and associated documentation
> >> + *     files (the "Software"), to deal in the Software without
> >> + *     restriction, including without limitation the rights to use,
> >> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> >> + *     sell copies of the Software, and to permit persons to whom the
> >> + *     Software is furnished to do so, subject to the following
> >> + *     conditions:
> >> + *
> >> + *     The above copyright notice and this permission notice shall be
> >> + *     included in all copies or substantial portions of the Software.
> >> + *
> >> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> >> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> >> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> >> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> >> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> >> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> >> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> >> + *     OTHER DEALINGS IN THE SOFTWARE.
> >> + */
> >> +
> >> +/dts-v1/;
> >> +/include/ "sun9i-a80.dtsi"
> >> +
> >> +/ {
> >> +     model = "Merrii A80 Optimus Board";
> >> +     compatible = "merrii,a80-optimus", "allwinner,sun9i-a80";
> >> +
> >> +     chosen {
> >> +             bootargs = "earlyprintk console=ttyS0,115200";
> >> +     };
> >
> > Since you changed the memory node in the DTSI, you should probably add
> > one here too, don't you?
> 
> I thought we left fixing that to the bootloader?
> I don't see any memory nodes in our other DTS.

Yes, but does the A80 bootloader supports DT and actually fixes it? If
not, then you'll still have to have a memory node, just like on the
A31 (and presumably on the A23).

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140929/b4f7842f/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Shuge <shuge@allwinnertech.com>,
	Meng Zhang <kevin@allwinnertech.com>, ctl <ctl@merrii.com>,
	Gregory CLEMENT <gregory.clement@free-electrons.com>
Subject: Re: [PATCH v2 4/7] ARM: dts: sun9i: Add A80 Optimus Board support
Date: Mon, 29 Sep 2014 11:53:44 +0200	[thread overview]
Message-ID: <20140929095344.GE4388@lukather> (raw)
In-Reply-To: <CAGb2v65Yu=3rgQ+G6USJubKOPzcMJ5bqhe7d9wrYjpT9aFaZuw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 5209 bytes --]

On Sat, Sep 27, 2014 at 09:10:48PM +0800, Chen-Yu Tsai wrote:
> On Thu, Sep 25, 2014 at 9:34 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Wed, Sep 24, 2014 at 10:48:58PM +0800, Chen-Yu Tsai wrote:
> >> The A80 Optimus Board is was launched with the Allwinner A80 SoC.
> >> It was jointly developed by Allwinner and Merrii.
> >>
> >> This board has a UART port, a JTAG connector, USB host ports, a USB
> >> 3.0 OTG connector, an HDMI output, a micro SD slot, 8G NAND flash,
> >> 4G DRAM, a camera sensor interface, a WiFi/BT combo chip, a headphone
> >> jack, IR receiver, and additional GPIO headers.
> >>
> >> This patch adds only basic support.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >> ---
> >>  arch/arm/boot/dts/Makefile              |  2 +
> >>  arch/arm/boot/dts/sun9i-a80-optimus.dts | 66 +++++++++++++++++++++++++++++++++
> >>  2 files changed, 68 insertions(+)
> >>  create mode 100644 arch/arm/boot/dts/sun9i-a80-optimus.dts
> >>
> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> >> index 2f42b18..098f319 100644
> >> --- a/arch/arm/boot/dts/Makefile
> >> +++ b/arch/arm/boot/dts/Makefile
> >> @@ -424,6 +424,8 @@ dtb-$(CONFIG_MACH_SUN7I) += \
> >>       sun7i-a20-pcduino3.dtb
> >>  dtb-$(CONFIG_MACH_SUN8I) += \
> >>       sun8i-a23-ippo-q8h-v5.dtb
> >> +dtb-$(CONFIG_MACH_SUN9I) += \
> >> +     sun9i-a80-optimus.dtb
> >>  dtb-$(CONFIG_ARCH_TEGRA) += tegra20-harmony.dtb \
> >>       tegra20-iris-512.dtb \
> >>       tegra20-medcom-wide.dtb \
> >> diff --git a/arch/arm/boot/dts/sun9i-a80-optimus.dts b/arch/arm/boot/dts/sun9i-a80-optimus.dts
> >> new file mode 100644
> >> index 0000000..f83abab
> >> --- /dev/null
> >> +++ b/arch/arm/boot/dts/sun9i-a80-optimus.dts
> >> @@ -0,0 +1,66 @@
> >> +/*
> >> + * Copyright 2014 Chen-Yu Tsai
> >> + *
> >> + * Chen-Yu Tsai <wens@csie.org>
> >> + *
> >> + * This file is dual-licensed: you can use it either under the terms
> >> + * of the GPL or the X11 license, at your option. Note that this dual
> >> + * licensing only applies to this file, and not this project as a
> >> + * whole.
> >> + *
> >> + *  a) This library is free software; you can redistribute it and/or
> >> + *     modify it under the terms of the GNU General Public License as
> >> + *     published by the Free Software Foundation; either version 2 of the
> >> + *     License, or (at your option) any later version.
> >> + *
> >> + *     This library is distributed in the hope that it will be useful,
> >> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> >> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> >> + *     GNU General Public License for more details.
> >> + *
> >> + *     You should have received a copy of the GNU General Public
> >> + *     License along with this library; if not, write to the Free
> >> + *     Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
> >> + *     MA 02110-1301 USA
> >> + *
> >> + * Or, alternatively,
> >> + *
> >> + *  b) Permission is hereby granted, free of charge, to any person
> >> + *     obtaining a copy of this software and associated documentation
> >> + *     files (the "Software"), to deal in the Software without
> >> + *     restriction, including without limitation the rights to use,
> >> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> >> + *     sell copies of the Software, and to permit persons to whom the
> >> + *     Software is furnished to do so, subject to the following
> >> + *     conditions:
> >> + *
> >> + *     The above copyright notice and this permission notice shall be
> >> + *     included in all copies or substantial portions of the Software.
> >> + *
> >> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> >> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> >> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> >> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> >> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> >> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> >> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> >> + *     OTHER DEALINGS IN THE SOFTWARE.
> >> + */
> >> +
> >> +/dts-v1/;
> >> +/include/ "sun9i-a80.dtsi"
> >> +
> >> +/ {
> >> +     model = "Merrii A80 Optimus Board";
> >> +     compatible = "merrii,a80-optimus", "allwinner,sun9i-a80";
> >> +
> >> +     chosen {
> >> +             bootargs = "earlyprintk console=ttyS0,115200";
> >> +     };
> >
> > Since you changed the memory node in the DTSI, you should probably add
> > one here too, don't you?
> 
> I thought we left fixing that to the bootloader?
> I don't see any memory nodes in our other DTS.

Yes, but does the A80 bootloader supports DT and actually fixes it? If
not, then you'll still have to have a memory node, just like on the
A31 (and presumably on the A23).

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-09-29  9:53 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24 14:48 [PATCH v2 0/7] ARM: sunxi: Add basic support for Allwinner A80 SoC Chen-Yu Tsai
2014-09-24 14:48 ` Chen-Yu Tsai
2014-09-24 14:48 ` [PATCH v2 1/7] ARM: sunxi: Introduce Allwinner A80 support Chen-Yu Tsai
2014-09-24 14:48   ` Chen-Yu Tsai
2014-09-24 14:48   ` Chen-Yu Tsai
2014-09-25 13:25   ` Maxime Ripard
2014-09-25 13:25     ` Maxime Ripard
2014-09-25 13:25     ` Maxime Ripard
2014-09-27 13:16     ` Chen-Yu Tsai
2014-09-27 13:16       ` Chen-Yu Tsai
2014-09-27 13:16       ` Chen-Yu Tsai
2014-10-01  9:33       ` Maxime Ripard
2014-10-01  9:33         ` Maxime Ripard
2014-10-01  9:33         ` Maxime Ripard
2014-10-03  6:23         ` Chen-Yu Tsai
2014-10-03  6:23           ` Chen-Yu Tsai
2014-10-07 20:11           ` Maxime Ripard
2014-10-07 20:11             ` Maxime Ripard
2014-10-07 20:11             ` Maxime Ripard
2014-09-24 14:48 ` [PATCH v2 2/7] ARM: sunxi: Add debug uart used by sun9i (Allwinner A80) Chen-Yu Tsai
2014-09-24 14:48   ` Chen-Yu Tsai
2014-09-24 14:48   ` Chen-Yu Tsai
2014-09-25 13:27   ` Maxime Ripard
2014-09-25 13:27     ` Maxime Ripard
2014-09-25 13:27     ` Maxime Ripard
2014-09-24 14:48 ` [PATCH v2 3/7] ARM: dts: sunxi: Add Allwinner A80 dtsi Chen-Yu Tsai
2014-09-24 14:48   ` Chen-Yu Tsai
2014-09-24 14:48   ` Chen-Yu Tsai
2014-09-25 13:33   ` Maxime Ripard
2014-09-25 13:33     ` Maxime Ripard
2014-09-24 14:48 ` [PATCH v2 4/7] ARM: dts: sun9i: Add A80 Optimus Board support Chen-Yu Tsai
2014-09-24 14:48   ` Chen-Yu Tsai
2014-09-24 14:48   ` Chen-Yu Tsai
2014-09-25 13:34   ` Maxime Ripard
2014-09-25 13:34     ` Maxime Ripard
2014-09-27 13:10     ` Chen-Yu Tsai
2014-09-27 13:10       ` Chen-Yu Tsai
2014-09-27 13:10       ` Chen-Yu Tsai
2014-09-29  9:53       ` Maxime Ripard [this message]
2014-09-29  9:53         ` Maxime Ripard
2014-09-29 10:04         ` Chen-Yu Tsai
2014-09-29 10:04           ` Chen-Yu Tsai
2014-09-29 10:04           ` Chen-Yu Tsai
2014-10-01 10:03           ` Maxime Ripard
2014-10-01 10:03             ` Maxime Ripard
2014-10-01 10:03             ` Maxime Ripard
2014-10-06  7:02             ` Chen-Yu Tsai
2014-10-06  7:02               ` Chen-Yu Tsai
2014-10-06  7:02               ` Chen-Yu Tsai
2014-10-07 20:12               ` Maxime Ripard
2014-10-07 20:12                 ` Maxime Ripard
2014-10-07 20:12                 ` Maxime Ripard
2014-09-24 14:48 ` [PATCH v2 5/7] devicetree: bindings: Add vendor prefix for Merrii Technology Co., Ltd Chen-Yu Tsai
2014-09-24 14:48   ` Chen-Yu Tsai
2014-09-24 14:48   ` Chen-Yu Tsai
2014-09-25 13:34   ` Maxime Ripard
2014-09-25 13:34     ` Maxime Ripard
2014-09-24 14:49 ` [PATCH v2 6/7] devicetree: bindings: Document supported Allwinner sunxi SoCs Chen-Yu Tsai
2014-09-24 14:49   ` Chen-Yu Tsai
2014-09-24 14:49   ` Chen-Yu Tsai
2014-09-25 13:36   ` Maxime Ripard
2014-09-25 13:36     ` Maxime Ripard
2014-09-25 13:36     ` Maxime Ripard
2014-09-27 13:08     ` Chen-Yu Tsai
2014-09-27 13:08       ` Chen-Yu Tsai
2014-09-27 13:08       ` Chen-Yu Tsai
2014-09-29  9:52       ` Maxime Ripard
2014-09-29  9:52         ` Maxime Ripard
2014-09-24 14:49 ` [PATCH v2 7/7] Documentation: sunxi: Add A80 datasheet link Chen-Yu Tsai
2014-09-24 14:49   ` Chen-Yu Tsai
2014-09-24 14:49   ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140929095344.GE4388@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.