* [PATCH] usb: phy: msm: Fix Sparse warning
@ 2014-09-29 12:47 Pramod Gurav
2014-09-29 15:52 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Pramod Gurav @ 2014-09-29 12:47 UTC (permalink / raw)
To: linux-kernel
Cc: Pramod Gurav, Srinivas Kandagatla, Felipe Balbi,
Greg Kroah-Hartman, linux-usb
This change fixes below sparse warning:
drivers/usb/phy/phy-msm-usb.c:1397:30:
warning: symbol 'msm_otg_mode_fops' was not declared.Should it be static?
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>
---
drivers/usb/phy/phy-msm-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index 4bc3fd7..f663f32 100644
--- a/drivers/usb/phy/phy-msm-usb.c
+++ b/drivers/usb/phy/phy-msm-usb.c
@@ -1394,7 +1394,7 @@ out:
return status;
}
-const struct file_operations msm_otg_mode_fops = {
+static const struct file_operations msm_otg_mode_fops = {
.open = msm_otg_mode_open,
.read = seq_read,
.write = msm_otg_mode_write,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: phy: msm: Fix Sparse warning
2014-09-29 12:47 [PATCH] usb: phy: msm: Fix Sparse warning Pramod Gurav
@ 2014-09-29 15:52 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2014-09-29 15:52 UTC (permalink / raw)
To: Pramod Gurav; +Cc: linux-kernel, Srinivas Kandagatla, Felipe Balbi, linux-usb
On Mon, Sep 29, 2014 at 06:17:40PM +0530, Pramod Gurav wrote:
> This change fixes below sparse warning:
> drivers/usb/phy/phy-msm-usb.c:1397:30:
> warning: symbol 'msm_otg_mode_fops' was not declared.Should it be static?
>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>
> ---
> drivers/usb/phy/phy-msm-usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This is already in my tree, why resend it?
confused,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-29 15:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-29 12:47 [PATCH] usb: phy: msm: Fix Sparse warning Pramod Gurav
2014-09-29 15:52 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.