From: Al Viro <viro@ZenIV.linux.org.uk>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Petr Mladek <pmladek@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts()
Date: Mon, 29 Sep 2014 17:41:55 +0100 [thread overview]
Message-ID: <20140929164155.GI7996@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20140929120927.7e05f485@gandalf.local.home>
On Mon, Sep 29, 2014 at 12:09:27PM -0400, Steven Rostedt wrote:
> Note, I'm trying to make a seq_buf.c file that consolidates the code in
> trace_seq.c and seq_file.c. This will extend slightly the use cases of
> the seq_buf functions, but I think all the seq_*() functions from
> seq_file.c can be turned into functions that return void.
Umm... seq_path() and friends might want to return real errors.
And seq_path_root() needs to be able to return SEQ_SKIP.
prev parent reply other threads:[~2014-09-29 16:42 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 18:37 [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() Steven Rostedt
2014-09-29 14:41 ` Petr Mladek
2014-09-29 15:25 ` Steven Rostedt
2014-09-29 15:46 ` Joe Perches
2014-09-29 16:11 ` Steven Rostedt
2014-09-29 16:23 ` Petr Mladek
2014-09-29 16:40 ` Steven Rostedt
2014-09-29 15:47 ` Al Viro
2014-09-29 16:08 ` Joe Perches
2014-09-29 16:15 ` Steven Rostedt
2014-09-29 16:30 ` Joe Perches
2014-09-29 16:42 ` Steven Rostedt
2014-09-29 16:55 ` Joe Perches
2014-09-29 23:08 ` [Cluster-devel] [PATCH 0/7] seq_printf cleanups Joe Perches
2014-09-29 23:08 ` Joe Perches
2014-09-29 23:08 ` Joe Perches
2014-09-29 23:08 ` [PATCH 1/7] seq_file: Rename static bool seq_overflow to public bool seq_is_full Joe Perches
2014-09-29 23:44 ` Steven Rostedt
2014-09-29 23:48 ` Joe Perches
2014-09-30 10:06 ` Petr Mladek
2014-09-29 23:08 ` [PATCH 2/7] netfilter: Convert print_tuple functions to return void Joe Perches
2014-09-30 10:22 ` Petr Mladek
2014-09-30 13:04 ` Joe Perches
2014-09-29 23:08 ` [Cluster-devel] [PATCH 3/7] dlm: Use seq_is_full - remove seq_printf returns Joe Perches
2014-09-29 23:08 ` Joe Perches
2014-09-30 10:34 ` [Cluster-devel] " Petr Mladek
2014-09-30 10:34 ` Petr Mladek
2014-10-27 20:17 ` [Cluster-devel] " Steven Rostedt
2014-10-27 20:17 ` Steven Rostedt
2014-10-27 20:25 ` [Cluster-devel] " Joe Perches
2014-10-27 20:25 ` Joe Perches
2014-10-29 12:21 ` [Cluster-devel] " Petr Mladek
2014-10-29 12:21 ` Petr Mladek
2014-09-29 23:08 ` [Cluster-devel] [PATCH 4/7] dlm: Use seq_puts, remove unnecessary trailing spaces Joe Perches
2014-09-29 23:08 ` Joe Perches
2014-09-29 23:08 ` [PATCH 5/7] fs: Convert show_fdinfo functions to void Joe Perches
2014-10-28 14:11 ` Steven Rostedt
2014-10-28 14:31 ` Joe Perches
2014-10-28 14:43 ` Steven Rostedt
2014-09-29 23:08 ` [PATCH 6/7] debugfs: Fix misuse of seq_printf return value Joe Perches
2014-10-28 14:58 ` Steven Rostedt
2014-10-28 15:25 ` Joe Perches
2014-10-28 15:42 ` Steven Rostedt
2014-10-28 15:59 ` Joe Perches
2014-11-07 19:03 ` Greg Kroah-Hartman
2014-09-29 23:08 ` [PATCH 7/7] docg3: Fix miuse " Joe Perches
2014-09-29 23:08 ` Joe Perches
2014-10-22 8:29 ` Brian Norris
2014-10-22 8:29 ` Brian Norris
2014-10-28 15:13 ` Steven Rostedt
2014-10-28 15:13 ` Steven Rostedt
2014-10-28 15:57 ` Joe Perches
2014-10-28 15:57 ` Joe Perches
2014-10-28 16:05 ` Steven Rostedt
2014-10-28 16:05 ` Steven Rostedt
2014-10-28 17:14 ` Brian Norris
2014-10-28 17:14 ` Brian Norris
2014-10-28 17:26 ` Steven Rostedt
2014-10-28 17:26 ` Steven Rostedt
2014-10-28 17:27 ` Joe Perches
2014-10-28 17:27 ` Joe Perches
2014-10-28 17:32 ` Steven Rostedt
2014-10-28 17:32 ` Steven Rostedt
2014-10-28 17:36 ` Brian Norris
2014-10-28 17:36 ` Brian Norris
2014-10-28 17:38 ` Joe Perches
2014-10-28 17:38 ` Joe Perches
2014-10-28 15:32 ` [Cluster-devel] [PATCH 0/7] seq_printf cleanups Steven Rostedt
2014-10-28 15:32 ` Steven Rostedt
2014-10-28 15:32 ` Steven Rostedt
2014-10-28 15:51 ` [Cluster-devel] " Joe Perches
2014-10-28 15:51 ` Joe Perches
2014-10-28 15:51 ` Joe Perches
2014-10-06 3:33 ` [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() Joe Perches
2014-09-29 16:09 ` Steven Rostedt
2014-09-29 16:41 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929164155.GI7996@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.cz \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.