From: Brian Norris <computersforpeace@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
linux-mtd@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 7/7] docg3: Fix miuse of seq_printf return value
Date: Wed, 22 Oct 2014 01:29:16 -0700 [thread overview]
Message-ID: <20141022082916.GD16128@brian-ubuntu> (raw)
In-Reply-To: <c1a1138f1b05e87a3fbd8737af2f2c0be6e2724b.1412031505.git.joe@perches.com>
On Mon, Sep 29, 2014 at 04:08:27PM -0700, Joe Perches wrote:
> seq_printf doesn't return a useful value, so remove
> these misuses.
Good catch. So it looks like this driver always had some form of
wrongness (returning a character count) in its debugfs callbacks, but
nobody noticed.
Applied to l2-mtd.git. Thanks!
Brian
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/mtd/devices/docg3.c | 112 ++++++++++++++++++++------------------------
> 1 file changed, 52 insertions(+), 60 deletions(-)
>
> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
> index 21cc4b6..68ff83c 100644
> --- a/drivers/mtd/devices/docg3.c
> +++ b/drivers/mtd/devices/docg3.c
> @@ -1655,22 +1655,21 @@ static int dbg_flashctrl_show(struct seq_file *s, void *p)
> {
> struct docg3 *docg3 = (struct docg3 *)s->private;
>
> - int pos = 0;
> u8 fctrl;
>
> mutex_lock(&docg3->cascade->lock);
> fctrl = doc_register_readb(docg3, DOC_FLASHCONTROL);
> mutex_unlock(&docg3->cascade->lock);
>
> - pos += seq_printf(s,
> - "FlashControl : 0x%02x (%s,CE# %s,%s,%s,flash %s)\n",
> - fctrl,
> - fctrl & DOC_CTRL_VIOLATION ? "protocol violation" : "-",
> - fctrl & DOC_CTRL_CE ? "active" : "inactive",
> - fctrl & DOC_CTRL_PROTECTION_ERROR ? "protection error" : "-",
> - fctrl & DOC_CTRL_SEQUENCE_ERROR ? "sequence error" : "-",
> - fctrl & DOC_CTRL_FLASHREADY ? "ready" : "not ready");
> - return pos;
> + seq_printf(s, "FlashControl : 0x%02x (%s,CE# %s,%s,%s,flash %s)\n",
> + fctrl,
> + fctrl & DOC_CTRL_VIOLATION ? "protocol violation" : "-",
> + fctrl & DOC_CTRL_CE ? "active" : "inactive",
> + fctrl & DOC_CTRL_PROTECTION_ERROR ? "protection error" : "-",
> + fctrl & DOC_CTRL_SEQUENCE_ERROR ? "sequence error" : "-",
> + fctrl & DOC_CTRL_FLASHREADY ? "ready" : "not ready");
> +
> + return 0;
> }
> DEBUGFS_RO_ATTR(flashcontrol, dbg_flashctrl_show);
>
> @@ -1678,58 +1677,56 @@ static int dbg_asicmode_show(struct seq_file *s, void *p)
> {
> struct docg3 *docg3 = (struct docg3 *)s->private;
>
> - int pos = 0, pctrl, mode;
> + int pctrl, mode;
>
> mutex_lock(&docg3->cascade->lock);
> pctrl = doc_register_readb(docg3, DOC_ASICMODE);
> mode = pctrl & 0x03;
> mutex_unlock(&docg3->cascade->lock);
>
> - pos += seq_printf(s,
> - "%04x : RAM_WE=%d,RSTIN_RESET=%d,BDETCT_RESET=%d,WRITE_ENABLE=%d,POWERDOWN=%d,MODE=%d%d (",
> - pctrl,
> - pctrl & DOC_ASICMODE_RAM_WE ? 1 : 0,
> - pctrl & DOC_ASICMODE_RSTIN_RESET ? 1 : 0,
> - pctrl & DOC_ASICMODE_BDETCT_RESET ? 1 : 0,
> - pctrl & DOC_ASICMODE_MDWREN ? 1 : 0,
> - pctrl & DOC_ASICMODE_POWERDOWN ? 1 : 0,
> - mode >> 1, mode & 0x1);
> + seq_printf(s,
> + "%04x : RAM_WE=%d,RSTIN_RESET=%d,BDETCT_RESET=%d,WRITE_ENABLE=%d,POWERDOWN=%d,MODE=%d%d (",
> + pctrl,
> + pctrl & DOC_ASICMODE_RAM_WE ? 1 : 0,
> + pctrl & DOC_ASICMODE_RSTIN_RESET ? 1 : 0,
> + pctrl & DOC_ASICMODE_BDETCT_RESET ? 1 : 0,
> + pctrl & DOC_ASICMODE_MDWREN ? 1 : 0,
> + pctrl & DOC_ASICMODE_POWERDOWN ? 1 : 0,
> + mode >> 1, mode & 0x1);
>
> switch (mode) {
> case DOC_ASICMODE_RESET:
> - pos += seq_puts(s, "reset");
> + seq_puts(s, "reset");
> break;
> case DOC_ASICMODE_NORMAL:
> - pos += seq_puts(s, "normal");
> + seq_puts(s, "normal");
> break;
> case DOC_ASICMODE_POWERDOWN:
> - pos += seq_puts(s, "powerdown");
> + seq_puts(s, "powerdown");
> break;
> }
> - pos += seq_puts(s, ")\n");
> - return pos;
> + seq_puts(s, ")\n");
> + return 0;
> }
> DEBUGFS_RO_ATTR(asic_mode, dbg_asicmode_show);
>
> static int dbg_device_id_show(struct seq_file *s, void *p)
> {
> struct docg3 *docg3 = (struct docg3 *)s->private;
> - int pos = 0;
> int id;
>
> mutex_lock(&docg3->cascade->lock);
> id = doc_register_readb(docg3, DOC_DEVICESELECT);
> mutex_unlock(&docg3->cascade->lock);
>
> - pos += seq_printf(s, "DeviceId = %d\n", id);
> - return pos;
> + seq_printf(s, "DeviceId = %d\n", id);
> + return 0;
> }
> DEBUGFS_RO_ATTR(device_id, dbg_device_id_show);
>
> static int dbg_protection_show(struct seq_file *s, void *p)
> {
> struct docg3 *docg3 = (struct docg3 *)s->private;
> - int pos = 0;
> int protect, dps0, dps0_low, dps0_high, dps1, dps1_low, dps1_high;
>
> mutex_lock(&docg3->cascade->lock);
> @@ -1742,45 +1739,40 @@ static int dbg_protection_show(struct seq_file *s, void *p)
> dps1_high = doc_register_readw(docg3, DOC_DPS1_ADDRHIGH);
> mutex_unlock(&docg3->cascade->lock);
>
> - pos += seq_printf(s, "Protection = 0x%02x (",
> - protect);
> + seq_printf(s, "Protection = 0x%02x (", protect);
> if (protect & DOC_PROTECT_FOUNDRY_OTP_LOCK)
> - pos += seq_puts(s, "FOUNDRY_OTP_LOCK,");
> + seq_puts(s, "FOUNDRY_OTP_LOCK,");
> if (protect & DOC_PROTECT_CUSTOMER_OTP_LOCK)
> - pos += seq_puts(s, "CUSTOMER_OTP_LOCK,");
> + seq_puts(s, "CUSTOMER_OTP_LOCK,");
> if (protect & DOC_PROTECT_LOCK_INPUT)
> - pos += seq_puts(s, "LOCK_INPUT,");
> + seq_puts(s, "LOCK_INPUT,");
> if (protect & DOC_PROTECT_STICKY_LOCK)
> - pos += seq_puts(s, "STICKY_LOCK,");
> + seq_puts(s, "STICKY_LOCK,");
> if (protect & DOC_PROTECT_PROTECTION_ENABLED)
> - pos += seq_puts(s, "PROTECTION ON,");
> + seq_puts(s, "PROTECTION ON,");
> if (protect & DOC_PROTECT_IPL_DOWNLOAD_LOCK)
> - pos += seq_puts(s, "IPL_DOWNLOAD_LOCK,");
> + seq_puts(s, "IPL_DOWNLOAD_LOCK,");
> if (protect & DOC_PROTECT_PROTECTION_ERROR)
> - pos += seq_puts(s, "PROTECT_ERR,");
> + seq_puts(s, "PROTECT_ERR,");
> else
> - pos += seq_puts(s, "NO_PROTECT_ERR");
> - pos += seq_puts(s, ")\n");
> -
> - pos += seq_printf(s, "DPS0 = 0x%02x : "
> - "Protected area [0x%x - 0x%x] : OTP=%d, READ=%d, "
> - "WRITE=%d, HW_LOCK=%d, KEY_OK=%d\n",
> - dps0, dps0_low, dps0_high,
> - !!(dps0 & DOC_DPS_OTP_PROTECTED),
> - !!(dps0 & DOC_DPS_READ_PROTECTED),
> - !!(dps0 & DOC_DPS_WRITE_PROTECTED),
> - !!(dps0 & DOC_DPS_HW_LOCK_ENABLED),
> - !!(dps0 & DOC_DPS_KEY_OK));
> - pos += seq_printf(s, "DPS1 = 0x%02x : "
> - "Protected area [0x%x - 0x%x] : OTP=%d, READ=%d, "
> - "WRITE=%d, HW_LOCK=%d, KEY_OK=%d\n",
> - dps1, dps1_low, dps1_high,
> - !!(dps1 & DOC_DPS_OTP_PROTECTED),
> - !!(dps1 & DOC_DPS_READ_PROTECTED),
> - !!(dps1 & DOC_DPS_WRITE_PROTECTED),
> - !!(dps1 & DOC_DPS_HW_LOCK_ENABLED),
> - !!(dps1 & DOC_DPS_KEY_OK));
> - return pos;
> + seq_puts(s, "NO_PROTECT_ERR");
> + seq_puts(s, ")\n");
> +
> + seq_printf(s, "DPS0 = 0x%02x : Protected area [0x%x - 0x%x] : OTP=%d, READ=%d, WRITE=%d, HW_LOCK=%d, KEY_OK=%d\n",
> + dps0, dps0_low, dps0_high,
> + !!(dps0 & DOC_DPS_OTP_PROTECTED),
> + !!(dps0 & DOC_DPS_READ_PROTECTED),
> + !!(dps0 & DOC_DPS_WRITE_PROTECTED),
> + !!(dps0 & DOC_DPS_HW_LOCK_ENABLED),
> + !!(dps0 & DOC_DPS_KEY_OK));
> + seq_printf(s, "DPS1 = 0x%02x : Protected area [0x%x - 0x%x] : OTP=%d, READ=%d, WRITE=%d, HW_LOCK=%d, KEY_OK=%d\n",
> + dps1, dps1_low, dps1_high,
> + !!(dps1 & DOC_DPS_OTP_PROTECTED),
> + !!(dps1 & DOC_DPS_READ_PROTECTED),
> + !!(dps1 & DOC_DPS_WRITE_PROTECTED),
> + !!(dps1 & DOC_DPS_HW_LOCK_ENABLED),
> + !!(dps1 & DOC_DPS_KEY_OK));
> + return 0;
> }
> DEBUGFS_RO_ATTR(protection, dbg_protection_show);
>
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Al Viro <viro@ZenIV.linux.org.uk>, Petr Mladek <pmladek@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] docg3: Fix miuse of seq_printf return value
Date: Wed, 22 Oct 2014 01:29:16 -0700 [thread overview]
Message-ID: <20141022082916.GD16128@brian-ubuntu> (raw)
In-Reply-To: <c1a1138f1b05e87a3fbd8737af2f2c0be6e2724b.1412031505.git.joe@perches.com>
On Mon, Sep 29, 2014 at 04:08:27PM -0700, Joe Perches wrote:
> seq_printf doesn't return a useful value, so remove
> these misuses.
Good catch. So it looks like this driver always had some form of
wrongness (returning a character count) in its debugfs callbacks, but
nobody noticed.
Applied to l2-mtd.git. Thanks!
Brian
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/mtd/devices/docg3.c | 112 ++++++++++++++++++++------------------------
> 1 file changed, 52 insertions(+), 60 deletions(-)
>
> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
> index 21cc4b6..68ff83c 100644
> --- a/drivers/mtd/devices/docg3.c
> +++ b/drivers/mtd/devices/docg3.c
> @@ -1655,22 +1655,21 @@ static int dbg_flashctrl_show(struct seq_file *s, void *p)
> {
> struct docg3 *docg3 = (struct docg3 *)s->private;
>
> - int pos = 0;
> u8 fctrl;
>
> mutex_lock(&docg3->cascade->lock);
> fctrl = doc_register_readb(docg3, DOC_FLASHCONTROL);
> mutex_unlock(&docg3->cascade->lock);
>
> - pos += seq_printf(s,
> - "FlashControl : 0x%02x (%s,CE# %s,%s,%s,flash %s)\n",
> - fctrl,
> - fctrl & DOC_CTRL_VIOLATION ? "protocol violation" : "-",
> - fctrl & DOC_CTRL_CE ? "active" : "inactive",
> - fctrl & DOC_CTRL_PROTECTION_ERROR ? "protection error" : "-",
> - fctrl & DOC_CTRL_SEQUENCE_ERROR ? "sequence error" : "-",
> - fctrl & DOC_CTRL_FLASHREADY ? "ready" : "not ready");
> - return pos;
> + seq_printf(s, "FlashControl : 0x%02x (%s,CE# %s,%s,%s,flash %s)\n",
> + fctrl,
> + fctrl & DOC_CTRL_VIOLATION ? "protocol violation" : "-",
> + fctrl & DOC_CTRL_CE ? "active" : "inactive",
> + fctrl & DOC_CTRL_PROTECTION_ERROR ? "protection error" : "-",
> + fctrl & DOC_CTRL_SEQUENCE_ERROR ? "sequence error" : "-",
> + fctrl & DOC_CTRL_FLASHREADY ? "ready" : "not ready");
> +
> + return 0;
> }
> DEBUGFS_RO_ATTR(flashcontrol, dbg_flashctrl_show);
>
> @@ -1678,58 +1677,56 @@ static int dbg_asicmode_show(struct seq_file *s, void *p)
> {
> struct docg3 *docg3 = (struct docg3 *)s->private;
>
> - int pos = 0, pctrl, mode;
> + int pctrl, mode;
>
> mutex_lock(&docg3->cascade->lock);
> pctrl = doc_register_readb(docg3, DOC_ASICMODE);
> mode = pctrl & 0x03;
> mutex_unlock(&docg3->cascade->lock);
>
> - pos += seq_printf(s,
> - "%04x : RAM_WE=%d,RSTIN_RESET=%d,BDETCT_RESET=%d,WRITE_ENABLE=%d,POWERDOWN=%d,MODE=%d%d (",
> - pctrl,
> - pctrl & DOC_ASICMODE_RAM_WE ? 1 : 0,
> - pctrl & DOC_ASICMODE_RSTIN_RESET ? 1 : 0,
> - pctrl & DOC_ASICMODE_BDETCT_RESET ? 1 : 0,
> - pctrl & DOC_ASICMODE_MDWREN ? 1 : 0,
> - pctrl & DOC_ASICMODE_POWERDOWN ? 1 : 0,
> - mode >> 1, mode & 0x1);
> + seq_printf(s,
> + "%04x : RAM_WE=%d,RSTIN_RESET=%d,BDETCT_RESET=%d,WRITE_ENABLE=%d,POWERDOWN=%d,MODE=%d%d (",
> + pctrl,
> + pctrl & DOC_ASICMODE_RAM_WE ? 1 : 0,
> + pctrl & DOC_ASICMODE_RSTIN_RESET ? 1 : 0,
> + pctrl & DOC_ASICMODE_BDETCT_RESET ? 1 : 0,
> + pctrl & DOC_ASICMODE_MDWREN ? 1 : 0,
> + pctrl & DOC_ASICMODE_POWERDOWN ? 1 : 0,
> + mode >> 1, mode & 0x1);
>
> switch (mode) {
> case DOC_ASICMODE_RESET:
> - pos += seq_puts(s, "reset");
> + seq_puts(s, "reset");
> break;
> case DOC_ASICMODE_NORMAL:
> - pos += seq_puts(s, "normal");
> + seq_puts(s, "normal");
> break;
> case DOC_ASICMODE_POWERDOWN:
> - pos += seq_puts(s, "powerdown");
> + seq_puts(s, "powerdown");
> break;
> }
> - pos += seq_puts(s, ")\n");
> - return pos;
> + seq_puts(s, ")\n");
> + return 0;
> }
> DEBUGFS_RO_ATTR(asic_mode, dbg_asicmode_show);
>
> static int dbg_device_id_show(struct seq_file *s, void *p)
> {
> struct docg3 *docg3 = (struct docg3 *)s->private;
> - int pos = 0;
> int id;
>
> mutex_lock(&docg3->cascade->lock);
> id = doc_register_readb(docg3, DOC_DEVICESELECT);
> mutex_unlock(&docg3->cascade->lock);
>
> - pos += seq_printf(s, "DeviceId = %d\n", id);
> - return pos;
> + seq_printf(s, "DeviceId = %d\n", id);
> + return 0;
> }
> DEBUGFS_RO_ATTR(device_id, dbg_device_id_show);
>
> static int dbg_protection_show(struct seq_file *s, void *p)
> {
> struct docg3 *docg3 = (struct docg3 *)s->private;
> - int pos = 0;
> int protect, dps0, dps0_low, dps0_high, dps1, dps1_low, dps1_high;
>
> mutex_lock(&docg3->cascade->lock);
> @@ -1742,45 +1739,40 @@ static int dbg_protection_show(struct seq_file *s, void *p)
> dps1_high = doc_register_readw(docg3, DOC_DPS1_ADDRHIGH);
> mutex_unlock(&docg3->cascade->lock);
>
> - pos += seq_printf(s, "Protection = 0x%02x (",
> - protect);
> + seq_printf(s, "Protection = 0x%02x (", protect);
> if (protect & DOC_PROTECT_FOUNDRY_OTP_LOCK)
> - pos += seq_puts(s, "FOUNDRY_OTP_LOCK,");
> + seq_puts(s, "FOUNDRY_OTP_LOCK,");
> if (protect & DOC_PROTECT_CUSTOMER_OTP_LOCK)
> - pos += seq_puts(s, "CUSTOMER_OTP_LOCK,");
> + seq_puts(s, "CUSTOMER_OTP_LOCK,");
> if (protect & DOC_PROTECT_LOCK_INPUT)
> - pos += seq_puts(s, "LOCK_INPUT,");
> + seq_puts(s, "LOCK_INPUT,");
> if (protect & DOC_PROTECT_STICKY_LOCK)
> - pos += seq_puts(s, "STICKY_LOCK,");
> + seq_puts(s, "STICKY_LOCK,");
> if (protect & DOC_PROTECT_PROTECTION_ENABLED)
> - pos += seq_puts(s, "PROTECTION ON,");
> + seq_puts(s, "PROTECTION ON,");
> if (protect & DOC_PROTECT_IPL_DOWNLOAD_LOCK)
> - pos += seq_puts(s, "IPL_DOWNLOAD_LOCK,");
> + seq_puts(s, "IPL_DOWNLOAD_LOCK,");
> if (protect & DOC_PROTECT_PROTECTION_ERROR)
> - pos += seq_puts(s, "PROTECT_ERR,");
> + seq_puts(s, "PROTECT_ERR,");
> else
> - pos += seq_puts(s, "NO_PROTECT_ERR");
> - pos += seq_puts(s, ")\n");
> -
> - pos += seq_printf(s, "DPS0 = 0x%02x : "
> - "Protected area [0x%x - 0x%x] : OTP=%d, READ=%d, "
> - "WRITE=%d, HW_LOCK=%d, KEY_OK=%d\n",
> - dps0, dps0_low, dps0_high,
> - !!(dps0 & DOC_DPS_OTP_PROTECTED),
> - !!(dps0 & DOC_DPS_READ_PROTECTED),
> - !!(dps0 & DOC_DPS_WRITE_PROTECTED),
> - !!(dps0 & DOC_DPS_HW_LOCK_ENABLED),
> - !!(dps0 & DOC_DPS_KEY_OK));
> - pos += seq_printf(s, "DPS1 = 0x%02x : "
> - "Protected area [0x%x - 0x%x] : OTP=%d, READ=%d, "
> - "WRITE=%d, HW_LOCK=%d, KEY_OK=%d\n",
> - dps1, dps1_low, dps1_high,
> - !!(dps1 & DOC_DPS_OTP_PROTECTED),
> - !!(dps1 & DOC_DPS_READ_PROTECTED),
> - !!(dps1 & DOC_DPS_WRITE_PROTECTED),
> - !!(dps1 & DOC_DPS_HW_LOCK_ENABLED),
> - !!(dps1 & DOC_DPS_KEY_OK));
> - return pos;
> + seq_puts(s, "NO_PROTECT_ERR");
> + seq_puts(s, ")\n");
> +
> + seq_printf(s, "DPS0 = 0x%02x : Protected area [0x%x - 0x%x] : OTP=%d, READ=%d, WRITE=%d, HW_LOCK=%d, KEY_OK=%d\n",
> + dps0, dps0_low, dps0_high,
> + !!(dps0 & DOC_DPS_OTP_PROTECTED),
> + !!(dps0 & DOC_DPS_READ_PROTECTED),
> + !!(dps0 & DOC_DPS_WRITE_PROTECTED),
> + !!(dps0 & DOC_DPS_HW_LOCK_ENABLED),
> + !!(dps0 & DOC_DPS_KEY_OK));
> + seq_printf(s, "DPS1 = 0x%02x : Protected area [0x%x - 0x%x] : OTP=%d, READ=%d, WRITE=%d, HW_LOCK=%d, KEY_OK=%d\n",
> + dps1, dps1_low, dps1_high,
> + !!(dps1 & DOC_DPS_OTP_PROTECTED),
> + !!(dps1 & DOC_DPS_READ_PROTECTED),
> + !!(dps1 & DOC_DPS_WRITE_PROTECTED),
> + !!(dps1 & DOC_DPS_HW_LOCK_ENABLED),
> + !!(dps1 & DOC_DPS_KEY_OK));
> + return 0;
> }
> DEBUGFS_RO_ATTR(protection, dbg_protection_show);
>
next prev parent reply other threads:[~2014-10-22 8:29 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 18:37 [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() Steven Rostedt
2014-09-29 14:41 ` Petr Mladek
2014-09-29 15:25 ` Steven Rostedt
2014-09-29 15:46 ` Joe Perches
2014-09-29 16:11 ` Steven Rostedt
2014-09-29 16:23 ` Petr Mladek
2014-09-29 16:40 ` Steven Rostedt
2014-09-29 15:47 ` Al Viro
2014-09-29 16:08 ` Joe Perches
2014-09-29 16:15 ` Steven Rostedt
2014-09-29 16:30 ` Joe Perches
2014-09-29 16:42 ` Steven Rostedt
2014-09-29 16:55 ` Joe Perches
2014-09-29 23:08 ` [Cluster-devel] [PATCH 0/7] seq_printf cleanups Joe Perches
2014-09-29 23:08 ` Joe Perches
2014-09-29 23:08 ` Joe Perches
2014-09-29 23:08 ` [PATCH 1/7] seq_file: Rename static bool seq_overflow to public bool seq_is_full Joe Perches
2014-09-29 23:44 ` Steven Rostedt
2014-09-29 23:48 ` Joe Perches
2014-09-30 10:06 ` Petr Mladek
2014-09-29 23:08 ` [PATCH 2/7] netfilter: Convert print_tuple functions to return void Joe Perches
2014-09-30 10:22 ` Petr Mladek
2014-09-30 13:04 ` Joe Perches
2014-09-29 23:08 ` [Cluster-devel] [PATCH 3/7] dlm: Use seq_is_full - remove seq_printf returns Joe Perches
2014-09-29 23:08 ` Joe Perches
2014-09-30 10:34 ` [Cluster-devel] " Petr Mladek
2014-09-30 10:34 ` Petr Mladek
2014-10-27 20:17 ` [Cluster-devel] " Steven Rostedt
2014-10-27 20:17 ` Steven Rostedt
2014-10-27 20:25 ` [Cluster-devel] " Joe Perches
2014-10-27 20:25 ` Joe Perches
2014-10-29 12:21 ` [Cluster-devel] " Petr Mladek
2014-10-29 12:21 ` Petr Mladek
2014-09-29 23:08 ` [Cluster-devel] [PATCH 4/7] dlm: Use seq_puts, remove unnecessary trailing spaces Joe Perches
2014-09-29 23:08 ` Joe Perches
2014-09-29 23:08 ` [PATCH 5/7] fs: Convert show_fdinfo functions to void Joe Perches
2014-10-28 14:11 ` Steven Rostedt
2014-10-28 14:31 ` Joe Perches
2014-10-28 14:43 ` Steven Rostedt
2014-09-29 23:08 ` [PATCH 6/7] debugfs: Fix misuse of seq_printf return value Joe Perches
2014-10-28 14:58 ` Steven Rostedt
2014-10-28 15:25 ` Joe Perches
2014-10-28 15:42 ` Steven Rostedt
2014-10-28 15:59 ` Joe Perches
2014-11-07 19:03 ` Greg Kroah-Hartman
2014-09-29 23:08 ` [PATCH 7/7] docg3: Fix miuse " Joe Perches
2014-09-29 23:08 ` Joe Perches
2014-10-22 8:29 ` Brian Norris [this message]
2014-10-22 8:29 ` Brian Norris
2014-10-28 15:13 ` Steven Rostedt
2014-10-28 15:13 ` Steven Rostedt
2014-10-28 15:57 ` Joe Perches
2014-10-28 15:57 ` Joe Perches
2014-10-28 16:05 ` Steven Rostedt
2014-10-28 16:05 ` Steven Rostedt
2014-10-28 17:14 ` Brian Norris
2014-10-28 17:14 ` Brian Norris
2014-10-28 17:26 ` Steven Rostedt
2014-10-28 17:26 ` Steven Rostedt
2014-10-28 17:27 ` Joe Perches
2014-10-28 17:27 ` Joe Perches
2014-10-28 17:32 ` Steven Rostedt
2014-10-28 17:32 ` Steven Rostedt
2014-10-28 17:36 ` Brian Norris
2014-10-28 17:36 ` Brian Norris
2014-10-28 17:38 ` Joe Perches
2014-10-28 17:38 ` Joe Perches
2014-10-28 15:32 ` [Cluster-devel] [PATCH 0/7] seq_printf cleanups Steven Rostedt
2014-10-28 15:32 ` Steven Rostedt
2014-10-28 15:32 ` Steven Rostedt
2014-10-28 15:51 ` [Cluster-devel] " Joe Perches
2014-10-28 15:51 ` Joe Perches
2014-10-28 15:51 ` Joe Perches
2014-10-06 3:33 ` [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() Joe Perches
2014-09-29 16:09 ` Steven Rostedt
2014-09-29 16:41 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022082916.GD16128@brian-ubuntu \
--to=computersforpeace@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pmladek@suse.cz \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.