From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 1/5] video: move mediabus format definition to a more standard place
Date: Tue, 30 Sep 2014 11:44:23 +0200 [thread overview]
Message-ID: <20140930114423.3a171aa9@bbrezillon> (raw)
In-Reply-To: <20140930083952.GA4059@ulmo>
On Tue, 30 Sep 2014 10:39:53 +0200
Thierry Reding <thierry.reding@gmail.com> wrote:
> On Tue, Sep 30, 2014 at 09:37:57AM +0200, Boris Brezillon wrote:
> > On Mon, 29 Sep 2014 23:41:09 +0300
> > Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> [...]
> > > Incidentally, patch 2/5 in this series is missing a documentation update ;-)
> >
> > Yep, regarding this patch, I wonder if it's really necessary to add
> > new formats to the v4l2_mbus_pixelcode enum.
> > If we want to move to this new common definition (across the video
> > related subsytems), we should deprecate the old enum
> > v4l2_mbus_pixelcode, and this start by not adding new formats, don't
> > you think ?
>
> I agree in general, but I think it could prove problematic in practice.
> If somebody wants to use one of the new codes but is using the V4L2 enum
> they have a problem.
>
> That said, given that there is now a unified enum people will hopefully
> start converting drivers to it instead.
I'm more worried about user-space lib/programs as this header is part
of the uapi...
But let's be optimistic here and keep porting new formats to
v4l2_mbus_pixelcode enum ;-).
Anyway, I still don't know where to put the documentation. Dropping a
new video format doc without any context (I mean subdev-formats.xml is
included in media documentation, but there's no generic video doc yet)
is a bit weird...
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-media@vger.kernel.org,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] video: move mediabus format definition to a more standard place
Date: Tue, 30 Sep 2014 11:44:23 +0200 [thread overview]
Message-ID: <20140930114423.3a171aa9@bbrezillon> (raw)
In-Reply-To: <20140930083952.GA4059@ulmo>
On Tue, 30 Sep 2014 10:39:53 +0200
Thierry Reding <thierry.reding@gmail.com> wrote:
> On Tue, Sep 30, 2014 at 09:37:57AM +0200, Boris Brezillon wrote:
> > On Mon, 29 Sep 2014 23:41:09 +0300
> > Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> [...]
> > > Incidentally, patch 2/5 in this series is missing a documentation update ;-)
> >
> > Yep, regarding this patch, I wonder if it's really necessary to add
> > new formats to the v4l2_mbus_pixelcode enum.
> > If we want to move to this new common definition (across the video
> > related subsytems), we should deprecate the old enum
> > v4l2_mbus_pixelcode, and this start by not adding new formats, don't
> > you think ?
>
> I agree in general, but I think it could prove problematic in practice.
> If somebody wants to use one of the new codes but is using the V4L2 enum
> they have a problem.
>
> That said, given that there is now a unified enum people will hopefully
> start converting drivers to it instead.
I'm more worried about user-space lib/programs as this header is part
of the uapi...
But let's be optimistic here and keep porting new formats to
v4l2_mbus_pixelcode enum ;-).
Anyway, I still don't know where to put the documentation. Dropping a
new video format doc without any context (I mean subdev-formats.xml is
included in media documentation, but there's no generic video doc yet)
is a bit weird...
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-30 9:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 14:02 [PATCH v2 0/5] video: describe data bus formats Boris Brezillon
2014-09-29 14:02 ` Boris Brezillon
2014-09-29 14:02 ` [PATCH v2 1/5] video: move mediabus format definition to a more standard place Boris Brezillon
2014-09-29 14:10 ` Boris BREZILLON
2014-09-29 14:40 ` Thierry Reding
2014-09-29 14:40 ` Thierry Reding
2014-09-29 20:41 ` Laurent Pinchart
2014-09-30 7:37 ` Boris Brezillon
2014-09-30 7:37 ` Boris Brezillon
2014-09-30 8:39 ` Thierry Reding
2014-09-30 8:39 ` Thierry Reding
2014-09-30 9:44 ` Boris Brezillon [this message]
2014-09-30 9:44 ` Boris Brezillon
2014-09-30 21:00 ` Laurent Pinchart
2014-09-30 21:00 ` Laurent Pinchart
2014-11-03 11:03 ` Boris Brezillon
2014-11-03 14:06 ` Hans Verkuil
2014-09-29 14:02 ` [PATCH v2 2/5] video: add RGB444_1X12 and RGB565_1X16 bus formats Boris Brezillon
2014-11-03 18:15 ` Mauro Carvalho Chehab
2014-09-29 14:02 ` [PATCH v2 3/5] drm: add bus_formats and nbus_formats fields to drm_display_info Boris Brezillon
2014-09-29 14:02 ` Boris Brezillon
2014-09-29 14:02 ` [PATCH v2 4/5] drm: panel: simple-panel: add support for bus_format retrieval Boris Brezillon
2014-09-29 14:02 ` [PATCH v2 5/5] drm: panel: simple-panel: add bus format information for foxlink panel Boris Brezillon
2014-09-29 14:02 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930114423.3a171aa9@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=g.liakhovetski@gmx.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.