From: Marek Vasut <marex@denx.de>
To: "Bean Huo 霍斌斌 (beanhuo)" <beanhuo@micron.com>
Cc: "geert+renesas@glider.be" <geert+renesas@glider.be>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"grmoore@altera.com" <grmoore@altera.com>,
Brian Norris <computersforpeace@gmail.com>,
"shijie8@gmail.com" <shijie8@gmail.com>
Subject: Re: [PATCH 1/1 v3] driver:mtd:spi-nor: Add Micron quad I/O support
Date: Tue, 30 Sep 2014 15:38:40 +0200 [thread overview]
Message-ID: <201409301538.40466.marex@denx.de> (raw)
In-Reply-To: <A765B125120D1346A63912DDE6D8B6315E3C79@NTXXIAMBX02.xacn.micron.com>
On Tuesday, September 30, 2014 at 04:47:39 AM, Bean Huo 霍斌斌 (beanhuo) wrote:
> For Micron spi norflash,enables or disables quad I/O
> protocol ,which controled by EVCR(Enhanced
> Volatile Configuration Register) Quad I/O
> protocol bit 7.When EVCR bit 7 is reset to 0,
> the spi norflash will operate in quad I/O following
> the next WRITE ENHANCED VOLATILE CONFIGURATION
> command.
You only do one WRITE ENHANCED VOLATILE CONFIGURATION command in the patch, so
this text doesn't add up.
Try something like this:
-->8--
This patch adds code which enables Quad I/O mode on Micron SPI NOR
flashes.
For Micron SPI NOR flash, enabling or disabling quad I/O protocol
is controled by EVCR (Enhanced Volatile Configuration Register),
Quad I/O protocol bit 7. When EVCR bit 7 is reset to 0, the SPI
NOR flash will operate in quad I/O mode.
--8<--
What do you think ?
Brian, am I bitching too much about pointless things ? Please stop me if you
think I do.
[...]
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: "Bean Huo 霍斌斌 (beanhuo)" <beanhuo@micron.com>
Cc: "dwmw2@infradead.org" <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
"shijie8@gmail.com" <shijie8@gmail.com>,
"geert+renesas@glider.be" <geert+renesas@glider.be>,
"grmoore@altera.com" <grmoore@altera.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1 v3] driver:mtd:spi-nor: Add Micron quad I/O support
Date: Tue, 30 Sep 2014 15:38:40 +0200 [thread overview]
Message-ID: <201409301538.40466.marex@denx.de> (raw)
In-Reply-To: <A765B125120D1346A63912DDE6D8B6315E3C79@NTXXIAMBX02.xacn.micron.com>
On Tuesday, September 30, 2014 at 04:47:39 AM, Bean Huo 霍斌斌 (beanhuo) wrote:
> For Micron spi norflash,enables or disables quad I/O
> protocol ,which controled by EVCR(Enhanced
> Volatile Configuration Register) Quad I/O
> protocol bit 7.When EVCR bit 7 is reset to 0,
> the spi norflash will operate in quad I/O following
> the next WRITE ENHANCED VOLATILE CONFIGURATION
> command.
You only do one WRITE ENHANCED VOLATILE CONFIGURATION command in the patch, so
this text doesn't add up.
Try something like this:
-->8--
This patch adds code which enables Quad I/O mode on Micron SPI NOR
flashes.
For Micron SPI NOR flash, enabling or disabling quad I/O protocol
is controled by EVCR (Enhanced Volatile Configuration Register),
Quad I/O protocol bit 7. When EVCR bit 7 is reset to 0, the SPI
NOR flash will operate in quad I/O mode.
--8<--
What do you think ?
Brian, am I bitching too much about pointless things ? Please stop me if you
think I do.
[...]
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-09-30 13:39 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 6:20 [PATCH 1/1] driver:mtd:spi-nor: Add Micron quad I/O support bpqw
2014-09-25 6:20 ` bpqw
2014-09-25 10:11 ` Marek Vasut
2014-09-25 10:11 ` Marek Vasut
2014-09-26 8:39 ` bpqw
2014-09-26 8:39 ` bpqw
2014-09-26 8:46 ` Marek Vasut
2014-09-26 8:46 ` Marek Vasut
2014-09-28 1:59 ` [PATCH 1/1 v2] " bpqw
2014-09-28 1:59 ` bpqw
2014-09-28 22:43 ` Marek Vasut
2014-09-28 22:43 ` Marek Vasut
2014-09-29 0:30 ` bpqw
2014-09-29 0:30 ` bpqw
2014-09-29 18:57 ` Marek Vasut
2014-09-29 18:57 ` Marek Vasut
2014-09-30 2:47 ` [PATCH 1/1 v3] " Bean Huo 霍斌斌 (beanhuo)
2014-09-30 2:47 ` Bean Huo 霍斌斌 (beanhuo)
2014-09-30 13:38 ` Marek Vasut [this message]
2014-09-30 13:38 ` Marek Vasut
2014-10-01 14:24 ` Bean Huo 霍斌斌 (beanhuo)
2014-10-01 14:24 ` Bean Huo 霍斌斌 (beanhuo)
2014-10-01 14:32 ` Marek Vasut
2014-10-01 14:32 ` Marek Vasut
2014-10-01 14:28 ` bpqw
2014-10-01 14:28 ` bpqw
2014-10-01 14:33 ` Marek Vasut
2014-10-01 14:33 ` Marek Vasut
2014-10-04 5:55 ` bpqw
2014-10-04 5:55 ` bpqw
2014-10-16 1:53 ` bpqw
2014-10-16 1:53 ` bpqw
2014-10-17 0:37 ` Bean Huo 霍斌斌 (beanhuo)
2014-10-17 0:37 ` Bean Huo 霍斌斌 (beanhuo)
2014-10-20 1:24 ` bpqw
2014-10-20 1:24 ` bpqw
2014-10-23 0:58 ` Bean Huo 霍斌斌 (beanhuo)
2014-10-23 0:58 ` Bean Huo 霍斌斌 (beanhuo)
2014-10-24 0:31 ` Bean Huo 霍斌斌 (beanhuo)
2014-10-24 0:31 ` Bean Huo 霍斌斌 (beanhuo)
2014-10-27 0:09 ` [PATCH 1/1 v3] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor bpqw
2014-10-27 0:09 ` bpqw
2014-10-30 14:31 ` bpqw
2014-10-30 14:31 ` bpqw
2014-11-12 20:59 ` Jagan Teki
2014-11-12 20:59 ` Jagan Teki
2014-11-04 13:25 ` [PATCH 1/1 v4] " bpqw
2014-11-04 13:25 ` bpqw
2014-11-05 11:26 ` Brian Norris
2014-11-05 11:26 ` Brian Norris
2014-11-06 2:56 ` bpqw
2014-11-06 2:56 ` bpqw
2014-11-06 3:09 ` [V5 PATCH 1/1] " bpqw
2014-11-06 3:09 ` bpqw
[not found] ` <54613259.4070903@opensource.altera.com>
2014-11-11 19:41 ` Graham Moore
2014-11-11 19:41 ` Graham Moore
2014-11-11 21:55 ` Jagan Teki
2014-11-11 21:55 ` Jagan Teki
2014-11-12 1:19 ` bpqw
2014-11-12 1:19 ` bpqw
2014-11-12 0:58 ` bpqw
2014-11-12 0:58 ` bpqw
2014-11-13 16:26 ` Graham Moore
2014-11-13 16:26 ` Graham Moore
2014-11-14 2:06 ` bpqw
2014-11-14 2:06 ` bpqw
2014-11-26 4:06 ` Brian Norris
2014-11-26 4:06 ` Brian Norris
2014-11-26 16:08 ` bpqw
2014-11-26 16:08 ` bpqw
2014-11-26 21:12 ` Brian Norris
2014-11-26 21:12 ` Brian Norris
2014-11-27 5:55 ` bpqw
2014-11-27 5:55 ` bpqw
2014-11-27 9:14 ` Brian Norris
2014-11-27 9:14 ` Brian Norris
2014-11-30 16:11 ` Bean Huo 霍斌斌 (beanhuo)
2014-11-30 16:11 ` Bean Huo 霍斌斌 (beanhuo)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201409301538.40466.marex@denx.de \
--to=marex@denx.de \
--cc=beanhuo@micron.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=geert+renesas@glider.be \
--cc=grmoore@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.