From: peterz@infradead.org (Peter Zijlstra)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] sched, time: fix build error with 64 bit cputime_t on 32 bit systems
Date: Tue, 30 Sep 2014 21:08:59 +0200 [thread overview]
Message-ID: <20140930190859.GO4241@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20140930190611.GA5702@lerouge>
On Tue, Sep 30, 2014 at 09:06:13PM +0200, Frederic Weisbecker wrote:
> Maybe cmpxchg() should itself be a wrapper that does this build time choice
> between cmpxchg32() and cmpxchg64().
>
> And if it looks too dangerous to convert all users, this could be cmpxchg_t().
It cannot, not all 32bit archs can do a 64bit cmpxchg.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Rik van Riel <riel@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
umgwanakikbuti@gmail.com, akpm@linux-foundation.org,
srao@redhat.com, lwoodman@redhat.com, atheurer@redhat.com,
oleg@redhat.com, Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] sched, time: fix build error with 64 bit cputime_t on 32 bit systems
Date: Tue, 30 Sep 2014 21:08:59 +0200 [thread overview]
Message-ID: <20140930190859.GO4241@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20140930190611.GA5702@lerouge>
On Tue, Sep 30, 2014 at 09:06:13PM +0200, Frederic Weisbecker wrote:
> Maybe cmpxchg() should itself be a wrapper that does this build time choice
> between cmpxchg32() and cmpxchg64().
>
> And if it looks too dangerous to convert all users, this could be cmpxchg_t().
It cannot, not all 32bit archs can do a 64bit cmpxchg.
next prev parent reply other threads:[~2014-09-30 19:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 11:56 [PATCH] sched, time: cmpxchg does not work on 64-bit variable Arnd Bergmann
2014-09-30 11:56 ` Arnd Bergmann
2014-09-30 12:34 ` Rik van Riel
2014-09-30 12:34 ` Rik van Riel
2014-09-30 12:43 ` Dietmar Eggemann
2014-09-30 12:43 ` Dietmar Eggemann
2014-09-30 13:26 ` Arnd Bergmann
2014-09-30 13:26 ` Arnd Bergmann
2014-09-30 13:37 ` Peter Zijlstra
2014-09-30 13:37 ` Peter Zijlstra
2014-09-30 19:59 ` [PATCH v2] sched, time: fix build error with 64 bit cputime_t on 32 bit systems Rik van Riel
2014-09-30 19:59 ` Rik van Riel
2014-09-30 20:07 ` Arnd Bergmann
2014-09-30 20:07 ` Arnd Bergmann
2014-10-03 5:27 ` [tip:sched/core] sched, time: Fix " tip-bot for Rik van Riel
2014-09-30 17:40 ` [PATCH] sched, time: fix " Rik van Riel
2014-09-30 17:40 ` Rik van Riel
2014-09-30 18:49 ` Arnd Bergmann
2014-09-30 18:49 ` Arnd Bergmann
2014-09-30 19:19 ` Rik van Riel
2014-09-30 19:19 ` Rik van Riel
2014-09-30 19:06 ` Frederic Weisbecker
2014-09-30 19:06 ` Frederic Weisbecker
2014-09-30 19:08 ` Peter Zijlstra [this message]
2014-09-30 19:08 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930190859.GO4241@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.