From: Greg KH <gregkh@linuxfoundation.org>
To: Mark Einon <mark.einon@gmail.com>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org, netdev@vger.kernel.org
Subject: Re: [PATCH] et131x: Promote staging et131x driver to drivers/net
Date: Tue, 30 Sep 2014 12:32:01 -0700 [thread overview]
Message-ID: <20140930193201.GA2349@kroah.com> (raw)
In-Reply-To: <1412104572-2931-1-git-send-email-mark.einon@gmail.com>
On Tue, Sep 30, 2014 at 08:16:12PM +0100, Mark Einon wrote:
> This patch moves the et131x gigabit ethernet driver from drivers/staging
> to drivers/net/ethernet/agere.
>
> Signed-off-by: Mark Einon <mark.einon@gmail.com>
> ---
>
> This patch appiles to both staging-next and the linux-next tag next-20140930,
> and takes into account all feedback recieved from the recent RFC for this
> patch.
>
> MAINTAINERS | 10 +++----
> drivers/net/ethernet/Kconfig | 1 +
> drivers/net/ethernet/Makefile | 1 +
> drivers/net/ethernet/agere/Kconfig | 31 ++++++++++++++++++++++
> .../et131x => net/ethernet/agere}/Makefile | 0
> .../et131x => net/ethernet/agere}/et131x.c | 0
> .../et131x => net/ethernet/agere}/et131x.h | 0
> drivers/staging/Kconfig | 2 --
> drivers/staging/Makefile | 1 -
> drivers/staging/et131x/Kconfig | 10 -------
> drivers/staging/et131x/README | 15 -----------
> 11 files changed, 38 insertions(+), 33 deletions(-)
> create mode 100644 drivers/net/ethernet/agere/Kconfig
> rename drivers/{staging/et131x => net/ethernet/agere}/Makefile (100%)
> rename drivers/{staging/et131x => net/ethernet/agere}/et131x.c (100%)
> rename drivers/{staging/et131x => net/ethernet/agere}/et131x.h (100%)
> delete mode 100644 drivers/staging/et131x/Kconfig
> delete mode 100644 drivers/staging/et131x/README
This is a fine way to make a patch, but it's no way that any of the
netdev developers could ever review it to know what the code happens to
look like in my staging-next branch :(
How about just sending a patch that adds the driver to drivers/net/...
Don't worry about the staging driver at the moment. If it gets added to
drivers/net we can then delete the staging driver.
Sound easier? Should make the patches half as big.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Mark Einon <mark.einon@gmail.com>
Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org,
davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] et131x: Promote staging et131x driver to drivers/net
Date: Tue, 30 Sep 2014 12:32:01 -0700 [thread overview]
Message-ID: <20140930193201.GA2349@kroah.com> (raw)
In-Reply-To: <1412104572-2931-1-git-send-email-mark.einon@gmail.com>
On Tue, Sep 30, 2014 at 08:16:12PM +0100, Mark Einon wrote:
> This patch moves the et131x gigabit ethernet driver from drivers/staging
> to drivers/net/ethernet/agere.
>
> Signed-off-by: Mark Einon <mark.einon@gmail.com>
> ---
>
> This patch appiles to both staging-next and the linux-next tag next-20140930,
> and takes into account all feedback recieved from the recent RFC for this
> patch.
>
> MAINTAINERS | 10 +++----
> drivers/net/ethernet/Kconfig | 1 +
> drivers/net/ethernet/Makefile | 1 +
> drivers/net/ethernet/agere/Kconfig | 31 ++++++++++++++++++++++
> .../et131x => net/ethernet/agere}/Makefile | 0
> .../et131x => net/ethernet/agere}/et131x.c | 0
> .../et131x => net/ethernet/agere}/et131x.h | 0
> drivers/staging/Kconfig | 2 --
> drivers/staging/Makefile | 1 -
> drivers/staging/et131x/Kconfig | 10 -------
> drivers/staging/et131x/README | 15 -----------
> 11 files changed, 38 insertions(+), 33 deletions(-)
> create mode 100644 drivers/net/ethernet/agere/Kconfig
> rename drivers/{staging/et131x => net/ethernet/agere}/Makefile (100%)
> rename drivers/{staging/et131x => net/ethernet/agere}/et131x.c (100%)
> rename drivers/{staging/et131x => net/ethernet/agere}/et131x.h (100%)
> delete mode 100644 drivers/staging/et131x/Kconfig
> delete mode 100644 drivers/staging/et131x/README
This is a fine way to make a patch, but it's no way that any of the
netdev developers could ever review it to know what the code happens to
look like in my staging-next branch :(
How about just sending a patch that adds the driver to drivers/net/...
Don't worry about the staging driver at the moment. If it gets added to
drivers/net we can then delete the staging driver.
Sound easier? Should make the patches half as big.
thanks,
greg k-h
next prev parent reply other threads:[~2014-09-30 19:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 19:16 [PATCH] et131x: Promote staging et131x driver to drivers/net Mark Einon
2014-09-30 19:16 ` Mark Einon
2014-09-30 19:32 ` Greg KH [this message]
2014-09-30 19:32 ` Greg KH
2014-09-30 19:45 ` Mark Einon
2014-09-30 19:45 ` Mark Einon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930193201.GA2349@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.einon@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.