From: Andrew Morton <akpm@linux-foundation.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: David Rientjes <rientjes@google.com>,
Xiubo Li <Li.Xiubo@freescale.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
mgorman@suse.de, minchan@kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] mm, compaction: using uninitialized_var insteads setting 'flags' to 0 directly.
Date: Wed, 1 Oct 2014 14:25:59 -0700 [thread overview]
Message-ID: <20141001142559.20b8c87f792bc046cdabd309@linux-foundation.org> (raw)
In-Reply-To: <542C6FB2.8000503@suse.cz>
On Wed, 01 Oct 2014 23:18:42 +0200 Vlastimil Babka <vbabka@suse.cz> wrote:
> On 10/01/2014 10:16 PM, David Rientjes wrote:
> >> On 09/29/2014 05:30 AM, Xiubo Li wrote:
> >> > Setting 'flags' to zero will be certainly a misleading way to avoid
> >> > warning of 'flags' may be used uninitialized. uninitialized_var is
> >> > a correct way because the warning is a false possitive.
> >>
> >> Agree.
> >>
> >> > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> >>
> >> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> >>
> >
> > I thought we just discussed this when
> > mm-compaction-fix-warning-of-flags-may-be-used-uninitialized.patch was
> > merged and, although I liked it, it was stated that we shouldn't add any
> > new users of uninitialized_var().
>
> Yeah but that discussion wasn't unfortunately CC'd on mailing lists. And my
> interpretation of the outcome is that maybe we should try :)
>
https://lkml.org/lkml/2012/10/27/71
I disagree, can't be bothered getting into a fight over it. I do tend
to accidentally let new uses sneak into the tree, but this one is a bit
obvious.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: David Rientjes <rientjes@google.com>,
Xiubo Li <Li.Xiubo@freescale.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
mgorman@suse.de, minchan@kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] mm, compaction: using uninitialized_var insteads setting 'flags' to 0 directly.
Date: Wed, 1 Oct 2014 14:25:59 -0700 [thread overview]
Message-ID: <20141001142559.20b8c87f792bc046cdabd309@linux-foundation.org> (raw)
In-Reply-To: <542C6FB2.8000503@suse.cz>
On Wed, 01 Oct 2014 23:18:42 +0200 Vlastimil Babka <vbabka@suse.cz> wrote:
> On 10/01/2014 10:16 PM, David Rientjes wrote:
> >> On 09/29/2014 05:30 AM, Xiubo Li wrote:
> >> > Setting 'flags' to zero will be certainly a misleading way to avoid
> >> > warning of 'flags' may be used uninitialized. uninitialized_var is
> >> > a correct way because the warning is a false possitive.
> >>
> >> Agree.
> >>
> >> > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> >>
> >> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> >>
> >
> > I thought we just discussed this when
> > mm-compaction-fix-warning-of-flags-may-be-used-uninitialized.patch was
> > merged and, although I liked it, it was stated that we shouldn't add any
> > new users of uninitialized_var().
>
> Yeah but that discussion wasn't unfortunately CC'd on mailing lists. And my
> interpretation of the outcome is that maybe we should try :)
>
https://lkml.org/lkml/2012/10/27/71
I disagree, can't be bothered getting into a fight over it. I do tend
to accidentally let new uses sneak into the tree, but this one is a bit
obvious.
next prev parent reply other threads:[~2014-10-01 21:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 3:30 [PATCH] mm, compaction: using uninitialized_var insteads setting 'flags' to 0 directly Xiubo Li
2014-09-29 3:30 ` Xiubo Li
2014-09-30 7:27 ` Vlastimil Babka
2014-09-30 7:27 ` Vlastimil Babka
2014-10-01 20:16 ` David Rientjes
2014-10-01 20:16 ` David Rientjes
2014-10-01 21:18 ` Vlastimil Babka
2014-10-01 21:18 ` Vlastimil Babka
2014-10-01 21:25 ` Andrew Morton [this message]
2014-10-01 21:25 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001142559.20b8c87f792bc046cdabd309@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Li.Xiubo@freescale.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.