* [Buildroot] [PATCH] valgrind: allow building on more ARM systems
@ 2014-10-01 15:15 Mike Williams
2014-10-01 16:14 ` Thomas Petazzoni
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Mike Williams @ 2014-10-01 15:15 UTC (permalink / raw)
To: buildroot
Signed-off-by: Mike Williams <mike@mikebwilliams.com>
---
package/valgrind/Config.in | 7 ++++---
package/valgrind/valgrind.mk | 2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
index fd5649b..253555b 100644
--- a/package/valgrind/Config.in
+++ b/package/valgrind/Config.in
@@ -1,8 +1,9 @@
config BR2_PACKAGE_VALGRIND
bool "valgrind"
- depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a8 || \
- BR2_cortex_a9 || BR2_powerpc || BR2_mips || \
- BR2_mipsel || BR2_mips64 || BR2_mips64el
+ depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a5 || \
+ BR2_cortex_a7 || BR2_cortex_a8 || BR2_cortex_a9 || \
+ BR2_cortex_a12 || BR2_cortex_a15 || BR2_powerpc || \
+ BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
help
Tool for debugging and profiling Linux programs.
diff --git a/package/valgrind/valgrind.mk b/package/valgrind/valgrind.mk
index 24d0290..8bea031 100644
--- a/package/valgrind/valgrind.mk
+++ b/package/valgrind/valgrind.mk
@@ -17,7 +17,7 @@ VALGRIND_AUTORECONF = YES
# not. Therefore, we adjust the host tuple to specify we're on
# ARMv7. The valgrind package is guaranteed, through Config.in, to
# only be selected on Cortex A8 and Cortex A9 platforms.
-ifeq ($(BR2_cortex_a8)$(BR2_cortex_a9),y)
+ifeq ($(BR2_cortex_a5)$(BR2_cortex_a7)$(BR2_cortex_a8)$(BR2_cortex_a9)$(BR2_cortex_a12)$(BR2_cortex_a15),y)
VALGRIND_CONF_OPT += \
--host=$(patsubst arm-%,armv7-%,$(GNU_TARGET_NAME))
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] valgrind: allow building on more ARM systems
2014-10-01 15:15 [Buildroot] [PATCH] valgrind: allow building on more ARM systems Mike Williams
@ 2014-10-01 16:14 ` Thomas Petazzoni
2014-10-01 16:30 ` Thomas De Schampheleire
2014-10-01 17:21 ` Thomas Petazzoni
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2014-10-01 16:14 UTC (permalink / raw)
To: buildroot
Dear Mike Williams,
On Wed, 1 Oct 2014 11:15:49 -0400, Mike Williams wrote:
> Signed-off-by: Mike Williams <mike@mikebwilliams.com>
> ---
> package/valgrind/Config.in | 7 ++++---
> package/valgrind/valgrind.mk | 2 +-
> 2 files changed, 5 insertions(+), 4 deletions(-)
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] valgrind: allow building on more ARM systems
2014-10-01 15:15 [Buildroot] [PATCH] valgrind: allow building on more ARM systems Mike Williams
2014-10-01 16:14 ` Thomas Petazzoni
@ 2014-10-01 16:30 ` Thomas De Schampheleire
2014-10-01 17:19 ` Thomas Petazzoni
2014-10-01 17:21 ` Thomas Petazzoni
2 siblings, 1 reply; 5+ messages in thread
From: Thomas De Schampheleire @ 2014-10-01 16:30 UTC (permalink / raw)
To: buildroot
Mike Williams <mike@mikebwilliams.com> schreef:
>Signed-off-by: Mike Williams <mike@mikebwilliams.com>
>---
> package/valgrind/Config.in | 7 ++++---
> package/valgrind/valgrind.mk | 2 +-
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
>diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
>index fd5649b..253555b 100644
>--- a/package/valgrind/Config.in
>+++ b/package/valgrind/Config.in
>@@ -1,8 +1,9 @@
> config BR2_PACKAGE_VALGRIND
> bool "valgrind"
>- depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a8 || \
>- BR2_cortex_a9 || BR2_powerpc || BR2_mips || \
>- BR2_mipsel || BR2_mips64 || BR2_mips64el
>+ depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a5 || \
>+ BR2_cortex_a7 || BR2_cortex_a8 || BR2_cortex_a9 || \
>+ BR2_cortex_a12 || BR2_cortex_a15 || BR2_powerpc || \
>+ BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
> help
> Tool for debugging and profiling Linux programs.
>
>diff --git a/package/valgrind/valgrind.mk b/package/valgrind/valgrind.mk
>index 24d0290..8bea031 100644
>--- a/package/valgrind/valgrind.mk
>+++ b/package/valgrind/valgrind.mk
>@@ -17,7 +17,7 @@ VALGRIND_AUTORECONF = YES
> # not. Therefore, we adjust the host tuple to specify we're on
> # ARMv7. The valgrind package is guaranteed, through Config.in, to
> # only be selected on Cortex A8 and Cortex A9 platforms.
>-ifeq ($(BR2_cortex_a8)$(BR2_cortex_a9),y)
>+ifeq ($(BR2_cortex_a5)$(BR2_cortex_a7)$(BR2_cortex_a8)$(BR2_cortex_a9)$(BR2_cortex_a12)$(BR2_cortex_a15),y)
> VALGRIND_CONF_OPT += \
> --host=$(patsubst arm-%,armv7-%,$(GNU_TARGET_NAME))
> endif
In fact, mips64+n32 abi is not supported, so I think
this should be reflected too. I guess the same applies
to the the le variant...
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] valgrind: allow building on more ARM systems
2014-10-01 16:30 ` Thomas De Schampheleire
@ 2014-10-01 17:19 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2014-10-01 17:19 UTC (permalink / raw)
To: buildroot
Dear Thomas De Schampheleire,
On Wed, 01 Oct 2014 18:30:54 +0200, Thomas De Schampheleire wrote:
> >diff --git a/package/valgrind/valgrind.mk b/package/valgrind/valgrind.mk
> >index 24d0290..8bea031 100644
> >--- a/package/valgrind/valgrind.mk
> >+++ b/package/valgrind/valgrind.mk
> >@@ -17,7 +17,7 @@ VALGRIND_AUTORECONF = YES
> > # not. Therefore, we adjust the host tuple to specify we're on
> > # ARMv7. The valgrind package is guaranteed, through Config.in, to
> > # only be selected on Cortex A8 and Cortex A9 platforms.
> >-ifeq ($(BR2_cortex_a8)$(BR2_cortex_a9),y)
> >+ifeq ($(BR2_cortex_a5)$(BR2_cortex_a7)$(BR2_cortex_a8)$(BR2_cortex_a9)$(BR2_cortex_a12)$(BR2_cortex_a15),y)
> > VALGRIND_CONF_OPT += \
> > --host=$(patsubst arm-%,armv7-%,$(GNU_TARGET_NAME))
> > endif
>
> In fact, mips64+n32 abi is not supported, so I think
> this should be reflected too. I guess the same applies
> to the the le variant...
Right, but it's not an issue introduced by this new patch.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] valgrind: allow building on more ARM systems
2014-10-01 15:15 [Buildroot] [PATCH] valgrind: allow building on more ARM systems Mike Williams
2014-10-01 16:14 ` Thomas Petazzoni
2014-10-01 16:30 ` Thomas De Schampheleire
@ 2014-10-01 17:21 ` Thomas Petazzoni
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2014-10-01 17:21 UTC (permalink / raw)
To: buildroot
Dear Mike Williams,
On Wed, 1 Oct 2014 11:15:49 -0400, Mike Williams wrote:
> Signed-off-by: Mike Williams <mike@mikebwilliams.com>
> ---
> package/valgrind/Config.in | 7 ++++---
> package/valgrind/valgrind.mk | 2 +-
> 2 files changed, 5 insertions(+), 4 deletions(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-10-01 17:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-01 15:15 [Buildroot] [PATCH] valgrind: allow building on more ARM systems Mike Williams
2014-10-01 16:14 ` Thomas Petazzoni
2014-10-01 16:30 ` Thomas De Schampheleire
2014-10-01 17:19 ` Thomas Petazzoni
2014-10-01 17:21 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.