* [Buildroot] [PATCH v2 1/3] package/gnupg2: configure script use the wrong stdint.h file
@ 2014-09-23 21:57 Romain Naour
2014-09-23 21:57 ` [Buildroot] [PATCH v2 2/3] package/gnupg2: add bzip2 optional dependency Romain Naour
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Romain Naour @ 2014-09-23 21:57 UTC (permalink / raw)
To: buildroot
The configure test "checking absolute name of <stdint.h>..." return
the absolute path of a stdint.h file from the toolchain sources.
The contents of this file is completely different compared to what
was expected and does not contain intmax_t definitions.
Use gl_cv_absolute_stdint_h to indicate the correct file that
is in staging directory.
This issue is only trigged by uClibc toolchain although it's present
with glibc toolchain.
Ref: http://bugs.gnupg.org/gnupg/issue1547
Fixes:
http://autobuild.buildroot.net/results/92a/92af55396670685f12ed0ebcddfe2d082ed5aeb7/
http://autobuild.buildroot.net/results/bef/bef61579ba96a6a1b83c8ca259c39cef617aa77d/
http://autobuild.buildroot.net/results/989/989648cfd3cc5750992fbbc784726dca4be2e920/
http://autobuild.buildroot.net/results/e8a/e8a1d9b8d98c059d497bc493a9d2ae0ef5f9d0f5/
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v2: improve commit log
add comment in the .mk file
package/gnupg2/gnupg2.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/gnupg2/gnupg2.mk b/package/gnupg2/gnupg2.mk
index 33b5bc0..af475bb 100644
--- a/package/gnupg2/gnupg2.mk
+++ b/package/gnupg2/gnupg2.mk
@@ -19,6 +19,10 @@ GNUPG2_CONF_OPT = \
--with-ksba-prefix=$(STAGING_DIR)/usr \
--with-pth-prefix=$(STAGING_DIR)/usr
+# Workaround: http://bugs.gnupg.org/gnupg/issue1547
+# The m4 macro absolute-header.m4 is brocken
+GNUPG2_CONF_OPT += gl_cv_absolute_stdint_h=$(STAGING_DIR)/usr/include/stdint.h
+
ifneq ($(BR2_PACKAGE_GNUPG2_GPGV2),y)
define GNUPG2_REMOVE_GPGV2
rm -f $(TARGET_DIR)/usr/bin/gpgv2
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH v2 2/3] package/gnupg2: add bzip2 optional dependency
2014-09-23 21:57 [Buildroot] [PATCH v2 1/3] package/gnupg2: configure script use the wrong stdint.h file Romain Naour
@ 2014-09-23 21:57 ` Romain Naour
2014-10-01 20:46 ` Thomas Petazzoni
2014-09-23 21:57 ` [Buildroot] [PATCH v2 3/3] package/gnupg2: add readline " Romain Naour
2014-10-01 21:19 ` [Buildroot] [PATCH v2 1/3] package/gnupg2: configure script use the wrong stdint.h file Thomas Petazzoni
2 siblings, 1 reply; 6+ messages in thread
From: Romain Naour @ 2014-09-23 21:57 UTC (permalink / raw)
To: buildroot
This is to improve build reproducibility.
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v2: improve commit log
package/gnupg2/gnupg2.mk | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/package/gnupg2/gnupg2.mk b/package/gnupg2/gnupg2.mk
index af475bb..3fce998 100644
--- a/package/gnupg2/gnupg2.mk
+++ b/package/gnupg2/gnupg2.mk
@@ -30,4 +30,10 @@ endef
GNUPG2_POST_INSTALL_TARGET_HOOKS += GNUPG2_REMOVE_GPGV2
endif
+ifeq ($(BR2_PACKAGE_BZIP2),y)
+GNUPG2_DEPENDENCIES += bzip2
+else
+GNUPG2_CONF_OPT += --disable-bzip2
+endif
+
$(eval $(autotools-package))
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 2/3] package/gnupg2: add bzip2 optional dependency
2014-09-23 21:57 ` [Buildroot] [PATCH v2 2/3] package/gnupg2: add bzip2 optional dependency Romain Naour
@ 2014-10-01 20:46 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2014-10-01 20:46 UTC (permalink / raw)
To: buildroot
Dear Romain Naour,
On Tue, 23 Sep 2014 23:57:36 +0200, Romain Naour wrote:
> This is to improve build reproducibility.
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> v2: improve commit log
>
> package/gnupg2/gnupg2.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/package/gnupg2/gnupg2.mk b/package/gnupg2/gnupg2.mk
> index af475bb..3fce998 100644
> --- a/package/gnupg2/gnupg2.mk
> +++ b/package/gnupg2/gnupg2.mk
> @@ -30,4 +30,10 @@ endef
> GNUPG2_POST_INSTALL_TARGET_HOOKS += GNUPG2_REMOVE_GPGV2
> endif
>
> +ifeq ($(BR2_PACKAGE_BZIP2),y)
> +GNUPG2_DEPENDENCIES += bzip2
I've added --enable-bzip2 --with-bzip2=$(STAGING_DIR) here and applied
your patch.
Thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 3/3] package/gnupg2: add readline optional dependency
2014-09-23 21:57 [Buildroot] [PATCH v2 1/3] package/gnupg2: configure script use the wrong stdint.h file Romain Naour
2014-09-23 21:57 ` [Buildroot] [PATCH v2 2/3] package/gnupg2: add bzip2 optional dependency Romain Naour
@ 2014-09-23 21:57 ` Romain Naour
2014-10-01 20:46 ` Thomas Petazzoni
2014-10-01 21:19 ` [Buildroot] [PATCH v2 1/3] package/gnupg2: configure script use the wrong stdint.h file Thomas Petazzoni
2 siblings, 1 reply; 6+ messages in thread
From: Romain Naour @ 2014-09-23 21:57 UTC (permalink / raw)
To: buildroot
This is to improve build reproducibility.
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v2: improve commit log
package/gnupg2/gnupg2.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/gnupg2/gnupg2.mk b/package/gnupg2/gnupg2.mk
index 3fce998..b78f825 100644
--- a/package/gnupg2/gnupg2.mk
+++ b/package/gnupg2/gnupg2.mk
@@ -36,4 +36,8 @@ else
GNUPG2_CONF_OPT += --disable-bzip2
endif
+ifeq ($(BR2_PACKAGE_READLINE),y)
+GNUPG2_DEPENDENCIES += readline
+endif
+
$(eval $(autotools-package))
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 1/3] package/gnupg2: configure script use the wrong stdint.h file
2014-09-23 21:57 [Buildroot] [PATCH v2 1/3] package/gnupg2: configure script use the wrong stdint.h file Romain Naour
2014-09-23 21:57 ` [Buildroot] [PATCH v2 2/3] package/gnupg2: add bzip2 optional dependency Romain Naour
2014-09-23 21:57 ` [Buildroot] [PATCH v2 3/3] package/gnupg2: add readline " Romain Naour
@ 2014-10-01 21:19 ` Thomas Petazzoni
2 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2014-10-01 21:19 UTC (permalink / raw)
To: buildroot
Dear Romain Naour,
On Tue, 23 Sep 2014 23:57:35 +0200, Romain Naour wrote:
> The configure test "checking absolute name of <stdint.h>..." return
> the absolute path of a stdint.h file from the toolchain sources.
>
> The contents of this file is completely different compared to what
> was expected and does not contain intmax_t definitions.
>
> Use gl_cv_absolute_stdint_h to indicate the correct file that
> is in staging directory.
>
> This issue is only trigged by uClibc toolchain although it's present
> with glibc toolchain.
>
> Ref: http://bugs.gnupg.org/gnupg/issue1547
>
> Fixes:
> http://autobuild.buildroot.net/results/92a/92af55396670685f12ed0ebcddfe2d082ed5aeb7/
> http://autobuild.buildroot.net/results/bef/bef61579ba96a6a1b83c8ca259c39cef617aa77d/
> http://autobuild.buildroot.net/results/989/989648cfd3cc5750992fbbc784726dca4be2e920/
> http://autobuild.buildroot.net/results/e8a/e8a1d9b8d98c059d497bc493a9d2ae0ef5f9d0f5/
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> v2: improve commit log
> add comment in the .mk file
As discussed on IRC, I've committed a different fix that consists in
telling gnupg2 that our stdint.h is C99 compliant, even though it's
technically not the case on non-wchar capable toolchains.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-01 21:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-23 21:57 [Buildroot] [PATCH v2 1/3] package/gnupg2: configure script use the wrong stdint.h file Romain Naour
2014-09-23 21:57 ` [Buildroot] [PATCH v2 2/3] package/gnupg2: add bzip2 optional dependency Romain Naour
2014-10-01 20:46 ` Thomas Petazzoni
2014-09-23 21:57 ` [Buildroot] [PATCH v2 3/3] package/gnupg2: add readline " Romain Naour
2014-10-01 20:46 ` Thomas Petazzoni
2014-10-01 21:19 ` [Buildroot] [PATCH v2 1/3] package/gnupg2: configure script use the wrong stdint.h file Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.