Re: [PATCH V2] Staging: rtl8712 removed unnecessary else after return

[Dan Carpenter <dan.carpenter@oracle.com>]

On Thu, Oct 02, 2014 at 09:44:06AM +0200, Nitin Kuppelur wrote:
> Removed unnecessary else after return to solve
> checkpatch.pl warning
> 
> Signed-off-by: Nitin Kuppelur <nitinkuppelur@gmail.com>
> ---
>  drivers/staging/rtl8712/hal_init.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c
> index 81cd654..e5878e2 100644
> --- a/drivers/staging/rtl8712/hal_init.c
> +++ b/drivers/staging/rtl8712/hal_init.c
> @@ -387,12 +387,9 @@ uint rtl8712_hal_deinit(struct _adapter *padapter)
>  uint rtl871x_hal_init(struct _adapter *padapter)
>  {
>  	padapter->hw_init_completed = false;
> -	if (padapter->halpriv.hal_bus_init == NULL)
> +	if (padapter->halpriv.hal_bus_init == NULL ||
> +		padapter->halpriv.hal_bus_init(padapter) != _SUCCESS)
>  		return _FAIL;

Align these like this:

	if (padapter->halpriv.hal_bus_init == NULL ||
	    padapter->halpriv.hal_bus_init(padapter) != _SUCCESS) 
		return _FAIL;
[tab][space][space][space][space]padapter->halpriv.hal_bus_init...

regards,
dan carpenter