From: Greg KH <gregkh@linuxfoundation.org>
To: Nitin Kuppelur <nitinkuppelur@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] Staging: rtl8712 removed unnecessary else after return
Date: Wed, 8 Oct 2014 15:44:14 -0700 [thread overview]
Message-ID: <20141008224414.GA25262@kroah.com> (raw)
In-Reply-To: <1412253146-3568-1-git-send-email-nitinkuppelur@gmail.com>
On Thu, Oct 02, 2014 at 02:32:26PM +0200, Nitin Kuppelur wrote:
> Removed unnecessary else after return to solve
> checkpatch.pl warning
>
> Signed-off-by: Nitin Kuppelur <nitinkuppelur@gmail.com>
> ---
> drivers/staging/rtl8712/hal_init.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c
> index 81cd654..fbaba11 100644
> --- a/drivers/staging/rtl8712/hal_init.c
> +++ b/drivers/staging/rtl8712/hal_init.c
> @@ -387,12 +387,9 @@ uint rtl8712_hal_deinit(struct _adapter *padapter)
> uint rtl871x_hal_init(struct _adapter *padapter)
> {
> padapter->hw_init_completed = false;
> - if (padapter->halpriv.hal_bus_init == NULL)
> + if (padapter->halpriv.hal_bus_init == NULL ||
> + padapter->halpriv.hal_bus_init(padapter) != _SUCCESS)
> return _FAIL;
> - else {
> - if (padapter->halpriv.hal_bus_init(padapter) != _SUCCESS)
> - return _FAIL;
> - }
> if (rtl8712_hal_init(padapter) == _SUCCESS)
> padapter->hw_init_completed = true;
> else {
This doesn't apply to my tree :(
next prev parent reply other threads:[~2014-10-08 22:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 14:44 [PATCH] Staging: rtl8712 removed unnecessary else after return Nitin Kuppelur
2014-10-01 17:44 ` Joe Perches
2014-10-02 7:39 ` Nitin Kuppelur
2014-10-02 7:44 ` [PATCH V2] " Nitin Kuppelur
2014-10-02 8:47 ` Dan Carpenter
2014-10-02 11:33 ` [PATCH] " Nitin Kuppelur
2014-10-02 12:32 ` [PATCH V3] " Nitin Kuppelur
2014-10-08 22:44 ` Greg KH [this message]
2014-10-09 15:30 ` Nitin Kuppelur
2014-10-09 15:48 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141008224414.GA25262@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nitinkuppelur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.