From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org
Subject: Re: [PATCH v2 2/4] host1x: MIPI: Preserve the contents of MIPI_CAL_CTRL
Date: Thu, 2 Oct 2014 14:17:43 +0200 [thread overview]
Message-ID: <20141002121742.GB13906@ulmo> (raw)
In-Reply-To: <1410360725-4286-3-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
On Wed, Sep 10, 2014 at 10:52:03AM -0400, Sean Paul wrote:
> By paving the CTRL reg value, the current code changes
> MIPI_CAL_PRESCALE ("Auto-cal calibration step prescale")
> from 1us to 0.1us (val=0). In the description for phy's noise
> filter (MIPI_CAL_NOISE_FLT), the TRM states that if the value
> of the prescale is 0 (or 0.1us), the filter should be set
> between 2-5. However, the current code sets it to 0.
>
> For now, let's keep the prescale and filter values as-is, which
> is most likely the power-on-reset values of 0x2 and 0xa, respectively.
>
> Signed-off-by: Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> ---
> Changes in v2:
> - Improved the commit description
Applied, thanks. I did reformat the commit description to take advantage
of the full 72 columns.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-02 12:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 14:52 [PATCH v2 0/4] tegra: Some patches to improve MIPI d-phy calibration Sean Paul
[not found] ` <1410360725-4286-1-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-09-10 14:52 ` [PATCH v2 1/4] clk: tegra: Move mipi-cal initialization into clk-tegra1[12]4.c Sean Paul
[not found] ` <1410360725-4286-2-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-09-10 16:17 ` Stephen Warren
[not found] ` <541079A8.9080304-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-09-18 11:26 ` Peter De Schrijver
[not found] ` <20140918112621.GK26779-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-09-18 18:59 ` Sean Paul
[not found] ` <CAOw6vb+pyD9fk63rQHV5S3ar2hrWKb-HRf6ZP8odxbvz7FJ+Vw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-19 11:28 ` Peter De Schrijver
[not found] ` <20140919112802.GO26779-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-10-01 18:38 ` Sean Paul
[not found] ` <CAOw6vbLxNXSw3xfLZk4KKXGSJhbrHR9LEAPJ3hKHZMCN6WeV0w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-07 20:07 ` Sean Paul
[not found] ` <CAOw6vbKozeDR+2KCTwhwRoNY7+k=FB96Vc7sHXKy4SFYMVEeHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-08 7:20 ` Thierry Reding
2014-10-08 15:10 ` Peter De Schrijver
[not found] ` <20141008151019.GB4809-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-10-08 16:19 ` Sean Paul
[not found] ` <CAOw6vbJnrdv2Hn=bY5RQyjjzKXqgCXayMyBvc6MqYq1EtdR8rw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-13 8:20 ` Peter De Schrijver
2014-09-10 14:52 ` [PATCH v2 2/4] host1x: MIPI: Preserve the contents of MIPI_CAL_CTRL Sean Paul
[not found] ` <1410360725-4286-3-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-10-02 12:17 ` Thierry Reding [this message]
2014-09-10 14:52 ` [PATCH v2 3/4] host1x: MIPI: Include clock lanes in MIPI calibrate Sean Paul
2014-09-10 14:52 ` [PATCH v2 4/4] host1x: MIPI: Set MIPI_CAL_BIAS_PAD_CFG1 register Sean Paul
2014-09-10 16:14 ` [PATCH v2 0/4] tegra: Some patches to improve MIPI d-phy calibration Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002121742.GB13906@ulmo \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.