From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Peter De Schrijver
<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org
Subject: Re: [PATCH v2 1/4] clk: tegra: Move mipi-cal initialization into clk-tegra1[12]4.c
Date: Wed, 10 Sep 2014 10:17:44 -0600 [thread overview]
Message-ID: <541079A8.9080304@wwwdotorg.org> (raw)
In-Reply-To: <1410360725-4286-2-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
On 09/10/2014 08:52 AM, Sean Paul wrote:
> This patch moves the mipi-cal gate registration down into the SoC
> specific files to reflect the different in parent between them.
>
> Without this change, MIPI calibration will fail on K1 devices if
> the 72MHz clock is off.
This isn't a problem with this patch per se, but I notice that what's
removed from clk-tegra-periph.c is data in a table, whereas open-coded
calls are added to clk-tegra*.c. It'd be nice if the open-coded calls in
clk-tegra*.c could be converted to a table (simply with SoC-specific
data) and processed by the same function. Peter, would that make sense?
next prev parent reply other threads:[~2014-09-10 16:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 14:52 [PATCH v2 0/4] tegra: Some patches to improve MIPI d-phy calibration Sean Paul
[not found] ` <1410360725-4286-1-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-09-10 14:52 ` [PATCH v2 1/4] clk: tegra: Move mipi-cal initialization into clk-tegra1[12]4.c Sean Paul
[not found] ` <1410360725-4286-2-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-09-10 16:17 ` Stephen Warren [this message]
[not found] ` <541079A8.9080304-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-09-18 11:26 ` Peter De Schrijver
[not found] ` <20140918112621.GK26779-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-09-18 18:59 ` Sean Paul
[not found] ` <CAOw6vb+pyD9fk63rQHV5S3ar2hrWKb-HRf6ZP8odxbvz7FJ+Vw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-19 11:28 ` Peter De Schrijver
[not found] ` <20140919112802.GO26779-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-10-01 18:38 ` Sean Paul
[not found] ` <CAOw6vbLxNXSw3xfLZk4KKXGSJhbrHR9LEAPJ3hKHZMCN6WeV0w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-07 20:07 ` Sean Paul
[not found] ` <CAOw6vbKozeDR+2KCTwhwRoNY7+k=FB96Vc7sHXKy4SFYMVEeHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-08 7:20 ` Thierry Reding
2014-10-08 15:10 ` Peter De Schrijver
[not found] ` <20141008151019.GB4809-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-10-08 16:19 ` Sean Paul
[not found] ` <CAOw6vbJnrdv2Hn=bY5RQyjjzKXqgCXayMyBvc6MqYq1EtdR8rw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-13 8:20 ` Peter De Schrijver
2014-09-10 14:52 ` [PATCH v2 2/4] host1x: MIPI: Preserve the contents of MIPI_CAL_CTRL Sean Paul
[not found] ` <1410360725-4286-3-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-10-02 12:17 ` Thierry Reding
2014-09-10 14:52 ` [PATCH v2 3/4] host1x: MIPI: Include clock lanes in MIPI calibrate Sean Paul
2014-09-10 14:52 ` [PATCH v2 4/4] host1x: MIPI: Set MIPI_CAL_BIAS_PAD_CFG1 register Sean Paul
2014-09-10 16:14 ` [PATCH v2 0/4] tegra: Some patches to improve MIPI d-phy calibration Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541079A8.9080304@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.