From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [patch] checkpatch: remove the ether_addr_copy warning
Date: Fri, 03 Oct 2014 14:47:29 +0000 [thread overview]
Message-ID: <20141003144729.GK23154@mwanda> (raw)
In-Reply-To: <1412346147.3247.97.camel@joe-AO725>
On Fri, Oct 03, 2014 at 07:22:27AM -0700, Joe Perches wrote:
> On Fri, 2014-10-03 at 12:35 +0300, Dan Carpenter wrote:
> > Most people sending checkpatch.pl fixes don't know how to verify the
> > alignment. This checkpatch warning just encourages newbies to try
> > introduce bugs. Patch submitters tell us that they just sed the code
> > and it's the job for the maintainer to check that it's correct.
>
> I haven't seen many instances of bad patch submittals
> on netdev. Is this mostly an issue for staging?
I don't follow netdev so I can't say.
Most of the time data is aligned at a 4 byte mark so probably you are
just getting lucky. I really doubt that netdev checkpatch newbies know
about alignment...
>
> Maybe a downgrade to CHK requiring --strict is OK.
I would actually like to turn --strict by default in staging.
Checkpatch is a good concept, but it should only do safe things instead
of telling newbies to send buggy patches.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [patch] checkpatch: remove the ether_addr_copy warning
Date: Fri, 3 Oct 2014 17:47:29 +0300 [thread overview]
Message-ID: <20141003144729.GK23154@mwanda> (raw)
In-Reply-To: <1412346147.3247.97.camel@joe-AO725>
On Fri, Oct 03, 2014 at 07:22:27AM -0700, Joe Perches wrote:
> On Fri, 2014-10-03 at 12:35 +0300, Dan Carpenter wrote:
> > Most people sending checkpatch.pl fixes don't know how to verify the
> > alignment. This checkpatch warning just encourages newbies to try
> > introduce bugs. Patch submitters tell us that they just sed the code
> > and it's the job for the maintainer to check that it's correct.
>
> I haven't seen many instances of bad patch submittals
> on netdev. Is this mostly an issue for staging?
I don't follow netdev so I can't say.
Most of the time data is aligned at a 4 byte mark so probably you are
just getting lucky. I really doubt that netdev checkpatch newbies know
about alignment...
>
> Maybe a downgrade to CHK requiring --strict is OK.
I would actually like to turn --strict by default in staging.
Checkpatch is a good concept, but it should only do safe things instead
of telling newbies to send buggy patches.
regards,
dan carpenter
next prev parent reply other threads:[~2014-10-03 14:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 9:35 [patch] checkpatch: remove the ether_addr_copy warning Dan Carpenter
2014-10-03 9:35 ` Dan Carpenter
2014-10-03 14:22 ` Joe Perches
2014-10-03 14:22 ` Joe Perches
2014-10-03 14:30 ` Julia Lawall
2014-10-03 14:30 ` Julia Lawall
2014-10-03 15:10 ` Joe Perches
2014-10-03 15:10 ` Joe Perches
2014-10-03 15:14 ` Julia Lawall
2014-10-03 15:14 ` Julia Lawall
2014-10-03 14:47 ` Dan Carpenter [this message]
2014-10-03 14:47 ` Dan Carpenter
2014-10-03 15:11 ` Joe Perches
2014-10-03 15:11 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141003144729.GK23154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.