From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] usb: chipidea: Fix oops when removing the ci_hdrc module
Date: Sat, 4 Oct 2014 10:48:55 +0800 [thread overview]
Message-ID: <20141004024853.GA3713@peterchendt> (raw)
In-Reply-To: <1412326880-3268-1-git-send-email-to-fleischer@t-online.de>
On Fri, Oct 03, 2014 at 11:01:20AM +0200, Torsten Fleischer wrote:
> The call of 'kfree(ci->hw_bank.regmap)' in ci_hdrc_remove() sometimes causes
> a kernel oops when removing the ci_hdrc module.
>
> Since there is no separate memory allocated for the ci->hw_bank.regmap array,
> there is no need to free it.
>
> Signed-off-by: Torsten Fleischer <to-fleischer@t-online.de>
> ---
> drivers/usb/chipidea/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 619d13e..4ecb650 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -732,7 +732,6 @@ static int ci_hdrc_remove(struct platform_device *pdev)
> ci_role_destroy(ci);
> ci_hdrc_enter_lpm(ci, true);
> usb_phy_shutdown(ci->transceiver);
> - kfree(ci->hw_bank.regmap);
>
> return 0;
> }
> --
> 1.8.4.5
>
Good fix, applied, thanks.
--
Best Regards,
Peter Chen
WARNING: multiple messages have this Message-ID (diff)
From: Peter Chen <peter.chen@freescale.com>
To: Torsten Fleischer <to-fleischer@t-online.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] usb: chipidea: Fix oops when removing the ci_hdrc module
Date: Sat, 4 Oct 2014 10:48:55 +0800 [thread overview]
Message-ID: <20141004024853.GA3713@peterchendt> (raw)
In-Reply-To: <1412326880-3268-1-git-send-email-to-fleischer@t-online.de>
On Fri, Oct 03, 2014 at 11:01:20AM +0200, Torsten Fleischer wrote:
> The call of 'kfree(ci->hw_bank.regmap)' in ci_hdrc_remove() sometimes causes
> a kernel oops when removing the ci_hdrc module.
>
> Since there is no separate memory allocated for the ci->hw_bank.regmap array,
> there is no need to free it.
>
> Signed-off-by: Torsten Fleischer <to-fleischer@t-online.de>
> ---
> drivers/usb/chipidea/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 619d13e..4ecb650 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -732,7 +732,6 @@ static int ci_hdrc_remove(struct platform_device *pdev)
> ci_role_destroy(ci);
> ci_hdrc_enter_lpm(ci, true);
> usb_phy_shutdown(ci->transceiver);
> - kfree(ci->hw_bank.regmap);
>
> return 0;
> }
> --
> 1.8.4.5
>
Good fix, applied, thanks.
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2014-10-04 2:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 9:01 [PATCH 1/1] usb: chipidea: Fix oops when removing the ci_hdrc module Torsten Fleischer
2014-10-04 2:48 ` Peter Chen [this message]
2014-10-04 2:48 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141004024853.GA3713@peterchendt \
--to=peter.chen@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.