* [Buildroot] [PATCH] package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS
@ 2014-10-04 17:19 Samuel Martin
2014-10-04 17:21 ` Thomas Petazzoni
2014-10-04 17:22 ` Yann E. MORIN
0 siblings, 2 replies; 5+ messages in thread
From: Samuel Martin @ 2014-10-04 17:19 UTC (permalink / raw)
To: buildroot
This pacth renames, consistently with the other package infrastructures,
the _INSTALL_OPTS variable for host CMake-based package.
As mentioned in [1], no host-cmake-package uses this variable so far; so
it is a safe rename.
[1] http://lists.busybox.net/pipermail/buildroot/2014-October/107712.html
Reported-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Samuel Martin <s.martin49@gmail.com>
---
package/pkg-cmake.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
index 85d8828..2bea003 100644
--- a/package/pkg-cmake.mk
+++ b/package/pkg-cmake.mk
@@ -41,7 +41,7 @@ $(2)_CONF_OPTS ?=
$(2)_MAKE ?= $$(MAKE)
$(2)_MAKE_ENV ?=
$(2)_MAKE_OPTS ?=
-$(2)_INSTALL_HOST_OPTS ?= install
+$(2)_INSTALL_OPTS ?= install
$(2)_INSTALL_STAGING_OPTS ?= DESTDIR=$$(STAGING_DIR) install
$(2)_INSTALL_TARGET_OPTS ?= DESTDIR=$$(TARGET_DIR) install
--
2.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS
2014-10-04 17:19 [Buildroot] [PATCH] package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS Samuel Martin
@ 2014-10-04 17:21 ` Thomas Petazzoni
2014-10-04 17:26 ` Yann E. MORIN
2014-10-04 17:28 ` Samuel Martin
2014-10-04 17:22 ` Yann E. MORIN
1 sibling, 2 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2014-10-04 17:21 UTC (permalink / raw)
To: buildroot
Dear Samuel Martin,
On Sat, 4 Oct 2014 19:19:02 +0200, Samuel Martin wrote:
> This pacth renames, consistently with the other package infrastructures,
> the _INSTALL_OPTS variable for host CMake-based package.
>
> As mentioned in [1], no host-cmake-package uses this variable so far; so
> it is a safe rename.
>
> [1] http://lists.busybox.net/pipermail/buildroot/2014-October/107712.html
>
> Reported-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
> package/pkg-cmake.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
What about the manual?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS
2014-10-04 17:21 ` Thomas Petazzoni
@ 2014-10-04 17:26 ` Yann E. MORIN
2014-10-04 17:28 ` Samuel Martin
1 sibling, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2014-10-04 17:26 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2014-10-04 19:21 +0200, Thomas Petazzoni spake thusly:
> Dear Samuel Martin,
>
> On Sat, 4 Oct 2014 19:19:02 +0200, Samuel Martin wrote:
> > This pacth renames, consistently with the other package infrastructures,
> > the _INSTALL_OPTS variable for host CMake-based package.
> >
> > As mentioned in [1], no host-cmake-package uses this variable so far; so
> > it is a safe rename.
> >
> > [1] http://lists.busybox.net/pipermail/buildroot/2014-October/107712.html
> >
> > Reported-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> > ---
> > package/pkg-cmake.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> What about the manual?
That's what I thought at first, too. But there is no reason to document
it, as it is already covered in generic package infra:
* HOST_LIBFOO_INSTALL_CMDS lists the actions to be performed to
install the package, when the package is a host package. [...]
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS
2014-10-04 17:21 ` Thomas Petazzoni
2014-10-04 17:26 ` Yann E. MORIN
@ 2014-10-04 17:28 ` Samuel Martin
1 sibling, 0 replies; 5+ messages in thread
From: Samuel Martin @ 2014-10-04 17:28 UTC (permalink / raw)
To: buildroot
Thomas,
On Sat, Oct 4, 2014 at 7:21 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Samuel Martin,
>
> On Sat, 4 Oct 2014 19:19:02 +0200, Samuel Martin wrote:
>> This pacth renames, consistently with the other package infrastructures,
>> the _INSTALL_OPTS variable for host CMake-based package.
>>
>> As mentioned in [1], no host-cmake-package uses this variable so far; so
>> it is a safe rename.
>>
>> [1] http://lists.busybox.net/pipermail/buildroot/2014-October/107712.html
>>
>> Reported-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
>> ---
>> package/pkg-cmake.mk | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> What about the manual?
There is no mention of _INSTALL_OPTS or _INSTALL_HOST_OPTS in the manual.
Shall I add one? (not even in the generic infra doc).
It seems host-package documentation is +/- missing in the manual. :-/
BTW, do not apply this patch, I forgot some occurence of the renaming.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
Thanks,
--
Samuel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS
2014-10-04 17:19 [Buildroot] [PATCH] package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS Samuel Martin
2014-10-04 17:21 ` Thomas Petazzoni
@ 2014-10-04 17:22 ` Yann E. MORIN
1 sibling, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2014-10-04 17:22 UTC (permalink / raw)
To: buildroot
Samuel, All,
On 2014-10-04 19:19 +0200, Samuel Martin spake thusly:
> This pacth renames, consistently with the other package infrastructures,
> the _INSTALL_OPTS variable for host CMake-based package.
>
> As mentioned in [1], no host-cmake-package uses this variable so far; so
> it is a safe rename.
>
> [1] http://lists.busybox.net/pipermail/buildroot/2014-October/107712.html
>
> Reported-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/pkg-cmake.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
> index 85d8828..2bea003 100644
> --- a/package/pkg-cmake.mk
> +++ b/package/pkg-cmake.mk
> @@ -41,7 +41,7 @@ $(2)_CONF_OPTS ?=
> $(2)_MAKE ?= $$(MAKE)
> $(2)_MAKE_ENV ?=
> $(2)_MAKE_OPTS ?=
> -$(2)_INSTALL_HOST_OPTS ?= install
> +$(2)_INSTALL_OPTS ?= install
> $(2)_INSTALL_STAGING_OPTS ?= DESTDIR=$$(STAGING_DIR) install
> $(2)_INSTALL_TARGET_OPTS ?= DESTDIR=$$(TARGET_DIR) install
>
> --
> 2.1.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-10-04 17:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-04 17:19 [Buildroot] [PATCH] package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS Samuel Martin
2014-10-04 17:21 ` Thomas Petazzoni
2014-10-04 17:26 ` Yann E. MORIN
2014-10-04 17:28 ` Samuel Martin
2014-10-04 17:22 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.