From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Jingoo Han <jg1.han@samsung.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio: pci: Use SIMPLE_DEV_PM_OPS macro
Date: Sun, 5 Oct 2014 18:49:00 +0300 [thread overview]
Message-ID: <20141005154900.GA14877@redhat.com> (raw)
In-Reply-To: <87oaudo62p.fsf@rustcorp.com.au>
On Thu, Sep 18, 2014 at 02:53:10PM +0930, Rusty Russell wrote:
> Jingoo Han <jg1.han@samsung.com> writes:
> > On Tuesday, September 09, 2014 9:14 AM, Rusty Russell wrote:
> >> Jingoo Han <jg1.han@samsung.com> writes:
> >> > Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler.
> >> >
> >> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> >>
> >> This patch is obviously wrong. It won't compile without
> >> CONFIG_PM_SLEEP.
> >
> > No, there is no compile issue.
> > When, CONFIG_PM_SLEEP=n, there is no build error.
>
> My mistake. Thanks, I've applied it. It probably won't go in until the
> next merge window, however, since I'm travelling for this one.
>
> Cheers,
> Rusty.
I have some bugfixes that are I think worth merging, so maybe
I'll do a pull request.
If so, this cleanup could go in, on top.
Rusty, what do you say?
--
MST
prev parent reply other threads:[~2014-10-05 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 3:52 [PATCH] virtio: pci: Use SIMPLE_DEV_PM_OPS macro Jingoo Han
2014-09-09 0:13 ` Rusty Russell
2014-09-17 9:52 ` Jingoo Han
2014-09-18 5:23 ` Rusty Russell
2014-10-05 15:49 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141005154900.GA14877@redhat.com \
--to=mst@redhat.com \
--cc=jg1.han@samsung.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.