All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
Cc: 'Jingoo Han' <jg1.han@samsung.com>,
	virtualization@lists.linux-foundation.org,
	"'Michael S. Tsirkin'" <mst@redhat.com>
Subject: Re: [PATCH] virtio: pci: Use SIMPLE_DEV_PM_OPS macro
Date: Thu, 18 Sep 2014 14:53:10 +0930	[thread overview]
Message-ID: <87oaudo62p.fsf@rustcorp.com.au> (raw)
In-Reply-To: <000d01cfd25d$0add23d0$20976b70$%han@samsung.com>

Jingoo Han <jg1.han@samsung.com> writes:
> On Tuesday, September 09, 2014 9:14 AM, Rusty Russell wrote:
>> Jingoo Han <jg1.han@samsung.com> writes:
>> > Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler.
>> >
>> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>> 
>> This patch is obviously wrong.  It won't compile without
>> CONFIG_PM_SLEEP.
>
> No, there is no compile issue.
> When, CONFIG_PM_SLEEP=n, there is no build error.

My mistake.  Thanks, I've applied it.  It probably won't go in until the
next merge window, however, since I'm travelling for this one.

Cheers,
Rusty.

  reply	other threads:[~2014-09-18  5:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-05  3:52 [PATCH] virtio: pci: Use SIMPLE_DEV_PM_OPS macro Jingoo Han
2014-09-09  0:13 ` Rusty Russell
2014-09-17  9:52   ` Jingoo Han
2014-09-18  5:23     ` Rusty Russell [this message]
2014-10-05 15:49       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oaudo62p.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=jg1.han@samsung.com \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.