From: Guenter Roeck <linux@roeck-us.net>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Jason Noakes <jjnoakes@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: kobject_init and the zeroed-out-memory requirement
Date: Sun, 5 Oct 2014 19:09:50 -0700 [thread overview]
Message-ID: <20141006020950.GA29722@roeck-us.net> (raw)
In-Reply-To: <20141005232457.GA22525@kroah.com>
On Sun, Oct 05, 2014 at 04:24:57PM -0700, Greg KH wrote:
> On Sun, Oct 05, 2014 at 06:13:05PM -0400, Jason Noakes wrote:
> > > No driver should be working with "raw" kobjects.
> >
> > I don't agree, but it's irrelevant.
>
> Not at all. I'd wager that if a driver is messing around with a "raw"
> kobject, it is doing something seriously wrong. Of course there are
> exceptions, but those are very rare, and exceptions. A driver should be
> using the driver core, and the functions and objects provided there, and
> provided by the bus it lives on.
>
> So, have a pointer to some driver code that is calling
> kobject_initialize()? I'd love to see it.
>
Lots to choose from. In drivers/:
$ git grep kobject_init | wc
65 289 4880
$ git grep kobject_init | grep -v base | wc
62 277 4694
$ git grep kobject_init_and_add | grep -v base | wc
47 232 3698
$ git grep kobject_add | grep -v base | wc
20 111 1486
Guenter
next prev parent reply other threads:[~2014-10-06 2:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAN2+FEJY29jDF2PkGAYcG_0z=VQ4T+y7Ro56aeqrhSPYQ6ZEdw@mail.gmail.com>
2014-10-05 20:05 ` Fwd: kobject_init and the zeroed-out-memory requirement Jason Noakes
2014-10-05 20:28 ` Greg KH
2014-10-05 20:47 ` Jason Noakes
2014-10-05 21:51 ` Greg KH
2014-10-05 22:13 ` Jason Noakes
2014-10-05 23:24 ` Greg KH
2014-10-06 2:09 ` Guenter Roeck [this message]
2014-10-06 3:25 ` Greg KH
2014-10-06 5:18 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141006020950.GA29722@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gregkh@linuxfoundation.org \
--cc=jjnoakes@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.