From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 11/16] virtio_net: minor cleanup
Date: Mon, 6 Oct 2014 14:06:40 +0200 [thread overview]
Message-ID: <20141006140640.36ff345f.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1412525038-15871-12-git-send-email-mst@redhat.com>
On Sun, 5 Oct 2014 19:07:21 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> goto done;
> done:
> return;
> is ugly, it was put there to make diff review easier.
> replace by open-coded return.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/net/virtio_net.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
If you don't want to merge it into the mutex removal patch, maybe move
it one up in the series?
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 11/16] virtio_net: minor cleanup
Date: Mon, 6 Oct 2014 14:06:40 +0200 [thread overview]
Message-ID: <20141006140640.36ff345f.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1412525038-15871-12-git-send-email-mst@redhat.com>
On Sun, 5 Oct 2014 19:07:21 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> goto done;
> done:
> return;
> is ugly, it was put there to make diff review easier.
> replace by open-coded return.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/net/virtio_net.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
If you don't want to merge it into the mutex removal patch, maybe move
it one up in the series?
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
next prev parent reply other threads:[~2014-10-06 12:06 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-05 16:06 [PATCH 00/16] virtio: fix spec compliance issues Michael S. Tsirkin
2014-10-05 16:06 ` Michael S. Tsirkin
2014-10-05 16:06 ` [PATCH 01/16] virtio_pci: fix virtio spec compliance on restore Michael S. Tsirkin
2014-10-05 16:06 ` Michael S. Tsirkin
2014-10-05 16:06 ` [PATCH 02/16] virtio: unify config_changed handling Michael S. Tsirkin
2014-10-05 16:06 ` Michael S. Tsirkin
2014-10-06 9:20 ` Cornelia Huck
2014-10-06 9:20 ` Cornelia Huck
2014-10-05 16:06 ` [PATCH 03/16] virtio: refactor to use drv_to_virtio Michael S. Tsirkin
2014-10-05 16:06 ` Michael S. Tsirkin
2014-10-06 10:34 ` Cornelia Huck
2014-10-05 16:07 ` [PATCH 04/16] virtio-pci: move freeze/restore to virtio core Michael S. Tsirkin
2014-10-05 16:07 ` Michael S. Tsirkin
2014-10-06 10:54 ` Cornelia Huck
2014-10-05 16:07 ` [PATCH 05/16] virtio: defer config changed notifications Michael S. Tsirkin
2014-10-05 16:07 ` Michael S. Tsirkin
2014-10-06 11:33 ` Cornelia Huck
2014-10-06 12:00 ` Michael S. Tsirkin
2014-10-05 16:07 ` [PATCH 06/16] virtio_blk: drop config_enable Michael S. Tsirkin
2014-10-05 16:07 ` Michael S. Tsirkin
2014-10-06 11:42 ` Cornelia Huck
2014-10-06 12:09 ` Michael S. Tsirkin
2014-10-06 12:20 ` Cornelia Huck
2014-10-06 12:31 ` Michael S. Tsirkin
2014-10-06 12:55 ` Cornelia Huck
2014-10-05 16:07 ` [PATCH 07/16] virtio-blk: drop config_mutex Michael S. Tsirkin
2014-10-05 16:07 ` Michael S. Tsirkin
2014-10-06 11:48 ` Cornelia Huck
2014-10-05 16:07 ` [PATCH 08/16] virtio_net: drop config_enable Michael S. Tsirkin
2014-10-06 11:50 ` Cornelia Huck
2014-10-06 11:50 ` Cornelia Huck
2014-10-06 12:10 ` Michael S. Tsirkin
2014-10-06 12:10 ` Michael S. Tsirkin
2014-10-06 19:02 ` David Miller
2014-10-06 19:02 ` David Miller
2014-10-07 6:49 ` Michael S. Tsirkin
2014-10-07 6:49 ` Michael S. Tsirkin
2014-10-07 15:36 ` David Miller
2014-10-07 15:36 ` David Miller
2014-10-07 15:42 ` Michael S. Tsirkin
2014-10-07 15:42 ` Michael S. Tsirkin
2014-10-05 16:07 ` Michael S. Tsirkin
2014-10-05 16:07 ` [PATCH 09/16] virtio-net: drop config_mutex Michael S. Tsirkin
2014-10-05 16:07 ` Michael S. Tsirkin
2014-10-06 11:46 ` Sergei Shtylyov
2014-10-06 11:46 ` Sergei Shtylyov
2014-10-06 11:56 ` Michael S. Tsirkin
2014-10-06 11:56 ` Michael S. Tsirkin
2014-10-06 12:07 ` Sergei Shtylyov
2014-10-06 12:07 ` Sergei Shtylyov
2014-10-06 12:22 ` Michael S. Tsirkin
2014-10-06 12:22 ` Michael S. Tsirkin
2014-10-06 12:31 ` Sergei Shtylyov
2014-10-06 12:31 ` Sergei Shtylyov
2014-10-06 11:56 ` Cornelia Huck
2014-10-06 11:56 ` Cornelia Huck
2014-10-06 12:01 ` Michael S. Tsirkin
2014-10-06 12:01 ` Michael S. Tsirkin
2014-10-05 16:07 ` [PATCH 10/16] virtio: add API to enable VQs early Michael S. Tsirkin
2014-10-06 14:08 ` Cornelia Huck
2014-10-06 14:51 ` Michael S. Tsirkin
2014-10-05 16:07 ` Michael S. Tsirkin
2014-10-05 16:07 ` [PATCH 11/16] virtio_net: minor cleanup Michael S. Tsirkin
2014-10-05 16:07 ` Michael S. Tsirkin
2014-10-06 12:06 ` Cornelia Huck [this message]
2014-10-06 12:06 ` Cornelia Huck
2014-10-05 16:07 ` [PATCH 12/16] virtio_net: enable VQs early Michael S. Tsirkin
2014-10-05 16:07 ` Michael S. Tsirkin
2014-10-05 16:07 ` [PATCH 13/16] virtio_blk: " Michael S. Tsirkin
2014-10-05 16:07 ` Michael S. Tsirkin
2014-10-05 16:07 ` [PATCH 14/16] virtio_console: " Michael S. Tsirkin
2014-10-05 16:07 ` Michael S. Tsirkin
2014-10-05 16:07 ` [PATCH 15/16] 9p/trans_virtio: " Michael S. Tsirkin
2014-10-05 16:07 ` [PATCH 16/16] virtio_net: fix use after free on allocation failure Michael S. Tsirkin
2014-10-05 16:07 ` Michael S. Tsirkin
2014-10-06 14:17 ` Cornelia Huck
2014-10-06 14:17 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141006140640.36ff345f.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.