All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
	jonsmirl@gmail.com, Simon <longsleep@gmail.com>,
	linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCHv7 1/2] pwm: Add Allwinner SoC support
Date: Mon, 6 Oct 2014 16:43:21 +0200	[thread overview]
Message-ID: <20141006144320.GF15599@piout.net> (raw)
In-Reply-To: <20141006143008.GC15599@piout.net>

Oops, missing line:

On 06/10/2014 at 16:30:08 +0200, Alexandre Belloni wrote :
> > > +static const u32 prescaler_table[] = {
> > > +	120,
> > > +	180,
> > > +	240,
> > > +	360,
> > > +	480,
> > > +	0,
> > > +	0,
> > > +	0,
> > > +	12000,
> > > +	24000,
> > > +	36000,
> > > +	48000,
> > > +	72000,
> > > +	0,
> > > +	0,
> > > +	0, /* Actually 1 but tested separately */
> > > +};
> > 
> > Did I already mention that this was really weird?
> > 
> 
> I'm not sure what you want to do here then. This is simply coming from
> the datasheet. The last one (0xF) being a bypass is actually only existing on 

A20 and later.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv7 1/2] pwm: Add Allwinner SoC support
Date: Mon, 6 Oct 2014 16:43:21 +0200	[thread overview]
Message-ID: <20141006144320.GF15599@piout.net> (raw)
In-Reply-To: <20141006143008.GC15599@piout.net>

Oops, missing line:

On 06/10/2014 at 16:30:08 +0200, Alexandre Belloni wrote :
> > > +static const u32 prescaler_table[] = {
> > > +	120,
> > > +	180,
> > > +	240,
> > > +	360,
> > > +	480,
> > > +	0,
> > > +	0,
> > > +	0,
> > > +	12000,
> > > +	24000,
> > > +	36000,
> > > +	48000,
> > > +	72000,
> > > +	0,
> > > +	0,
> > > +	0, /* Actually 1 but tested separately */
> > > +};
> > 
> > Did I already mention that this was really weird?
> > 
> 
> I'm not sure what you want to do here then. This is simply coming from
> the datasheet. The last one (0xF) being a bypass is actually only existing on 

A20 and later.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-10-06 14:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17 19:53 [PATCHv7 0/2] Add Allwinner SoCs PWM support Alexandre Belloni
2014-09-17 19:53 ` Alexandre Belloni
2014-09-17 19:53 ` [PATCHv7 1/2] pwm: Add Allwinner SoC support Alexandre Belloni
2014-09-17 19:53   ` Alexandre Belloni
2014-10-06 13:24   ` Thierry Reding
2014-10-06 13:24     ` Thierry Reding
2014-10-06 14:30     ` Alexandre Belloni
2014-10-06 14:30       ` Alexandre Belloni
2014-10-06 14:43       ` Alexandre Belloni [this message]
2014-10-06 14:43         ` Alexandre Belloni
2014-10-06 14:48       ` Thierry Reding
2014-10-06 14:48         ` Thierry Reding
2014-09-17 19:53 ` [PATCHv7 2/2] pwm: sunxi: document OF bindings Alexandre Belloni
2014-09-17 19:53   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141006144320.GF15599@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=jonsmirl@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=longsleep@gmail.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.