From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] legal-info: fix bug leading to one package not being considered
Date: Mon, 6 Oct 2014 19:28:52 +0200 [thread overview]
Message-ID: <20141006172852.GC4122@free.fr> (raw)
In-Reply-To: <1412612170-31047-1-git-send-email-thomas.petazzoni@free-electrons.com>
Thomas, All,
On 2014-10-06 18:16 +0200, Thomas Petazzoni spake thusly:
> Due to excessive parenthesis, the TARGETS_LEGAL_INFO expression was
> evaluated to something like this:
>
> toolchain-legal-info toolchain-external-legal-info busybox-legal-info zlib-legal-info))
>
> Yes, with the last two parenthesis. This had the effect that the
> zlib-legal-info rule was never called: the last package of $(TARGETS)
> $(TARGET_HOST_DEPS) $(HOST_DEPS) was never added in the legal-info
> information.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Luca Ceresoli <luca@lucaceresoli.net>
Oviously an issue, indeed.
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 6068e7f..3f56648 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -414,7 +414,7 @@ HOST_DEPS = $(sort $(foreach dep,\
> HOST_SOURCE += $(addsuffix -source,$(sort $(TARGETS_HOST_DEPS) $(HOST_DEPS)))
>
> TARGETS_LEGAL_INFO := $(patsubst %,%-legal-info,\
> - $(TARGETS) $(TARGETS_HOST_DEPS) $(HOST_DEPS))))
> + $(TARGETS) $(TARGETS_HOST_DEPS) $(HOST_DEPS))
>
> dirs: $(BUILD_DIR) $(STAGING_DIR) $(TARGET_DIR) \
> $(HOST_DIR) $(BINARIES_DIR)
> --
> 2.0.0
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-10-06 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 16:16 [Buildroot] [PATCH] legal-info: fix bug leading to one package not being considered Thomas Petazzoni
2014-10-06 17:28 ` Yann E. MORIN [this message]
2014-10-06 19:00 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141006172852.GC4122@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.