* [Buildroot] [PATCH] legal-info: fix bug leading to one package not being considered
@ 2014-10-06 16:16 Thomas Petazzoni
2014-10-06 17:28 ` Yann E. MORIN
2014-10-06 19:00 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-10-06 16:16 UTC (permalink / raw)
To: buildroot
Due to excessive parenthesis, the TARGETS_LEGAL_INFO expression was
evaluated to something like this:
toolchain-legal-info toolchain-external-legal-info busybox-legal-info zlib-legal-info))
Yes, with the last two parenthesis. This had the effect that the
zlib-legal-info rule was never called: the last package of $(TARGETS)
$(TARGET_HOST_DEPS) $(HOST_DEPS) was never added in the legal-info
information.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Luca Ceresoli <luca@lucaceresoli.net>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 6068e7f..3f56648 100644
--- a/Makefile
+++ b/Makefile
@@ -414,7 +414,7 @@ HOST_DEPS = $(sort $(foreach dep,\
HOST_SOURCE += $(addsuffix -source,$(sort $(TARGETS_HOST_DEPS) $(HOST_DEPS)))
TARGETS_LEGAL_INFO := $(patsubst %,%-legal-info,\
- $(TARGETS) $(TARGETS_HOST_DEPS) $(HOST_DEPS))))
+ $(TARGETS) $(TARGETS_HOST_DEPS) $(HOST_DEPS))
dirs: $(BUILD_DIR) $(STAGING_DIR) $(TARGET_DIR) \
$(HOST_DIR) $(BINARIES_DIR)
--
2.0.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] legal-info: fix bug leading to one package not being considered
2014-10-06 16:16 [Buildroot] [PATCH] legal-info: fix bug leading to one package not being considered Thomas Petazzoni
@ 2014-10-06 17:28 ` Yann E. MORIN
2014-10-06 19:00 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2014-10-06 17:28 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2014-10-06 18:16 +0200, Thomas Petazzoni spake thusly:
> Due to excessive parenthesis, the TARGETS_LEGAL_INFO expression was
> evaluated to something like this:
>
> toolchain-legal-info toolchain-external-legal-info busybox-legal-info zlib-legal-info))
>
> Yes, with the last two parenthesis. This had the effect that the
> zlib-legal-info rule was never called: the last package of $(TARGETS)
> $(TARGET_HOST_DEPS) $(HOST_DEPS) was never added in the legal-info
> information.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Luca Ceresoli <luca@lucaceresoli.net>
Oviously an issue, indeed.
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 6068e7f..3f56648 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -414,7 +414,7 @@ HOST_DEPS = $(sort $(foreach dep,\
> HOST_SOURCE += $(addsuffix -source,$(sort $(TARGETS_HOST_DEPS) $(HOST_DEPS)))
>
> TARGETS_LEGAL_INFO := $(patsubst %,%-legal-info,\
> - $(TARGETS) $(TARGETS_HOST_DEPS) $(HOST_DEPS))))
> + $(TARGETS) $(TARGETS_HOST_DEPS) $(HOST_DEPS))
>
> dirs: $(BUILD_DIR) $(STAGING_DIR) $(TARGET_DIR) \
> $(HOST_DIR) $(BINARIES_DIR)
> --
> 2.0.0
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] legal-info: fix bug leading to one package not being considered
2014-10-06 16:16 [Buildroot] [PATCH] legal-info: fix bug leading to one package not being considered Thomas Petazzoni
2014-10-06 17:28 ` Yann E. MORIN
@ 2014-10-06 19:00 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-10-06 19:00 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 6 Oct 2014 18:16:10 +0200, Thomas Petazzoni wrote:
> Due to excessive parenthesis, the TARGETS_LEGAL_INFO expression was
> evaluated to something like this:
>
> toolchain-legal-info toolchain-external-legal-info busybox-legal-info zlib-legal-info))
>
> Yes, with the last two parenthesis. This had the effect that the
> zlib-legal-info rule was never called: the last package of $(TARGETS)
> $(TARGET_HOST_DEPS) $(HOST_DEPS) was never added in the legal-info
> information.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Luca Ceresoli <luca@lucaceresoli.net>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-06 19:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-06 16:16 [Buildroot] [PATCH] legal-info: fix bug leading to one package not being considered Thomas Petazzoni
2014-10-06 17:28 ` Yann E. MORIN
2014-10-06 19:00 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.