From: Lee Jones <lee.jones@linaro.org>
To: Johan Hovold <johan@kernel.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 5/6] HID: hid-sensor-hub: use mfd_add_hotplug_devices helper
Date: Tue, 7 Oct 2014 10:24:52 +0100 [thread overview]
Message-ID: <20141007092452.GU25331@lee--X1> (raw)
In-Reply-To: <1411728933-13351-6-git-send-email-johan@kernel.org>
On Fri, 26 Sep 2014, Johan Hovold wrote:
> Use mfd_add_hotplug_devices helper to register the subdevices.
>
> Compile-only tested.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/hid/hid-sensor-hub.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
Applied for v3.19 with Jiri's Ack.
> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
> index 2ac25760a9a9..fbe1a6d2aa53 100644
> --- a/drivers/hid/hid-sensor-hub.c
> +++ b/drivers/hid/hid-sensor-hub.c
> @@ -641,9 +641,6 @@ static int sensor_hub_probe(struct hid_device *hdev,
> goto err_stop_hw;
> }
> sd->hid_sensor_hub_client_devs[
> - sd->hid_sensor_client_cnt].id =
> - PLATFORM_DEVID_AUTO;
> - sd->hid_sensor_hub_client_devs[
> sd->hid_sensor_client_cnt].name = name;
> sd->hid_sensor_hub_client_devs[
> sd->hid_sensor_client_cnt].platform_data =
> @@ -659,8 +656,9 @@ static int sensor_hub_probe(struct hid_device *hdev,
> if (last_hsdev)
> last_hsdev->end_collection_index = i;
>
> - ret = mfd_add_devices(&hdev->dev, 0, sd->hid_sensor_hub_client_devs,
> - sd->hid_sensor_client_cnt, NULL, 0, NULL);
> + ret = mfd_add_hotplug_devices(&hdev->dev,
> + sd->hid_sensor_hub_client_devs,
> + sd->hid_sensor_client_cnt);
> if (ret < 0)
> goto err_stop_hw;
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Johan Hovold <johan@kernel.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 5/6] HID: hid-sensor-hub: use mfd_add_hotplug_devices helper
Date: Tue, 7 Oct 2014 10:24:52 +0100 [thread overview]
Message-ID: <20141007092452.GU25331@lee--X1> (raw)
In-Reply-To: <1411728933-13351-6-git-send-email-johan@kernel.org>
On Fri, 26 Sep 2014, Johan Hovold wrote:
> Use mfd_add_hotplug_devices helper to register the subdevices.
>
> Compile-only tested.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/hid/hid-sensor-hub.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
Applied for v3.19 with Jiri's Ack.
> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
> index 2ac25760a9a9..fbe1a6d2aa53 100644
> --- a/drivers/hid/hid-sensor-hub.c
> +++ b/drivers/hid/hid-sensor-hub.c
> @@ -641,9 +641,6 @@ static int sensor_hub_probe(struct hid_device *hdev,
> goto err_stop_hw;
> }
> sd->hid_sensor_hub_client_devs[
> - sd->hid_sensor_client_cnt].id =
> - PLATFORM_DEVID_AUTO;
> - sd->hid_sensor_hub_client_devs[
> sd->hid_sensor_client_cnt].name = name;
> sd->hid_sensor_hub_client_devs[
> sd->hid_sensor_client_cnt].platform_data =
> @@ -659,8 +656,9 @@ static int sensor_hub_probe(struct hid_device *hdev,
> if (last_hsdev)
> last_hsdev->end_collection_index = i;
>
> - ret = mfd_add_devices(&hdev->dev, 0, sd->hid_sensor_hub_client_devs,
> - sd->hid_sensor_client_cnt, NULL, 0, NULL);
> + ret = mfd_add_hotplug_devices(&hdev->dev,
> + sd->hid_sensor_hub_client_devs,
> + sd->hid_sensor_client_cnt);
> if (ret < 0)
> goto err_stop_hw;
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-10-07 9:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 10:55 [PATCH 0/6] mfd: fix platform-device id collisions Johan Hovold
2014-09-26 10:55 ` Johan Hovold
2014-09-26 10:55 ` [PATCH 1/6] mfd: viperboard: fix platform-device id collision Johan Hovold
2014-10-07 9:21 ` Lee Jones
2014-10-07 9:21 ` Lee Jones
[not found] ` <1411728933-13351-1-git-send-email-johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-09-26 10:55 ` [PATCH 2/6] mfd: rtsx_usb: fix platform device-id collision Johan Hovold
2014-09-26 10:55 ` Johan Hovold
2014-10-07 9:22 ` Lee Jones
2014-10-07 9:22 ` Lee Jones
2014-10-07 12:52 ` Johan Hovold
2014-09-26 10:55 ` [PATCH 3/6] mfd: core: add helper function to register hotplug devices Johan Hovold
2014-10-07 9:24 ` Lee Jones
2014-09-26 10:55 ` [PATCH 4/6] mfd: use mfd_add_hotplug_devices helper Johan Hovold
2014-10-07 9:24 ` Lee Jones
2014-10-07 9:24 ` Lee Jones
2014-09-26 10:55 ` [PATCH 5/6] HID: hid-sensor-hub: " Johan Hovold
2014-09-26 11:25 ` Jiri Kosina
2014-10-07 9:24 ` Lee Jones [this message]
2014-10-07 9:24 ` Lee Jones
2014-09-26 10:55 ` [PATCH 6/6] mfd: core: fix platform-device id generation Johan Hovold
2014-10-07 9:25 ` Lee Jones
2014-10-07 9:25 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007092452.GU25331@lee--X1 \
--to=lee.jones@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jkosina@suse.cz \
--cc=johan@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.