From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xen.org
Subject: dead qemu make targets in toplevel Makefile
Date: Tue, 7 Oct 2014 15:07:27 +0200 [thread overview]
Message-ID: <20141007130727.GA5984@aepfle.de> (raw)
Ian,
with commit b0f69ec5c71de1248d915c193b57c43e786857dd ("tools: Make
qemu-xen-traditional build optional.") the existing make targets are
wrapped in ifeq ($(CONF),y), but CONF is never set because
config/Tools.mk is not included. I wonder if that ever worked or if I
just broke it with my changes. But looking at 4.4.1 I dont see how
CONFIG_QEMU_TRAD is set. And in staging QEMU_TRAD_DIR_TGT is also not
used.
Are these make targets useful? I see "git clean -dfx && ./configure &&
make tools/qemu-xen-traditional-dir CONFIG_QEMU_TRAD=y" clones the tree.
Olaf
72 ifeq ($(CONFIG_QEMU_TRAD),y)
73 QEMU_TRAD_DIR_TGT := tools/qemu-xen-traditional-dir
74
75 tools/qemu-xen-traditional-dir:
76 $(MAKE) -C tools qemu-xen-traditional-dir-find
77
78 .PHONY: tools/qemu-xen-traditional-dir-force-update
79 tools/qemu-xen-traditional-dir-force-update:
80 $(MAKE) -C tools qemu-xen-traditional-dir-force-update
81 endif
82
83 ifeq ($(CONFIG_QEMU_XEN),y)
84 QEMU_XEN_DIR_TGT := tools/qemu-xen-dir
85
86 tools/qemu-xen-dir:
87 $(MAKE) -C tools qemu-xen-dir-find
88
89 .PHONY: tools/qemu-xen-dir-force-update
90 tools/qemu-xen-dir-force-update:
91 $(MAKE) -C tools qemu-xen-dir-force-update
92 endif
next reply other threads:[~2014-10-07 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 13:07 Olaf Hering [this message]
2014-10-07 13:16 ` dead qemu make targets in toplevel Makefile Ian Campbell
2014-10-07 13:26 ` Olaf Hering
2014-10-07 13:28 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007130727.GA5984@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.