All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: xen-devel@lists.xen.org
Subject: Re: dead qemu make targets in toplevel Makefile
Date: Tue, 7 Oct 2014 14:28:46 +0100	[thread overview]
Message-ID: <1412688526.4972.24.camel@citrix.com> (raw)
In-Reply-To: <20141007132611.GA9173@aepfle.de>

On Tue, 2014-10-07 at 15:26 +0200, Olaf Hering wrote:
> On Tue, Oct 07, Ian Campbell wrote:
> 
> > It looks like my build scripts use "make -C tools $FOO-force-update", so
> > removing them would be a problem for me personally.
> 
> The dead code is in the toplevel Makefile, the command above uses
> tools/Makefile.

Sorry, I tried to say "would *not* be a problem", because as you note
I'm using the tools/Makefile version.

> > On the other hand since they are only for use by end users and not
> > dependencies of any other rule I suppose we could just nuke the
> > conditionals but leave the rules themselves?
> 
> Yes, but shouldnt this be easier like "make update-qemu-trad" which
> downloads and forces the tree(s) to be in a given state? And while we
> are at it, I find something like "make clean-qemu-trad" useful. It
> should check if the subdir is a git tree, and do either a "git clean
> -dfx" or "make clean".
> 
> And perhaps all that should be in two easy targets like 'update-subprj'
> and 'clean-subprj'. There is likely a better string than "subprj".

If you want to go further than simply fixing up the existing things then
have at it, I've no in principal objections...

Ian.

      reply	other threads:[~2014-10-07 13:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-07 13:07 dead qemu make targets in toplevel Makefile Olaf Hering
2014-10-07 13:16 ` Ian Campbell
2014-10-07 13:26   ` Olaf Hering
2014-10-07 13:28     ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412688526.4972.24.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=olaf@aepfle.de \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.