From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Gu Zheng <guz.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] i2c: fix a potential kmemleak of adapter device
Date: Tue, 7 Oct 2014 19:34:39 +0200 [thread overview]
Message-ID: <20141007173439.GE1577@katana> (raw)
In-Reply-To: <52B7961D.2050505-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2421 bytes --]
On Mon, Dec 23, 2013 at 09:47:09AM +0800, Gu Zheng wrote:
> Hi Wolfram,
> On 12/21/2013 01:31 AM, Wolfram Sang wrote:
>
> > On Wed, Dec 18, 2013 at 09:18:08AM +0800, Gu Zheng wrote:
> >> When running with the latest kernel, we get the following kmemleak message:
> >> unreferenced object 0xffff8800c2a36100 (size 256):
> >> comm "modprobe", pid 629, jiffies 4294676002 (age 1531.115s)
> >> hex dump (first 32 bytes):
> >> 00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .....N..........
> >> ff ff ff ff ff ff ff ff 78 21 85 82 ff ff ff ff ........x!......
> >> backtrace:
> >> [<ffffffff815449ce>] kmemleak_alloc+0x73/0x98
> >> [<ffffffff8113fa2b>] slab_post_alloc_hook+0x28/0x2a
> >> [<ffffffff81142004>] __kmalloc+0x12c/0x158
> >> [<ffffffff8134c60b>] kzalloc.constprop.6+0xe/0x10
> >> [<ffffffff8134cb71>] device_private_init+0x18/0x66
> >> [<ffffffff8134f1e8>] dev_set_drvdata+0x1e/0x34
> >> [<ffffffffa01e643e>] i801_probe+0x5d/0x447 [i2c_i801]
> >> [<ffffffff812a78be>] local_pci_probe+0x41/0x84
> >> [<ffffffff812a7feb>] pci_device_probe+0xdf/0x10c
> >> [<ffffffff8134f90d>] driver_probe_device+0x12f/0x2ee
> >> [<ffffffff8134fb2b>] __driver_attach+0x5f/0x83
> >> [<ffffffff8134de28>] bus_for_each_dev+0x64/0x90
> >> [<ffffffff8134f36b>] driver_attach+0x1e/0x20
> >> [<ffffffff8134ef34>] bus_add_driver+0xf2/0x1f0
> >> [<ffffffff8135013e>] driver_register+0x8c/0xc3
> >> [<ffffffff812a7bb4>] __pci_register_driver+0x62/0x67
> >> According to the backtrace, it seems that we do not release the
> >> device_private field of adapter device in the fail path of i801_probe
> >> or the flow of i2c_del_adapter, so add the cleanup step to fix it.
> >>
> >> Signed-off-by: Gu Zheng <guz.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> >
> > ? Why should we free something we don't have allocated? The fix must be
> > somewhere else probably...
>
> We do allocate the device_private in device_private_init() when calling
> dev_set_drvdata()
dev_set_drvdata only does the following and doesn't call anything:
dev->driver_data = data;
> to set adapter data in probe flow, and the calltrace
> also shows this. Am I missing something?
It should be freed by the driver core in device_release() again. Dunno
why it does not happen and you are seeing the leak, but the fix is not
correct.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: fix a potential kmemleak of adapter device
Date: Tue, 7 Oct 2014 19:34:39 +0200 [thread overview]
Message-ID: <20141007173439.GE1577@katana> (raw)
In-Reply-To: <52B7961D.2050505@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 2396 bytes --]
On Mon, Dec 23, 2013 at 09:47:09AM +0800, Gu Zheng wrote:
> Hi Wolfram,
> On 12/21/2013 01:31 AM, Wolfram Sang wrote:
>
> > On Wed, Dec 18, 2013 at 09:18:08AM +0800, Gu Zheng wrote:
> >> When running with the latest kernel, we get the following kmemleak message:
> >> unreferenced object 0xffff8800c2a36100 (size 256):
> >> comm "modprobe", pid 629, jiffies 4294676002 (age 1531.115s)
> >> hex dump (first 32 bytes):
> >> 00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .....N..........
> >> ff ff ff ff ff ff ff ff 78 21 85 82 ff ff ff ff ........x!......
> >> backtrace:
> >> [<ffffffff815449ce>] kmemleak_alloc+0x73/0x98
> >> [<ffffffff8113fa2b>] slab_post_alloc_hook+0x28/0x2a
> >> [<ffffffff81142004>] __kmalloc+0x12c/0x158
> >> [<ffffffff8134c60b>] kzalloc.constprop.6+0xe/0x10
> >> [<ffffffff8134cb71>] device_private_init+0x18/0x66
> >> [<ffffffff8134f1e8>] dev_set_drvdata+0x1e/0x34
> >> [<ffffffffa01e643e>] i801_probe+0x5d/0x447 [i2c_i801]
> >> [<ffffffff812a78be>] local_pci_probe+0x41/0x84
> >> [<ffffffff812a7feb>] pci_device_probe+0xdf/0x10c
> >> [<ffffffff8134f90d>] driver_probe_device+0x12f/0x2ee
> >> [<ffffffff8134fb2b>] __driver_attach+0x5f/0x83
> >> [<ffffffff8134de28>] bus_for_each_dev+0x64/0x90
> >> [<ffffffff8134f36b>] driver_attach+0x1e/0x20
> >> [<ffffffff8134ef34>] bus_add_driver+0xf2/0x1f0
> >> [<ffffffff8135013e>] driver_register+0x8c/0xc3
> >> [<ffffffff812a7bb4>] __pci_register_driver+0x62/0x67
> >> According to the backtrace, it seems that we do not release the
> >> device_private field of adapter device in the fail path of i801_probe
> >> or the flow of i2c_del_adapter, so add the cleanup step to fix it.
> >>
> >> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
> >
> > ? Why should we free something we don't have allocated? The fix must be
> > somewhere else probably...
>
> We do allocate the device_private in device_private_init() when calling
> dev_set_drvdata()
dev_set_drvdata only does the following and doesn't call anything:
dev->driver_data = data;
> to set adapter data in probe flow, and the calltrace
> also shows this. Am I missing something?
It should be freed by the driver core in device_release() again. Dunno
why it does not happen and you are seeing the leak, but the fix is not
correct.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-07 17:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 1:18 [PATCH] i2c: fix a potential kmemleak of adapter device Gu Zheng
2013-12-18 1:18 ` Gu Zheng
[not found] ` <52B0F7D0.2020506-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2013-12-20 17:31 ` Wolfram Sang
2013-12-20 17:31 ` Wolfram Sang
2013-12-23 1:47 ` Gu Zheng
2013-12-23 1:47 ` Gu Zheng
[not found] ` <52B7961D.2050505-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2014-10-07 17:34 ` Wolfram Sang [this message]
2014-10-07 17:34 ` Wolfram Sang
2014-10-07 20:24 ` Wolfram Sang
2014-10-07 20:24 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007173439.GE1577@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=guz.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.