From: Thierry Reding <thierry.reding@gmail.com>
To: Vidya Sagar <vidyas@nvidia.com>
Cc: bhelgaas@google.com, swarren@wwwdotorg.org, kthota@nvidia.com,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] PCI: tegra: Enable root port specific features
Date: Wed, 8 Oct 2014 09:47:39 +0200 [thread overview]
Message-ID: <20141008074738.GE4999@ulmo> (raw)
In-Reply-To: <20141008074404.GC4999@ulmo>
[-- Attachment #1: Type: text/plain, Size: 934 bytes --]
On Wed, Oct 08, 2014 at 09:44:05AM +0200, Thierry Reding wrote:
> On Tue, Oct 07, 2014 at 03:57:58PM +0530, Vidya Sagar wrote:
[...]
> > +static inline void rp_writel(struct tegra_pcie_port *port, u32 value,
> > + unsigned long offset)
> > +{
> > + writel(value, offset + port->base);
> > +}
> > +
> > +static inline unsigned int rp_readl(struct tegra_pcie_port *port,
>
> readl() returns u32 and so should rp_readl().
>
> > + unsigned long offset)
> > +{
> > + return readl(offset + port->base);
> > +}
>
> I don't see much use in these, but if you really want to add them,
> please also replace any of the open-coded occurrences of this. Also
> please fix the alignment of function arguments on subsequent lines.
> They should align with the first argument on the first line.
Oh, and perhaps make it a separate (precursory) patch so that this
patch can focus on the PM features.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Vidya Sagar <vidyas-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
kthota-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1] PCI: tegra: Enable root port specific features
Date: Wed, 8 Oct 2014 09:47:39 +0200 [thread overview]
Message-ID: <20141008074738.GE4999@ulmo> (raw)
In-Reply-To: <20141008074404.GC4999@ulmo>
[-- Attachment #1: Type: text/plain, Size: 934 bytes --]
On Wed, Oct 08, 2014 at 09:44:05AM +0200, Thierry Reding wrote:
> On Tue, Oct 07, 2014 at 03:57:58PM +0530, Vidya Sagar wrote:
[...]
> > +static inline void rp_writel(struct tegra_pcie_port *port, u32 value,
> > + unsigned long offset)
> > +{
> > + writel(value, offset + port->base);
> > +}
> > +
> > +static inline unsigned int rp_readl(struct tegra_pcie_port *port,
>
> readl() returns u32 and so should rp_readl().
>
> > + unsigned long offset)
> > +{
> > + return readl(offset + port->base);
> > +}
>
> I don't see much use in these, but if you really want to add them,
> please also replace any of the open-coded occurrences of this. Also
> please fix the alignment of function arguments on subsequent lines.
> They should align with the first argument on the first line.
Oh, and perhaps make it a separate (precursory) patch so that this
patch can focus on the PM features.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-08 7:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 10:27 [PATCH v1] PCI: tegra: Enable root port specific features Vidya Sagar
2014-10-07 10:27 ` Vidya Sagar
2014-10-07 15:44 ` Stephen Warren
2014-10-07 15:44 ` Stephen Warren
2014-10-08 7:45 ` Thierry Reding
2014-10-08 7:44 ` Thierry Reding
2014-10-08 7:44 ` Thierry Reding
2014-10-08 7:47 ` Thierry Reding [this message]
2014-10-08 7:47 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141008074738.GE4999@ulmo \
--to=thierry.reding@gmail.com \
--cc=bhelgaas@google.com \
--cc=kthota@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.