From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, Vladimir Davydov <vdavydov@parallels.com>,
Greg Thelen <gthelen@google.com>, Tejun Heo <tj@kernel.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 0/3] mm: memcontrol: eliminate charge reparenting
Date: Wed, 8 Oct 2014 10:17:54 -0400 [thread overview]
Message-ID: <20141008141754.GD15948@cmpxchg.org> (raw)
In-Reply-To: <20141008124823.GA4592@dhcp22.suse.cz>
On Wed, Oct 08, 2014 at 02:48:23PM +0200, Michal Hocko wrote:
> On Sat 20-09-14 16:00:32, Johannes Weiner wrote:
> > Hi,
> >
> > we've come a looong way when it comes to the basic cgroups model, and
> > the recent changes there open up a lot of opportunity to make drastic
> > simplifications to memory cgroups as well.
> >
> > The decoupling of css from the user-visible cgroup, word-sized per-cpu
> > css reference counters, and css iterators that include offlined groups
> > means we can take per-charge css references, continue to reclaim from
> > offlined groups, and so get rid of the error-prone charge reparenting.
> >
> > Combined with the higher-order reclaim fixes, lockless page counters,
> > and memcg iterator simplification I sent on Friday, the memory cgroup
> > core code is finally no longer the biggest file in mm/. Yay!
>
> Yeah, the code reduction (as per the diffstat - I didn't get to the code
> yet) seems really promising.
:)
> > These patches are based on mmotm + the above-mentioned changes
>
> > + Tj's percpu-refcount conversion to atomic_long_t.
>
> This is https://lkml.org/lkml/2014/9/20/11 right?
Yep, exactly. All these moving parts are now in -next, though, so as
soon as Andrew flushes his tree for 3.18, I'll rebase and resubmit.
Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, Vladimir Davydov <vdavydov@parallels.com>,
Greg Thelen <gthelen@google.com>, Tejun Heo <tj@kernel.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 0/3] mm: memcontrol: eliminate charge reparenting
Date: Wed, 8 Oct 2014 10:17:54 -0400 [thread overview]
Message-ID: <20141008141754.GD15948@cmpxchg.org> (raw)
In-Reply-To: <20141008124823.GA4592@dhcp22.suse.cz>
On Wed, Oct 08, 2014 at 02:48:23PM +0200, Michal Hocko wrote:
> On Sat 20-09-14 16:00:32, Johannes Weiner wrote:
> > Hi,
> >
> > we've come a looong way when it comes to the basic cgroups model, and
> > the recent changes there open up a lot of opportunity to make drastic
> > simplifications to memory cgroups as well.
> >
> > The decoupling of css from the user-visible cgroup, word-sized per-cpu
> > css reference counters, and css iterators that include offlined groups
> > means we can take per-charge css references, continue to reclaim from
> > offlined groups, and so get rid of the error-prone charge reparenting.
> >
> > Combined with the higher-order reclaim fixes, lockless page counters,
> > and memcg iterator simplification I sent on Friday, the memory cgroup
> > core code is finally no longer the biggest file in mm/. Yay!
>
> Yeah, the code reduction (as per the diffstat - I didn't get to the code
> yet) seems really promising.
:)
> > These patches are based on mmotm + the above-mentioned changes
>
> > + Tj's percpu-refcount conversion to atomic_long_t.
>
> This is https://lkml.org/lkml/2014/9/20/11 right?
Yep, exactly. All these moving parts are now in -next, though, so as
soon as Andrew flushes his tree for 3.18, I'll rebase and resubmit.
Thanks!
next prev parent reply other threads:[~2014-10-08 14:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 20:00 [patch 0/3] mm: memcontrol: eliminate charge reparenting Johannes Weiner
2014-09-20 20:00 ` Johannes Weiner
2014-09-20 20:00 ` [patch 1/3] mm: memcontrol: take a css reference for each charged page Johannes Weiner
2014-09-20 20:00 ` Johannes Weiner
2014-09-22 8:24 ` Vladimir Davydov
2014-09-22 8:24 ` Vladimir Davydov
[not found] ` <1411243235-24680-2-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2014-10-08 13:27 ` Michal Hocko
2014-10-08 13:27 ` Michal Hocko
2014-10-08 13:27 ` Michal Hocko
2014-10-08 13:29 ` Michal Hocko
2014-10-08 13:29 ` Michal Hocko
2014-09-20 20:00 ` [patch 2/3] mm: memcontrol: remove obsolete kmemcg pinning tricks Johannes Weiner
2014-09-20 20:00 ` Johannes Weiner
[not found] ` <1411243235-24680-3-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2014-09-22 8:25 ` Vladimir Davydov
2014-09-22 8:25 ` Vladimir Davydov
2014-09-22 8:25 ` Vladimir Davydov
2014-10-08 13:32 ` Michal Hocko
2014-10-08 13:32 ` Michal Hocko
2014-09-20 20:00 ` [patch 3/3] mm: memcontrol: continue cache reclaim from offlined groups Johannes Weiner
2014-09-20 20:00 ` Johannes Weiner
2014-09-22 8:32 ` Vladimir Davydov
2014-09-22 8:32 ` Vladimir Davydov
2014-10-08 14:03 ` Michal Hocko
2014-10-08 14:03 ` Michal Hocko
2014-09-21 15:50 ` [patch 0/3] mm: memcontrol: eliminate charge reparenting Vladimir Davydov
2014-09-21 15:50 ` Vladimir Davydov
[not found] ` <1411243235-24680-1-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2014-10-08 12:48 ` Michal Hocko
2014-10-08 12:48 ` Michal Hocko
2014-10-08 12:48 ` Michal Hocko
2014-10-08 14:17 ` Johannes Weiner [this message]
2014-10-08 14:17 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141008141754.GD15948@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=cgroups@vger.kernel.org \
--cc=gthelen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.