All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 5/6] arm64: add SIGSYS siginfo for compat task
Date: Wed, 8 Oct 2014 15:30:59 +0100	[thread overview]
Message-ID: <20141008143059.GS26140@arm.com> (raw)
In-Reply-To: <1412243176-16192-6-git-send-email-takahiro.akashi@linaro.org>

On Thu, Oct 02, 2014 at 10:46:15AM +0100, AKASHI Takahiro wrote:
> SIGSYS is primarily used in secure computing to notify tracer.
> This patch allows signal handler on compat task to get correct information
> with SA_SIGINFO specified when this signal is delivered.
> 
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>  arch/arm64/include/asm/compat.h |    7 +++++++
>  arch/arm64/kernel/signal32.c    |    6 ++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/compat.h b/arch/arm64/include/asm/compat.h
> index 253e33b..c877915 100644
> --- a/arch/arm64/include/asm/compat.h
> +++ b/arch/arm64/include/asm/compat.h
> @@ -205,6 +205,13 @@ typedef struct compat_siginfo {
>  			compat_long_t _band;	/* POLL_IN, POLL_OUT, POLL_MSG */
>  			int _fd;
>  		} _sigpoll;
> +
> +		/* SIGSYS */
> +		struct {
> +			compat_uptr_t _call_addr; /* calling user insn */
> +			int _syscall;	/* triggering system call number */
> +			unsigned int _arch;	/* AUDIT_ARCH_* of syscall */

nit, but compat_uint_t looks better here (I have no idea why I didn't do
this for the signed int types, but hey).

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: "keescook@chromium.org" <keescook@chromium.org>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	"dsaxena@linaro.org" <dsaxena@linaro.org>,
	"arndb@arndb.de" <arndb@arndb.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 5/6] arm64: add SIGSYS siginfo for compat task
Date: Wed, 8 Oct 2014 15:30:59 +0100	[thread overview]
Message-ID: <20141008143059.GS26140@arm.com> (raw)
In-Reply-To: <1412243176-16192-6-git-send-email-takahiro.akashi@linaro.org>

On Thu, Oct 02, 2014 at 10:46:15AM +0100, AKASHI Takahiro wrote:
> SIGSYS is primarily used in secure computing to notify tracer.
> This patch allows signal handler on compat task to get correct information
> with SA_SIGINFO specified when this signal is delivered.
> 
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>  arch/arm64/include/asm/compat.h |    7 +++++++
>  arch/arm64/kernel/signal32.c    |    6 ++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/compat.h b/arch/arm64/include/asm/compat.h
> index 253e33b..c877915 100644
> --- a/arch/arm64/include/asm/compat.h
> +++ b/arch/arm64/include/asm/compat.h
> @@ -205,6 +205,13 @@ typedef struct compat_siginfo {
>  			compat_long_t _band;	/* POLL_IN, POLL_OUT, POLL_MSG */
>  			int _fd;
>  		} _sigpoll;
> +
> +		/* SIGSYS */
> +		struct {
> +			compat_uptr_t _call_addr; /* calling user insn */
> +			int _syscall;	/* triggering system call number */
> +			unsigned int _arch;	/* AUDIT_ARCH_* of syscall */

nit, but compat_uint_t looks better here (I have no idea why I didn't do
this for the signed int types, but hey).

Will

  reply	other threads:[~2014-10-08 14:30 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02  9:46 [PATCH v7 0/6] arm64: add seccomp support AKASHI Takahiro
2014-10-02  9:46 ` AKASHI Takahiro
2014-10-02  9:46 ` [PATCH v7 1/6] arm64: ptrace: add PTRACE_SET_SYSCALL AKASHI Takahiro
2014-10-02  9:46   ` AKASHI Takahiro
2014-10-08 14:13   ` Will Deacon
2014-10-08 14:13     ` Will Deacon
2014-10-08 15:30     ` Kees Cook
2014-10-08 15:30       ` Kees Cook
2014-10-09  1:55       ` AKASHI Takahiro
2014-10-09  1:55         ` AKASHI Takahiro
2014-10-09  9:23       ` Will Deacon
2014-10-09  9:23         ` Will Deacon
2014-11-06  2:40         ` AKASHI Takahiro
2014-11-06  2:40           ` AKASHI Takahiro
2014-11-06 18:17           ` Kees Cook
2014-11-06 18:17             ` Kees Cook
2014-10-02  9:46 ` [PATCH v7 2/6] arm64: ptrace: allow tracer to skip a system call AKASHI Takahiro
2014-10-02  9:46   ` AKASHI Takahiro
2014-10-08 14:23   ` Will Deacon
2014-10-08 14:23     ` Will Deacon
2014-10-09  4:29     ` AKASHI Takahiro
2014-10-09  4:29       ` AKASHI Takahiro
2014-10-10 11:05       ` Will Deacon
2014-10-10 11:05         ` Will Deacon
2014-10-02  9:46 ` [PATCH v7 3/6] asm-generic: add generic seccomp.h for secure computing mode 1 AKASHI Takahiro
2014-10-02  9:46   ` AKASHI Takahiro
2014-10-02  9:46 ` [PATCH v7 4/6] arm64: add seccomp syscall for compat task AKASHI Takahiro
2014-10-02  9:46   ` AKASHI Takahiro
2014-10-02  9:46 ` [PATCH v7 5/6] arm64: add SIGSYS siginfo " AKASHI Takahiro
2014-10-02  9:46   ` AKASHI Takahiro
2014-10-08 14:30   ` Will Deacon [this message]
2014-10-08 14:30     ` Will Deacon
2014-10-09  2:25     ` AKASHI Takahiro
2014-10-09  2:25       ` AKASHI Takahiro
2014-10-02  9:46 ` [PATCH v7 6/6] arm64: add seccomp support AKASHI Takahiro
2014-10-02  9:46   ` AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141008143059.GS26140@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.