All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Dmitry Osipenko <digetx@gmail.com>,
	swarren@wwwdotorg.org, josephl@nvidia.com,
	thierry.reding@gmail.com, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: tegra: Re-add removed SoC id macro to tegra_resume()
Date: Wed, 8 Oct 2014 14:04:32 -0500	[thread overview]
Message-ID: <20141008190432.GN22688@saruman> (raw)
In-Reply-To: <20141008190147.GM22688@saruman>

[-- Attachment #1: Type: text/plain, Size: 723 bytes --]

On Wed, Oct 08, 2014 at 02:01:47PM -0500, Felipe Balbi wrote:
> Hi,
> 
> On Wed, Oct 08, 2014 at 10:54:10PM +0400, Dmitry Osipenko wrote:
> > Commit d127e9c5c5bc1ee22a7b1fe804397cddd132f756 ("ARM: tegra: make tegra_resume
> > can work with current and later chips") removed tegra_get_soc_id macro leaving
> > used cpu register unassigned and as result causing execution of unintended code
> > on tegra20. Fix it by re-adding macro.
> 
> you should add:
> 
> Fixes: d127e9c (ARM: tegra: make tegra_resume can work with current and later chips)
> Cc: <stable@vger.kernel.org> # v3.13+
> 
> here. With that:
> 
> Reviewed-by: Felipe Balbi <balbi@ti.com>

oh, and you should probably Cc lakml.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Dmitry Osipenko <digetx@gmail.com>, <swarren@wwwdotorg.org>,
	<josephl@nvidia.com>, <thierry.reding@gmail.com>,
	<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: tegra: Re-add removed SoC id macro to tegra_resume()
Date: Wed, 8 Oct 2014 14:04:32 -0500	[thread overview]
Message-ID: <20141008190432.GN22688@saruman> (raw)
In-Reply-To: <20141008190147.GM22688@saruman>

[-- Attachment #1: Type: text/plain, Size: 723 bytes --]

On Wed, Oct 08, 2014 at 02:01:47PM -0500, Felipe Balbi wrote:
> Hi,
> 
> On Wed, Oct 08, 2014 at 10:54:10PM +0400, Dmitry Osipenko wrote:
> > Commit d127e9c5c5bc1ee22a7b1fe804397cddd132f756 ("ARM: tegra: make tegra_resume
> > can work with current and later chips") removed tegra_get_soc_id macro leaving
> > used cpu register unassigned and as result causing execution of unintended code
> > on tegra20. Fix it by re-adding macro.
> 
> you should add:
> 
> Fixes: d127e9c (ARM: tegra: make tegra_resume can work with current and later chips)
> Cc: <stable@vger.kernel.org> # v3.13+
> 
> here. With that:
> 
> Reviewed-by: Felipe Balbi <balbi@ti.com>

oh, and you should probably Cc lakml.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-10-08 19:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08 18:54 [PATCH] ARM: tegra: Re-add removed SoC id macro to tegra_resume() Dmitry Osipenko
2014-10-08 18:54 ` Dmitry Osipenko
     [not found] ` <1412794450-9060-1-git-send-email-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-08 19:01   ` Felipe Balbi
2014-10-08 19:01     ` Felipe Balbi
2014-10-08 19:04     ` Felipe Balbi [this message]
2014-10-08 19:04       ` Felipe Balbi
2014-10-08 19:24       ` [PATCH V2] " Dmitry Osipenko
2014-10-08 19:24         ` Dmitry Osipenko
2014-10-08 19:24         ` Dmitry Osipenko
     [not found]         ` <1412796255-10589-1-git-send-email-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-09 22:10           ` Dmitry Osipenko
2014-10-09 22:10             ` Dmitry Osipenko
2014-10-09 22:10             ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141008190432.GN22688@saruman \
    --to=balbi@ti.com \
    --cc=digetx@gmail.com \
    --cc=josephl@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.