From: Peter Zijlstra <peterz@infradead.org>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Andres Lagar-Cavilla <andreslc@google.com>,
Gleb Natapov <gleb@kernel.org>, Radim Krcmar <rkrcmar@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
Andy Lutomirski <luto@amacapital.net>,
Andrew Morton <akpm@linux-foundation.org>,
Sasha Levin <sasha.levin@oracle.com>,
Jianyu Zhan <nasa4836@gmail.com>,
Paul Cassella <cassella@cray.com>,
Hugh Dickins <hughd@google.com>,
Peter Feiner <pfeiner@google.com>,
"\\\"Dr. David Alan Gilbert\\\"" <dgilbert@redhat.com>
Subject: Re: [PATCH 2/4] mm: gup: add get_user_pages_locked and get_user_pages_unlocked
Date: Thu, 9 Oct 2014 12:47:23 +0200 [thread overview]
Message-ID: <20141009104723.GL4750@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <1412153797-6667-3-git-send-email-aarcange@redhat.com>
On Wed, Oct 01, 2014 at 10:56:35AM +0200, Andrea Arcangeli wrote:
> +static inline long __get_user_pages_locked(struct task_struct *tsk,
> + struct mm_struct *mm,
> + unsigned long start,
> + unsigned long nr_pages,
> + int write, int force,
> + struct page **pages,
> + struct vm_area_struct **vmas,
> + int *locked,
> + bool notify_drop)
You might want to consider __always_inline to make sure it does indeed
get inlined and constant propagation works for @locked and @notify_drop.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Andres Lagar-Cavilla <andreslc@google.com>,
Gleb Natapov <gleb@kernel.org>, Radim Krcmar <rkrcmar@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
Andy Lutomirski <luto@amacapital.net>,
Andrew Morton <akpm@linux-foundation.org>,
Sasha Levin <sasha.levin@oracle.com>,
Jianyu Zhan <nasa4836@gmail.com>,
Paul Cassella <cassella@cray.com>,
Hugh Dickins <hughd@google.com>,
Peter Feiner <pfeiner@google.com>,
"\\\"Dr. David Alan Gilbert\\\"" <dgilbert@redhat.com>
Subject: Re: [PATCH 2/4] mm: gup: add get_user_pages_locked and get_user_pages_unlocked
Date: Thu, 9 Oct 2014 12:47:23 +0200 [thread overview]
Message-ID: <20141009104723.GL4750@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <1412153797-6667-3-git-send-email-aarcange@redhat.com>
On Wed, Oct 01, 2014 at 10:56:35AM +0200, Andrea Arcangeli wrote:
> +static inline long __get_user_pages_locked(struct task_struct *tsk,
> + struct mm_struct *mm,
> + unsigned long start,
> + unsigned long nr_pages,
> + int write, int force,
> + struct page **pages,
> + struct vm_area_struct **vmas,
> + int *locked,
> + bool notify_drop)
You might want to consider __always_inline to make sure it does indeed
get inlined and constant propagation works for @locked and @notify_drop.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-10-09 10:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 8:56 [PATCH 0/4] leverage FAULT_FOLL_ALLOW_RETRY in get_user_pages Andrea Arcangeli
2014-10-01 8:56 ` Andrea Arcangeli
2014-10-01 8:56 ` [PATCH 1/4] mm: gup: add FOLL_TRIED Andrea Arcangeli
2014-10-01 8:56 ` Andrea Arcangeli
2014-10-01 8:56 ` Andrea Arcangeli
2014-10-09 10:35 ` Peter Zijlstra
2014-10-09 10:35 ` Peter Zijlstra
2014-10-09 10:35 ` Peter Zijlstra
2014-10-01 8:56 ` [PATCH 2/4] mm: gup: add get_user_pages_locked and get_user_pages_unlocked Andrea Arcangeli
2014-10-01 8:56 ` Andrea Arcangeli
2014-10-01 15:51 ` Peter Feiner
2014-10-01 15:51 ` Peter Feiner
2014-10-01 17:06 ` Andres Lagar-Cavilla
2014-10-01 17:06 ` Andres Lagar-Cavilla
2014-10-02 12:40 ` Andrea Arcangeli
2014-10-02 12:40 ` Andrea Arcangeli
2014-10-09 10:47 ` Peter Zijlstra [this message]
2014-10-09 10:47 ` Peter Zijlstra
2014-10-29 16:41 ` Andrea Arcangeli
2014-10-29 16:41 ` Andrea Arcangeli
2014-10-09 10:50 ` Peter Zijlstra
2014-10-09 10:50 ` Peter Zijlstra
2014-10-29 16:39 ` Andrea Arcangeli
2014-10-29 16:39 ` Andrea Arcangeli
2014-10-01 8:56 ` [PATCH 3/4] mm: gup: use get_user_pages_fast " Andrea Arcangeli
2014-10-01 8:56 ` Andrea Arcangeli
2014-10-01 9:10 ` Andrea Arcangeli
2014-10-01 9:10 ` Andrea Arcangeli
2014-10-01 16:54 ` Sasha Levin
2014-10-01 16:54 ` Sasha Levin
2014-10-09 10:52 ` Peter Zijlstra
2014-10-09 10:52 ` Peter Zijlstra
2014-10-12 13:24 ` Andrea Arcangeli
2014-10-12 13:24 ` Andrea Arcangeli
2014-10-01 8:56 ` [PATCH 4/4] mm: gup: use get_user_pages_unlocked within get_user_pages_fast Andrea Arcangeli
2014-10-01 8:56 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009104723.GL4750@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andreslc@google.com \
--cc=cassella@cray.com \
--cc=dgilbert@redhat.com \
--cc=gleb@kernel.org \
--cc=hughd@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=mgorman@suse.de \
--cc=nasa4836@gmail.com \
--cc=pbonzini@redhat.com \
--cc=pfeiner@google.com \
--cc=riel@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.