From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1] Arm64: ASLR: fix text randomization
Date: Thu, 9 Oct 2014 15:44:41 +0100 [thread overview]
Message-ID: <20141009144441.GA18384@leverpostej> (raw)
In-Reply-To: <20141008112154.GF26140@arm.com>
On Wed, Oct 08, 2014 at 12:21:55PM +0100, Will Deacon wrote:
> On Wed, Oct 08, 2014 at 07:51:54AM +0100, Arun Chandran wrote:
> > On Tue, Oct 7, 2014 at 7:13 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> > > I wasn't able to spot where the randomness came from in the
> > > ARCH_BINFMT_ELF_RANDOMIZE_PIE case, so it's not clear to me if the
> > > generic implementation behaves identically other than disabling
> > > randomization when told to via proc.
> >
> > I also don't know from where it is coming; but it works on arm and x86 :)
>
> The randomness will come from elf_map, since that will descend into the mmap
> code and end up with a randomised base address (see mmap_base and
> arch_pick_mmap_layout).
Given that, it sounds like the existing randomize_et_dyn is redundant?
If so, the patch looks sane to me.
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Will Deacon <Will.Deacon@arm.com>
Cc: Arun Chandran <achandran@mvista.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Anton Blanchard <anton@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [PATCH v1] Arm64: ASLR: fix text randomization
Date: Thu, 9 Oct 2014 15:44:41 +0100 [thread overview]
Message-ID: <20141009144441.GA18384@leverpostej> (raw)
In-Reply-To: <20141008112154.GF26140@arm.com>
On Wed, Oct 08, 2014 at 12:21:55PM +0100, Will Deacon wrote:
> On Wed, Oct 08, 2014 at 07:51:54AM +0100, Arun Chandran wrote:
> > On Tue, Oct 7, 2014 at 7:13 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> > > I wasn't able to spot where the randomness came from in the
> > > ARCH_BINFMT_ELF_RANDOMIZE_PIE case, so it's not clear to me if the
> > > generic implementation behaves identically other than disabling
> > > randomization when told to via proc.
> >
> > I also don't know from where it is coming; but it works on arm and x86 :)
>
> The randomness will come from elf_map, since that will descend into the mmap
> code and end up with a randomised base address (see mmap_base and
> arch_pick_mmap_layout).
Given that, it sounds like the existing randomize_et_dyn is redundant?
If so, the patch looks sane to me.
Mark.
next prev parent reply other threads:[~2014-10-09 14:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 12:40 [PATCH v1] Arm64: ASLR: fix text randomization Arun Chandran
2014-10-07 12:40 ` Arun Chandran
2014-10-07 13:43 ` Mark Rutland
2014-10-07 13:43 ` Mark Rutland
2014-10-08 6:51 ` Arun Chandran
2014-10-08 6:51 ` Arun Chandran
2014-10-08 11:21 ` Will Deacon
2014-10-08 11:21 ` Will Deacon
2014-10-09 14:44 ` Mark Rutland [this message]
2014-10-09 14:44 ` Mark Rutland
2014-10-10 11:31 ` [PATCH v2] Arm64: ASLR: Don't randomise text when randomise_va_space == 0 Arun Chandran
2014-10-10 11:31 ` Arun Chandran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009144441.GA18384@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.