From: Sitsofe Wheeler <sitsofe@gmail.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: linux-scsi@vger.kernel.org,
Haiyang Zhang <haiyangz@microsoft.com>,
linux-kernel@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Hannes Reinecke <hare@suse.de>,
devel@linuxdriverproject.org, Christoph Hellwig <hch@lst.de>
Subject: [PATCH 1/3] Revert "Drivers: add blist flags"
Date: Fri, 10 Oct 2014 08:51:10 +0100 [thread overview]
Message-ID: <20141010075110.GB32028@sucs.org> (raw)
In-Reply-To: <20141010074901.GA32028@sucs.org>
This reverts commit f3cfabce7a2e92564d380de3aad4b43901fb7ae6 (Drivers:
add blist flags) as it does not enable thin provisioning for my Hyper-V 2012 R2
virtual disks.
Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
---
drivers/scsi/storvsc_drv.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 733e5f7..2cc094e 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -327,8 +327,6 @@ MODULE_PARM_DESC(storvsc_ringbuffer_size, "Ring buffer size (bytes)");
*/
static int storvsc_timeout = 180;
-static int msft_blist_flags = BLIST_TRY_VPD_PAGES;
-
#define STORVSC_MAX_IO_REQUESTS 200
static void storvsc_on_channel_callback(void *context);
@@ -1439,14 +1437,6 @@ static int storvsc_device_configure(struct scsi_device *sdevice)
sdevice->no_write_same = 1;
- /*
- * Add blist flags to permit the reading of the VPD pages even when
- * the target may claim SPC-2 compliance. MSFT targets currently
- * claim SPC-2 compliance while they implement post SPC-2 features.
- * With this patch we can correctly handle WRITE_SAME_16 issues.
- */
- sdevice->sdev_bflags |= msft_blist_flags;
-
return 0;
}
--
1.9.3
WARNING: multiple messages have this Message-ID (diff)
From: Sitsofe Wheeler <sitsofe@gmail.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org,
"James E.J. Bottomley" <JBottomley@parallels.com>
Subject: [PATCH 1/3] Revert "Drivers: add blist flags"
Date: Fri, 10 Oct 2014 08:51:10 +0100 [thread overview]
Message-ID: <20141010075110.GB32028@sucs.org> (raw)
In-Reply-To: <20141010074901.GA32028@sucs.org>
This reverts commit f3cfabce7a2e92564d380de3aad4b43901fb7ae6 (Drivers:
add blist flags) as it does not enable thin provisioning for my Hyper-V 2012 R2
virtual disks.
Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
---
drivers/scsi/storvsc_drv.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 733e5f7..2cc094e 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -327,8 +327,6 @@ MODULE_PARM_DESC(storvsc_ringbuffer_size, "Ring buffer size (bytes)");
*/
static int storvsc_timeout = 180;
-static int msft_blist_flags = BLIST_TRY_VPD_PAGES;
-
#define STORVSC_MAX_IO_REQUESTS 200
static void storvsc_on_channel_callback(void *context);
@@ -1439,14 +1437,6 @@ static int storvsc_device_configure(struct scsi_device *sdevice)
sdevice->no_write_same = 1;
- /*
- * Add blist flags to permit the reading of the VPD pages even when
- * the target may claim SPC-2 compliance. MSFT targets currently
- * claim SPC-2 compliance while they implement post SPC-2 features.
- * With this patch we can correctly handle WRITE_SAME_16 issues.
- */
- sdevice->sdev_bflags |= msft_blist_flags;
-
return 0;
}
--
1.9.3
next prev parent reply other threads:[~2014-10-10 7:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 7:49 [PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks Sitsofe Wheeler
2014-10-10 7:49 ` Sitsofe Wheeler
2014-10-10 7:51 ` Sitsofe Wheeler [this message]
2014-10-10 7:51 ` [PATCH 1/3] Revert "Drivers: add blist flags" Sitsofe Wheeler
2014-10-10 7:52 ` [PATCH 2/3] scsi: add try_rc16 blacklist flag Sitsofe Wheeler
2014-10-10 7:52 ` Sitsofe Wheeler
2014-10-15 1:08 ` Martin K. Petersen
2014-10-15 1:08 ` Martin K. Petersen
2014-10-15 2:07 ` KY Srinivasan
2014-10-21 4:21 ` Sitsofe Wheeler
2014-10-21 4:21 ` Sitsofe Wheeler
2014-10-23 1:46 ` Martin K. Petersen
2014-10-23 1:46 ` Martin K. Petersen
2014-10-10 7:55 ` [PATCH 3/3] scsi: Use try_rc16 and try_vpd_pages quirks on Hyper-V virtual disks Sitsofe Wheeler
2014-10-10 7:55 ` Sitsofe Wheeler
2014-10-11 17:39 ` [PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks Christoph Hellwig
2014-10-11 17:41 ` James Bottomley
2014-10-11 17:41 ` James Bottomley
2014-10-11 19:48 ` KY Srinivasan
2014-10-11 19:48 ` KY Srinivasan
2014-10-11 20:22 ` Jeff Leung
2014-10-11 20:22 ` Jeff Leung
2014-10-12 1:21 ` KY Srinivasan
2014-10-12 1:21 ` KY Srinivasan
2014-10-21 4:45 ` Sitsofe Wheeler
2014-10-21 4:45 ` Sitsofe Wheeler
2014-10-21 5:19 ` Jeff Leung
2014-10-21 5:19 ` Jeff Leung
2014-10-21 18:30 ` KY Srinivasan
2014-10-21 18:30 ` KY Srinivasan
2014-10-15 1:06 ` Martin K. Petersen
2014-10-15 1:06 ` Martin K. Petersen
2014-10-21 4:17 ` Sitsofe Wheeler
2014-10-21 4:17 ` Sitsofe Wheeler
2014-10-23 1:50 ` Martin K. Petersen
2014-10-23 1:50 ` Martin K. Petersen
2014-10-23 9:03 ` Sitsofe Wheeler
2014-10-23 9:03 ` Sitsofe Wheeler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141010075110.GB32028@sucs.org \
--to=sitsofe@gmail.com \
--cc=JBottomley@parallels.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.