All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Chen <peter.chen@freescale.com>
To: Nathan Lynch <Nathan_Lynch@mentor.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Felipe Balbi <balbi@ti.com>, Rik van Riel <riel@redhat.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Tony Lindgren <tony@atomide.com>,
	Linux USB Mailing List <linux-usb@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	josh@joshtriplett.org, Rabin Vincent <rabin@rab.in>,
	Alan Stern <stern@rowland.harvard.edu>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Sasha Levin <sasha.levin@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux ARM Kernel Mailing List
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: RCU bug with v3.17-rc3 ?
Date: Sat, 11 Oct 2014 11:54:32 +0800	[thread overview]
Message-ID: <20141011035431.GK3756@peterchendt> (raw)
In-Reply-To: <54388B81.5020306@mentor.com>

On Fri, Oct 10, 2014 at 08:44:33PM -0500, Nathan Lynch wrote:
> On 10/10/2014 11:25 AM, Russell King - ARM Linux wrote:
> > 
> > Right, so GCC 4.8.{1,2} are totally unsuitable for kernel building (and
> > it seems that this has been known about for some time.)
> 
> Looking at http://gcc.gnu.org/PR58854 it seems that all 4.8.x for x < 3
> are affected, as well as 4.9.0.
> 
> > We can blacklist these GCC versions quite easily.  We already have GCC
> > 3.3 blacklisted, and it's trivial to add others.  I would want to include
> > some proper details about the bug, just like the other existing entries
> > we already have in asm-offsets.c, where we name the functions that the
> > compiler is known to break where appropriate.
> 
> Before blacklisting anything, it's worth considering that simple version
> checks would break existing pre-4.8.3 compilers that have been patched
> for PR58854.  It looks like Yocto and Buildroot issued releases with
> patched 4.8.2 compilers well before the (fixed) 4.8.3 release.  I think
> the most we can reasonably do without breaking some correctly-behaving
> toolchains is to emit a warning.

Yocto has PR58854 problem patch.

http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-devtools/gcc/gcc-4.8/0048-PR58854_fix_arm_apcs_epilogue.patch?h=daisy

> 
> Hopefully nobody's still using gcc 4.8 from the Linaro 2013.11 toolchain
> release -- since it's a 4.8.3 prerelease from before the fix was
> committed you'll get GCC_VERSION == 40803 but still generate bad code.
> 
> > However, I'm rather annoyed that there are people here who have known
> > for some time that GCC 4.8.1 and GCC 4.8.2 _can_ lead to filesystem
> > corruption, and have sat on their backsides doing nothing about getting
> > it blacklisted for something like a year.
> 
> Mea culpa, although I hadn't drawn the connection to FS corruption
> reports until now.  I have known about the issue for some time, but
> figured the prevalence of the fix in downstream projects largely
> mitigated the issue.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Best Regards,
Peter Chen

WARNING: multiple messages have this Message-ID (diff)
From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: RCU bug with v3.17-rc3 ?
Date: Sat, 11 Oct 2014 11:54:32 +0800	[thread overview]
Message-ID: <20141011035431.GK3756@peterchendt> (raw)
In-Reply-To: <54388B81.5020306@mentor.com>

On Fri, Oct 10, 2014 at 08:44:33PM -0500, Nathan Lynch wrote:
> On 10/10/2014 11:25 AM, Russell King - ARM Linux wrote:
> > 
> > Right, so GCC 4.8.{1,2} are totally unsuitable for kernel building (and
> > it seems that this has been known about for some time.)
> 
> Looking at http://gcc.gnu.org/PR58854 it seems that all 4.8.x for x < 3
> are affected, as well as 4.9.0.
> 
> > We can blacklist these GCC versions quite easily.  We already have GCC
> > 3.3 blacklisted, and it's trivial to add others.  I would want to include
> > some proper details about the bug, just like the other existing entries
> > we already have in asm-offsets.c, where we name the functions that the
> > compiler is known to break where appropriate.
> 
> Before blacklisting anything, it's worth considering that simple version
> checks would break existing pre-4.8.3 compilers that have been patched
> for PR58854.  It looks like Yocto and Buildroot issued releases with
> patched 4.8.2 compilers well before the (fixed) 4.8.3 release.  I think
> the most we can reasonably do without breaking some correctly-behaving
> toolchains is to emit a warning.

Yocto has PR58854 problem patch.

http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-devtools/gcc/gcc-4.8/0048-PR58854_fix_arm_apcs_epilogue.patch?h=daisy

> 
> Hopefully nobody's still using gcc 4.8 from the Linaro 2013.11 toolchain
> release -- since it's a 4.8.3 prerelease from before the fix was
> committed you'll get GCC_VERSION == 40803 but still generate bad code.
> 
> > However, I'm rather annoyed that there are people here who have known
> > for some time that GCC 4.8.1 and GCC 4.8.2 _can_ lead to filesystem
> > corruption, and have sat on their backsides doing nothing about getting
> > it blacklisted for something like a year.
> 
> Mea culpa, although I hadn't drawn the connection to FS corruption
> reports until now.  I have known about the issue for some time, but
> figured the prevalence of the fix in downstream projects largely
> mitigated the issue.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Best Regards,
Peter Chen

WARNING: multiple messages have this Message-ID (diff)
From: Peter Chen <peter.chen@freescale.com>
To: Nathan Lynch <Nathan_Lynch@mentor.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Felipe Balbi <balbi@ti.com>, Rik van Riel <riel@redhat.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Tony Lindgren <tony@atomide.com>,
	"Linux USB Mailing List" <linux-usb@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	<josh@joshtriplett.org>, Rabin Vincent <rabin@rab.in>,
	Alan Stern <stern@rowland.harvard.edu>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Sasha Levin <sasha.levin@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux ARM Kernel Mailing List 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: RCU bug with v3.17-rc3 ?
Date: Sat, 11 Oct 2014 11:54:32 +0800	[thread overview]
Message-ID: <20141011035431.GK3756@peterchendt> (raw)
In-Reply-To: <54388B81.5020306@mentor.com>

On Fri, Oct 10, 2014 at 08:44:33PM -0500, Nathan Lynch wrote:
> On 10/10/2014 11:25 AM, Russell King - ARM Linux wrote:
> > 
> > Right, so GCC 4.8.{1,2} are totally unsuitable for kernel building (and
> > it seems that this has been known about for some time.)
> 
> Looking at http://gcc.gnu.org/PR58854 it seems that all 4.8.x for x < 3
> are affected, as well as 4.9.0.
> 
> > We can blacklist these GCC versions quite easily.  We already have GCC
> > 3.3 blacklisted, and it's trivial to add others.  I would want to include
> > some proper details about the bug, just like the other existing entries
> > we already have in asm-offsets.c, where we name the functions that the
> > compiler is known to break where appropriate.
> 
> Before blacklisting anything, it's worth considering that simple version
> checks would break existing pre-4.8.3 compilers that have been patched
> for PR58854.  It looks like Yocto and Buildroot issued releases with
> patched 4.8.2 compilers well before the (fixed) 4.8.3 release.  I think
> the most we can reasonably do without breaking some correctly-behaving
> toolchains is to emit a warning.

Yocto has PR58854 problem patch.

http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-devtools/gcc/gcc-4.8/0048-PR58854_fix_arm_apcs_epilogue.patch?h=daisy

> 
> Hopefully nobody's still using gcc 4.8 from the Linaro 2013.11 toolchain
> release -- since it's a 4.8.3 prerelease from before the fix was
> committed you'll get GCC_VERSION == 40803 but still generate bad code.
> 
> > However, I'm rather annoyed that there are people here who have known
> > for some time that GCC 4.8.1 and GCC 4.8.2 _can_ lead to filesystem
> > corruption, and have sat on their backsides doing nothing about getting
> > it blacklisted for something like a year.
> 
> Mea culpa, although I hadn't drawn the connection to FS corruption
> reports until now.  I have known about the issue for some time, but
> figured the prevalence of the fix in downstream projects largely
> mitigated the issue.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Best Regards,
Peter Chen

  parent reply	other threads:[~2014-10-11  3:54 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04 18:40 RCU bug with v3.17-rc3 ? Felipe Balbi
2014-09-04 19:16 ` Paul E. McKenney
2014-09-04 19:25   ` Felipe Balbi
2014-09-04 20:04     ` Felipe Balbi
2014-09-05 21:32       ` Paul E. McKenney
2014-10-08 17:13         ` Felipe Balbi
2014-10-08 17:13           ` Felipe Balbi
2014-10-08 17:13           ` Felipe Balbi
2014-10-08 17:57           ` Felipe Balbi
2014-10-08 17:57             ` Felipe Balbi
2014-10-08 17:57             ` Felipe Balbi
2014-10-08 21:29             ` Felipe Balbi
2014-10-08 21:29               ` Felipe Balbi
2014-10-08 21:29               ` Felipe Balbi
2014-10-09 16:01               ` Johannes Weiner
2014-10-09 16:01                 ` Johannes Weiner
     [not found]                 ` <20141009160138.GA2396-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2014-10-09 16:26                   ` Felipe Balbi
2014-10-09 16:26                     ` Felipe Balbi
2014-10-09 16:26                     ` Felipe Balbi
2014-10-09 20:35                     ` Felipe Balbi
2014-10-09 20:35                       ` Felipe Balbi
2014-10-09 20:35                       ` Felipe Balbi
2014-10-09 20:41                     ` Rabin Vincent
2014-10-09 20:41                       ` Rabin Vincent
2014-10-09 20:46                       ` Felipe Balbi
2014-10-09 20:46                         ` Felipe Balbi
2014-10-09 20:46                         ` Felipe Balbi
2014-10-09 21:07                         ` Felipe Balbi
2014-10-09 21:07                           ` Felipe Balbi
2014-10-09 21:07                           ` Felipe Balbi
2014-10-10 13:57                           ` Felipe Balbi
2014-10-10 13:57                             ` Felipe Balbi
2014-10-10 13:57                             ` Felipe Balbi
2014-10-10 16:25                             ` Russell King - ARM Linux
2014-10-10 16:25                               ` Russell King - ARM Linux
     [not found]                               ` <20141010162531.GL12379-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2014-10-11  1:44                                 ` Nathan Lynch
2014-10-11  1:44                                   ` Nathan Lynch
2014-10-11  1:44                                   ` Nathan Lynch
2014-10-11  2:40                                   ` Peter Hurley
2014-10-11  2:40                                     ` Peter Hurley
2014-10-11  3:54                                   ` Peter Chen [this message]
2014-10-11  3:54                                     ` Peter Chen
2014-10-11  3:54                                     ` Peter Chen
2014-10-11 14:16                                     ` Russell King - ARM Linux
2014-10-11 14:16                                       ` Russell King - ARM Linux
2014-10-11 14:16                                       ` Russell King - ARM Linux
2014-10-11 14:51                                       ` Otavio Salvador
2014-10-11 14:51                                         ` Otavio Salvador
2014-10-11 18:15                                         ` Peter Hurley
2014-10-11 18:15                                           ` Peter Hurley
     [not found]                                   ` <54388B81.5020306-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2014-10-11 14:14                                     ` Russell King - ARM Linux
2014-10-11 14:14                                       ` Russell King - ARM Linux
2014-10-11 14:14                                       ` Russell King - ARM Linux
2014-10-11 19:27                                   ` Nathan Lynch
2014-10-11 19:27                                     ` Nathan Lynch
2014-10-11 19:27                                     ` Nathan Lynch
2014-10-13  9:11                                   ` David Laight
2014-10-13  9:11                                     ` David Laight
2014-10-13 11:43                                     ` Russell King - ARM Linux
2014-10-13 11:43                                       ` Russell King - ARM Linux
2014-10-14  2:06                                       ` Greg KH
2014-10-14  2:06                                         ` Greg KH
2014-10-14 10:27                                         ` Peter Hurley
2014-10-14 10:27                                           ` Peter Hurley
     [not found]                                         ` <20141014020640.GB25433-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2014-10-15 21:23                                           ` Russell King - ARM Linux
2014-10-15 21:23                                             ` Russell King - ARM Linux
2014-10-15 21:23                                             ` Russell King - ARM Linux
     [not found]                                             ` <20141015212310.GP12379-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2014-10-15 21:25                                               ` Russell King - ARM Linux
2014-10-15 21:25                                                 ` Russell King - ARM Linux
2014-10-15 21:25                                                 ` Russell King - ARM Linux
2014-10-19  9:54                                                 ` Russell King - ARM Linux
2014-10-19  9:54                                                   ` Russell King - ARM Linux
2014-10-19 15:28                                                   ` Felipe Balbi
2014-10-19 15:28                                                     ` Felipe Balbi
2014-10-19 20:48                                                     ` Olof Johansson
2014-10-19 20:48                                                       ` Olof Johansson
2014-10-19 20:48                                                       ` Olof Johansson
2014-10-09 21:47                       ` Aaro Koskinen
2014-10-09 21:47                         ` Aaro Koskinen
2014-10-10 16:18                         ` Russell King - ARM Linux
2014-10-10 16:18                           ` Russell King - ARM Linux
2014-10-10 20:52                           ` Aaro Koskinen
2014-10-10 20:52                             ` Aaro Koskinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141011035431.GK3756@peterchendt \
    --to=peter.chen@freescale.com \
    --cc=Nathan_Lynch@mentor.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbi@ti.com \
    --cc=hannes@cmpxchg.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rabin@rab.in \
    --cc=riel@redhat.com \
    --cc=sasha.levin@oracle.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tony@atomide.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.