Re: [PATCH v3] Separate runtime debug output from debug symbols

[Olaf Hering <olaf@aepfle.de>]

On Wed, Oct 08, Ian Jackson wrote:

> Olaf Hering writes ("Re: [PATCH v3] Separate runtime debug output from debug symbols"):
> > On Wed, Oct 08, Ian Jackson wrote:
> > > I do object to a change to the default, which AFAICT is what happens
> > > in your patch.
> > 
> > How does it change the default? Confik.mk has:
> 
> Sorry, I wasn't clear.  I mean that -g should remain the default even
> in debug=n builds of Xen.
> 
> >  19 # A debug build of Xen and tools?
> >  20 debug ?= y
> >  21 debug_symbols ?= $(debug)
> > 
> > Which means its always on.
> 
> If debug=n, -g is turned off.  The user might do that.  Also we
> routinely set debug=n during the last stages of the release process.

So how do we proceed here?

v3 of the patch is fine. It removes the hardcoded -g from more places.
The result is more free diskspace if one requests to compile the source
without -g. The default remains the same. 
If one does configure --disable-debug he may have a reason to do so.
Still "make debug_symbols=y" will build the whole thing with -g.

What the default for both knobs should be and how the default is
supposed to be set is a separate discussion not belonging to this.


Olaf