All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] spidev_test: new package
Date: Tue, 14 Oct 2014 22:54:11 +0300	[thread overview]
Message-ID: <20141014195411.GI3500@tarshish> (raw)
In-Reply-To: <1413301553-1592-1-git-send-email-gustavo@zacarias.com.ar>

Hi Gustavo,

On Tue, Oct 14, 2014 at 12:45:53PM -0300, Gustavo Zacarias wrote:
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

[snip]

> diff --git a/package/spidev_test/Config.in b/package/spidev_test/Config.in
> new file mode 100644
> index 0000000..c0ed9ef
> --- /dev/null
> +++ b/package/spidev_test/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_SPIDEV_TEST
> +	bool "spidev_test"
> +	depends on BR2_LINUX_KERNEL

That is a heavy dependency. As you noted in another message, it also make the 
autobuilder skip this package. I suggest to download just spidev_test.c from 
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/plain/Documentation/spi/spidev_test.c?id=$(SPIDEV_TEST_VERSION), 
and make it depend on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15 (as of v3.17). This 
solves both the autobuilder issue, and the toolchain headers dependency.

baruch

> +	help
> +	  SPI testing utility (using spidev driver).
> +
> +	  This package builds and installs the userspace 'spidev_test'
> +	  command. It is up to the user to ensure that the kernel
> +	  configuration has all the suitable options enabled to allow a
> +	  proper operation of 'spidev_test'.
> +
> +	  https://www.kernel.org/doc/Documentation/spi/spidev_test.c
> +
> +comment "spidev_test needs Linux kernel to be built"
> +	depends on !BR2_LINUX_KERNEL
> diff --git a/package/spidev_test/spidev_test.mk b/package/spidev_test/spidev_test.mk
> new file mode 100644
> index 0000000..24c0f89
> --- /dev/null
> +++ b/package/spidev_test/spidev_test.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# spidev_test
> +#
> +################################################################################
> +
> +# Source taken from the Linux kernel tree
> +SPIDEV_TEST_SOURCE =
> +SPIDEV_TEST_VERSION = $(call qstrip,$(BR2_LINUX_KERNEL_VERSION))
> +SPIDEV_TEST_DEPENDENCIES = linux
> +
> +define SPIDEV_TEST_BUILD_CMDS
> +	$(TARGET_MAKE_ENV) $(TARGET_CC) $(TARGET_CFLAGS) -o $(@D)/spidev_test \
> +		$(LINUX_DIR)/Documentation/spi/spidev_test.c
> +endef
> +
> +define SPIDEV_TEST_INSTALL_TARGET_CMDS
> +	$(INSTALL) -D -m 755 $(@D)/spidev_test \
> +		$(TARGET_DIR)/usr/sbin/spidev_test
> +endef
> +
> +$(eval $(generic-package))

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  parent reply	other threads:[~2014-10-14 19:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-14 15:45 [Buildroot] [PATCH] spidev_test: new package Gustavo Zacarias
2014-10-14 17:29 ` Thomas De Schampheleire
2014-10-14 17:34   ` Gustavo Zacarias
2014-10-14 17:57 ` Ryan Barnett
2014-10-14 19:54 ` Baruch Siach [this message]
2014-10-14 19:56   ` Gustavo Zacarias
2014-10-14 20:09     ` Baruch Siach
2014-10-14 20:14   ` Thomas De Schampheleire
2014-10-14 20:18     ` Gustavo Zacarias
2014-10-14 20:19     ` Baruch Siach
2014-10-17 21:55   ` Yann E. MORIN
2014-10-18 20:08     ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141014195411.GI3500@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.