From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] spidev_test: new package
Date: Tue, 14 Oct 2014 17:18:58 -0300 [thread overview]
Message-ID: <543D8532.7070602@zacarias.com.ar> (raw)
In-Reply-To: <d5114688-5ab5-4233-9038-8177f0f29d2e@email.android.com>
On 10/14/2014 05:14 PM, Thomas De Schampheleire wrote:
>> That is a heavy dependency. As you noted in another message, it also make the
>> autobuilder skip this package. I suggest to download just spidev_test.c from
>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/plain/Documentation/spi/spidev_test.c?id=$(SPIDEV_TEST_VERSION),
>> and make it depend on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15 (as of v3.17). This
>> solves both the autobuilder issue, and the toolchain headers dependency.
>
> From where comes this dependency on 3.15/3.17?
>
> The test program was in the kernel for a very long time (2.6.x)...
>
> Also, what is the autobuilder issue you are talking about?
SPI_RX_QUAD/SPI_TX_QUAD (quad-pumped spi).
The autobuilder issue is that older kernel headers won't have this
defined (example: external toolchains with newish kernel).
What Baruch proposes is probably the best solution, otherwise a ton of
#ifdefs is option 2 which would probably wouldn't be acceptable upstream.
Regards.
next prev parent reply other threads:[~2014-10-14 20:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 15:45 [Buildroot] [PATCH] spidev_test: new package Gustavo Zacarias
2014-10-14 17:29 ` Thomas De Schampheleire
2014-10-14 17:34 ` Gustavo Zacarias
2014-10-14 17:57 ` Ryan Barnett
2014-10-14 19:54 ` Baruch Siach
2014-10-14 19:56 ` Gustavo Zacarias
2014-10-14 20:09 ` Baruch Siach
2014-10-14 20:14 ` Thomas De Schampheleire
2014-10-14 20:18 ` Gustavo Zacarias [this message]
2014-10-14 20:19 ` Baruch Siach
2014-10-17 21:55 ` Yann E. MORIN
2014-10-18 20:08 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543D8532.7070602@zacarias.com.ar \
--to=gustavo@zacarias.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.