All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings
Date: Wed, 15 Oct 2014 15:59:34 +0300	[thread overview]
Message-ID: <20141015125934.GB23154@mwanda> (raw)
In-Reply-To: <20141015123431.GA23154@mwanda>

Or we could fix it but add a multi-line comment with lots of capital
letters and exclamation marks.  I guess we would need to make a function
since this cast is in several places.

void *silence_buggy_casting(u32 pointer)
{
	/*
	 * DANGER! DANGER! DANGER! DANGER! DANGER! DANGER! DANGER!
	 * FIXME!!!  We know this cast is totally buggy.  The BCM driver
	 * doesn't work on 64 bits.  But no one knows how to make this
	 * work.  Oh well.  Let's silence the GCC warning.
	 * DANGER! DANGER! DANGER! DANGER! DANGER! DANGER! DANGER!
	 *
	 */
	return (void *)(long)pointer;
}

Something really ugly and gnarly like that would be hard to ignore.

regards,
dan carpenter


  reply	other threads:[~2014-10-15 12:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-15 12:26 [PATCH] bcm/CmHost.c: Fix noisy compile warnings Jeff Kirsher
2014-10-15 12:33 ` Joe Perches
2014-10-15 12:34 ` Dan Carpenter
2014-10-15 12:59   ` Dan Carpenter [this message]
2014-10-15 13:03     ` Jeff Kirsher
2014-10-15 16:11       ` Joe Perches
2014-10-15 17:42         ` Jeff Kirsher
2014-10-15 18:24           ` Fabio Estevam
2014-10-15 18:54             ` Jeff Kirsher
2014-10-15 18:56               ` Joe Perches
2014-10-15 18:56               ` Fabio Estevam
2014-10-15 19:53         ` Dan Carpenter
2014-10-15 20:03           ` Joe Perches
2014-10-16  7:48             ` Dan Carpenter
2014-10-16  7:54               ` Jeff Kirsher
2014-10-15 21:41       ` Matthias Beyer
2014-10-15 22:19         ` Jeff Kirsher
2014-10-15 22:24           ` Matthias Beyer
2014-10-15 22:41             ` Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141015125934.GB23154@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.