From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings
Date: Wed, 15 Oct 2014 22:53:45 +0300 [thread overview]
Message-ID: <20141015195345.GQ26918@mwanda> (raw)
In-Reply-To: <1413389496.7484.3.camel@perches.com>
On Wed, Oct 15, 2014 at 09:11:36AM -0700, Joe Perches wrote:
> On Wed, 2014-10-15 at 06:03 -0700, Jeff Kirsher wrote:
> []
> > I thought I remember Greg saying something about getting rid of this
> > driver anyway, but I could be wrong. If Greg decides to keep this
> > driver around, then I think we should something like your suggestion
> > above.
>
> Or maybe just make the Kconfig depend on X86_32
What I like about your patches is that they are pure theoretical work
and I don't have to think about them like regular proper patches with a
signed off by etc. All the fun, none of the responsibility.
> config BCM_WIMAX
> tristate "Beceem BCS200/BCS220-3 and BCSM250 wimax support"
> - depends on USB && NET
> + depends on USB && NET && X86_32
And also COMPILE_TEST.
regards,
dan carpenter
next prev parent reply other threads:[~2014-10-15 19:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 12:26 [PATCH] bcm/CmHost.c: Fix noisy compile warnings Jeff Kirsher
2014-10-15 12:33 ` Joe Perches
2014-10-15 12:34 ` Dan Carpenter
2014-10-15 12:59 ` Dan Carpenter
2014-10-15 13:03 ` Jeff Kirsher
2014-10-15 16:11 ` Joe Perches
2014-10-15 17:42 ` Jeff Kirsher
2014-10-15 18:24 ` Fabio Estevam
2014-10-15 18:54 ` Jeff Kirsher
2014-10-15 18:56 ` Joe Perches
2014-10-15 18:56 ` Fabio Estevam
2014-10-15 19:53 ` Dan Carpenter [this message]
2014-10-15 20:03 ` Joe Perches
2014-10-16 7:48 ` Dan Carpenter
2014-10-16 7:54 ` Jeff Kirsher
2014-10-15 21:41 ` Matthias Beyer
2014-10-15 22:19 ` Jeff Kirsher
2014-10-15 22:24 ` Matthias Beyer
2014-10-15 22:41 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015195345.GQ26918@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.