From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 2/3] ARM: dts: at_xdmac: add bindings documentation
Date: Wed, 15 Oct 2014 19:11:34 +0530 [thread overview]
Message-ID: <20141015134134.GR1638@intel.com> (raw)
In-Reply-To: <1412175565-810-3-git-send-email-ludovic.desroches@atmel.com>
On Wed, Oct 01, 2014 at 04:59:24PM +0200, Ludovic Desroches wrote:
> Add bindings documentation for the new Atmel DMA controller (XDMAC)
> introduced with SAMA5D4.
Seeing the example below, it doesnt seem to me that we cant reuse existing
atmel binding, can you explain why we cnat reuse
--
~Vinod
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> .../devicetree/bindings/dma/atmel-xdma.txt | 50 ++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/atmel-xdma.txt
>
> diff --git a/Documentation/devicetree/bindings/dma/atmel-xdma.txt b/Documentation/devicetree/bindings/dma/atmel-xdma.txt
> new file mode 100644
> index 0000000..ae587ad
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/atmel-xdma.txt
> @@ -0,0 +1,50 @@
> +* Atmel Extensible Direct Memory Access Controller (XDMAC)
> +
> +* XDMA Controller
> +Required properties:
> +- compatible: Should be "atmel,<chip>-dma".
> + <chip> compatible description:
> + - sama5d4: first SoC adding the XDMAC
> +- reg: Should contain DMA registers location and length.
> +- interrupts: Should contain DMA interrupt.
> +- #dma-cells: Must be <2>, used to represent the number of integer cells in
> +the dmas property of client devices.
> + - The 1st cell specifies the memory interface (16 most significant bits) and
> + the peripheral interface (16 less significant bits) to use.
> + - The 2nd cell specifies the channel configuration register:
> + - bit 30-24: PERID, peripheral identifier.
> +
> +Example:
> +
> +dma1: dma-controller at f0004000 {
> + compatible = "atmel,sama5d4-dma";
> + reg = <0xf0004000 0x200>;
> + interrupts = <50 4 0>;
> + #dma-cells = <2>;
> +};
> +
> +
> +* DMA clients
> +DMA clients connected to the Atmel XDMA controller must use the format
> +described in the dma.txt file, using a two-cell specifier for each channel.
> +The three cells in order are:
> +1. A phandle pointing to the DMA controller.
> +2. The memory interface (16 most significant bits), the peripheral interface
> +(16 less significant bits).
> +3. Channel configuration register. Configurable fields are:
> + - bit 30-24: PERID, peripheral identifier.
> +
> +Example:
> +
> +i2c2: i2c at f8024000 {
> + compatible = "atmel,at91sam9x5-i2c";
> + reg = <0xf8024000 0x4000>;
> + interrupts = <34 4 6>;
> + dmas = <&dma1
> + (AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1))
> + AT91_XDMAC_DT_PERID(6)>,
> + <&dma1
> + (AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1))
> + AT91_XDMAC_DT_PERID(7)>;
> + dma-names = "tx", "rx";
> +};
> --
> 2.0.3
>
--
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Ludovic Desroches <ludovic.desroches@atmel.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
sergei.shtylyov@cogentembedded.com, arnd@arndb.de,
nicolas.ferre@atmel.com, josh.wu@atmel.com,
dmaengine@vger.kernel.org, maxime.ripard@free-electrons.com,
plagnioj@jcrosoft.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 2/3] ARM: dts: at_xdmac: add bindings documentation
Date: Wed, 15 Oct 2014 19:11:34 +0530 [thread overview]
Message-ID: <20141015134134.GR1638@intel.com> (raw)
In-Reply-To: <1412175565-810-3-git-send-email-ludovic.desroches@atmel.com>
On Wed, Oct 01, 2014 at 04:59:24PM +0200, Ludovic Desroches wrote:
> Add bindings documentation for the new Atmel DMA controller (XDMAC)
> introduced with SAMA5D4.
Seeing the example below, it doesnt seem to me that we cant reuse existing
atmel binding, can you explain why we cnat reuse
--
~Vinod
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> .../devicetree/bindings/dma/atmel-xdma.txt | 50 ++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/atmel-xdma.txt
>
> diff --git a/Documentation/devicetree/bindings/dma/atmel-xdma.txt b/Documentation/devicetree/bindings/dma/atmel-xdma.txt
> new file mode 100644
> index 0000000..ae587ad
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/atmel-xdma.txt
> @@ -0,0 +1,50 @@
> +* Atmel Extensible Direct Memory Access Controller (XDMAC)
> +
> +* XDMA Controller
> +Required properties:
> +- compatible: Should be "atmel,<chip>-dma".
> + <chip> compatible description:
> + - sama5d4: first SoC adding the XDMAC
> +- reg: Should contain DMA registers location and length.
> +- interrupts: Should contain DMA interrupt.
> +- #dma-cells: Must be <2>, used to represent the number of integer cells in
> +the dmas property of client devices.
> + - The 1st cell specifies the memory interface (16 most significant bits) and
> + the peripheral interface (16 less significant bits) to use.
> + - The 2nd cell specifies the channel configuration register:
> + - bit 30-24: PERID, peripheral identifier.
> +
> +Example:
> +
> +dma1: dma-controller@f0004000 {
> + compatible = "atmel,sama5d4-dma";
> + reg = <0xf0004000 0x200>;
> + interrupts = <50 4 0>;
> + #dma-cells = <2>;
> +};
> +
> +
> +* DMA clients
> +DMA clients connected to the Atmel XDMA controller must use the format
> +described in the dma.txt file, using a two-cell specifier for each channel.
> +The three cells in order are:
> +1. A phandle pointing to the DMA controller.
> +2. The memory interface (16 most significant bits), the peripheral interface
> +(16 less significant bits).
> +3. Channel configuration register. Configurable fields are:
> + - bit 30-24: PERID, peripheral identifier.
> +
> +Example:
> +
> +i2c2: i2c@f8024000 {
> + compatible = "atmel,at91sam9x5-i2c";
> + reg = <0xf8024000 0x4000>;
> + interrupts = <34 4 6>;
> + dmas = <&dma1
> + (AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1))
> + AT91_XDMAC_DT_PERID(6)>,
> + <&dma1
> + (AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1))
> + AT91_XDMAC_DT_PERID(7)>;
> + dma-names = "tx", "rx";
> +};
> --
> 2.0.3
>
--
next prev parent reply other threads:[~2014-10-15 13:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 14:59 [PATCH v6 0/3] new Atmel DMA controller (XDMAC) Ludovic Desroches
2014-10-01 14:59 ` Ludovic Desroches
2014-10-01 14:59 ` [PATCH v6 1/3] dma: at_xdmac: creation of the atmel eXtended DMA Controller driver Ludovic Desroches
2014-10-01 14:59 ` Ludovic Desroches
2014-10-15 13:30 ` Vinod Koul
2014-10-15 13:30 ` Vinod Koul
2014-10-16 14:10 ` Ludovic Desroches
2014-10-16 14:10 ` Ludovic Desroches
2014-10-16 16:12 ` Vinod Koul
2014-10-16 16:12 ` Vinod Koul
2014-10-17 6:53 ` Ludovic Desroches
2014-10-17 6:53 ` Ludovic Desroches
2014-10-17 7:32 ` Vinod Koul
2014-10-17 7:32 ` Vinod Koul
2014-10-20 15:08 ` Ludovic Desroches
2014-10-20 15:08 ` Ludovic Desroches
2014-10-21 10:50 ` Vinod Koul
2014-10-21 10:50 ` Vinod Koul
2014-10-01 14:59 ` [PATCH v6 2/3] ARM: dts: at_xdmac: add bindings documentation Ludovic Desroches
2014-10-01 14:59 ` Ludovic Desroches
2014-10-15 13:41 ` Vinod Koul [this message]
2014-10-15 13:41 ` Vinod Koul
2014-10-16 13:20 ` Ludovic Desroches
2014-10-16 13:20 ` Ludovic Desroches
2014-10-01 14:59 ` [PATCH v6 3/3] MAINTAINERS: add entry for Atmel XDMA driver Ludovic Desroches
2014-10-01 14:59 ` Ludovic Desroches
2014-10-15 12:14 ` [PATCH v6 0/3] new Atmel DMA controller (XDMAC) Ludovic Desroches
2014-10-15 12:14 ` Ludovic Desroches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015134134.GR1638@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.