From: benjamin.poirier@gmail.com (Benjamin Poirier)
To: linux-arm-kernel@lists.infradead.org
Subject: Regarding tx-nocache-copy in the Sheevaplug
Date: Wed, 15 Oct 2014 14:57:01 -0700 [thread overview]
Message-ID: <20141015215701.GA4109@f1.synalogic.ca> (raw)
In-Reply-To: <20141013105246.GD1972@vicerveza.homeunix.net>
On 2014/10/13 12:52, Llu?s Batlle i Rossell wrote:
> Hello,
>
> on the 7th of January 2014 ths patch was applied:
> https://lkml.org/lkml/2014/1/7/307
>
> [PATCH v2] net: Do not enable tx-nocache-copy by default
>
> In the Sheevaplug (ARM Feroceon 88FR131 from Marvell) this made packets to be
> sent corrupted. I think this machine has something special about the cache.
>
> Enabling back this tx-nocache-copy (as it used to be before the patch) the
> transfers work fine again. I think that most people, encountering this problem,
> completely disable the tx offload instead of enabling back this setting.
>
> Is this an ARM kernel problem regarding this platform?
This is odd, only x86 defines ARCH_HAS_NOCACHE_UACCESS. On arm,
skb_do_copy_data_nocache() should end up using __copy_from_user()
regardless of tx-nocache-copy.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Poirier <benjamin.poirier@gmail.com>
To: "Lluís Batlle i Rossell" <viric@viric.name>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"Carles Pagès" <page@cubata.homelinux.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: Regarding tx-nocache-copy in the Sheevaplug
Date: Wed, 15 Oct 2014 14:57:01 -0700 [thread overview]
Message-ID: <20141015215701.GA4109@f1.synalogic.ca> (raw)
In-Reply-To: <20141013105246.GD1972@vicerveza.homeunix.net>
On 2014/10/13 12:52, Lluís Batlle i Rossell wrote:
> Hello,
>
> on the 7th of January 2014 ths patch was applied:
> https://lkml.org/lkml/2014/1/7/307
>
> [PATCH v2] net: Do not enable tx-nocache-copy by default
>
> In the Sheevaplug (ARM Feroceon 88FR131 from Marvell) this made packets to be
> sent corrupted. I think this machine has something special about the cache.
>
> Enabling back this tx-nocache-copy (as it used to be before the patch) the
> transfers work fine again. I think that most people, encountering this problem,
> completely disable the tx offload instead of enabling back this setting.
>
> Is this an ARM kernel problem regarding this platform?
This is odd, only x86 defines ARCH_HAS_NOCACHE_UACCESS. On arm,
skb_do_copy_data_nocache() should end up using __copy_from_user()
regardless of tx-nocache-copy.
next prev parent reply other threads:[~2014-10-15 21:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 10:52 Regarding tx-nocache-copy in the Sheevaplug Lluís Batlle i Rossell
2014-10-13 10:52 ` Lluís Batlle i Rossell
2014-10-13 12:26 ` Eric Dumazet
2014-10-13 12:26 ` Eric Dumazet
2014-10-13 12:32 ` Lluís Batlle i Rossell
2014-10-13 12:32 ` Lluís Batlle i Rossell
2014-10-13 14:21 ` Andrew Lunn
2014-10-13 14:21 ` Andrew Lunn
2014-10-13 14:31 ` Lluís Batlle i Rossell
2014-10-13 14:31 ` Lluís Batlle i Rossell
2014-10-13 14:49 ` Eric Dumazet
2014-10-13 14:49 ` Eric Dumazet
2014-10-13 15:48 ` Lluís Batlle i Rossell
2014-10-13 15:48 ` Lluís Batlle i Rossell
2014-10-15 21:57 ` Benjamin Poirier [this message]
2014-10-15 21:57 ` Benjamin Poirier
2014-10-15 22:45 ` Eric Dumazet
2014-10-15 22:45 ` Eric Dumazet
2014-10-16 17:34 ` Benjamin Poirier
2014-10-16 17:34 ` Benjamin Poirier
2014-10-16 17:46 ` Lluís Batlle i Rossell
2014-10-16 17:46 ` Lluís Batlle i Rossell
2014-10-17 20:55 ` Benjamin Poirier
2014-10-17 20:55 ` Benjamin Poirier
2014-10-16 17:48 ` Eric Dumazet
2014-10-16 17:48 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015215701.GA4109@f1.synalogic.ca \
--to=benjamin.poirier@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.