From: antoine.tenart@free-electrons.com (Antoine Tenart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] ARM: berlin: Add AHCI and SATA PHY nodes to BG2
Date: Thu, 16 Oct 2014 11:59:46 +0200 [thread overview]
Message-ID: <20141016095946.GB1061@kwain> (raw)
In-Reply-To: <1413042073-14253-5-git-send-email-sebastian.hesselbarth@gmail.com>
Hi Sebastian,
On Sat, Oct 11, 2014 at 05:41:12PM +0200, Sebastian Hesselbarth wrote:
>
> + ahci: sata at e90000 {
> + compatible = "marvell,berlin2-ahci", "generic-ahci";
> + reg = <0xe90000 0x1000>;
> + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&chip CLKID_SATA>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
The ahci generic driver actually returns -ENODEV if no port is
activated. There is no need to disable it from there.
> +
> + sata0: sata-port at 0 {
> + reg = <0>;
> + phys = <&sata_phy 0>;
> + status = "disabled";
> + };
> +
> + sata1: sata-port at 1 {
> + reg = <1>;
> + phys = <&sata_phy 1>;
> + status = "disabled";
> + };
> + };
Antoine
--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: "Kishon Vijay Abraham I" <kishon@ti.com>,
"Antoine Ténart" <antoine.tenart@free-electrons.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] ARM: berlin: Add AHCI and SATA PHY nodes to BG2
Date: Thu, 16 Oct 2014 11:59:46 +0200 [thread overview]
Message-ID: <20141016095946.GB1061@kwain> (raw)
In-Reply-To: <1413042073-14253-5-git-send-email-sebastian.hesselbarth@gmail.com>
Hi Sebastian,
On Sat, Oct 11, 2014 at 05:41:12PM +0200, Sebastian Hesselbarth wrote:
>
> + ahci: sata@e90000 {
> + compatible = "marvell,berlin2-ahci", "generic-ahci";
> + reg = <0xe90000 0x1000>;
> + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&chip CLKID_SATA>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
The ahci generic driver actually returns -ENODEV if no port is
activated. There is no need to disable it from there.
> +
> + sata0: sata-port@0 {
> + reg = <0>;
> + phys = <&sata_phy 0>;
> + status = "disabled";
> + };
> +
> + sata1: sata-port@1 {
> + reg = <1>;
> + phys = <&sata_phy 1>;
> + status = "disabled";
> + };
> + };
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-16 9:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 15:41 [PATCH 0/5] Berlin BG2 AHCI and SATA PHY Sebastian Hesselbarth
2014-10-11 15:41 ` Sebastian Hesselbarth
2014-10-11 15:41 ` Sebastian Hesselbarth
2014-10-11 15:41 ` [PATCH 1/5] phy: berlin-sata: Move PHY_BASE into private data struct Sebastian Hesselbarth
2014-10-11 15:41 ` Sebastian Hesselbarth
2014-10-11 15:41 ` Sebastian Hesselbarth
2014-10-11 15:41 ` [PATCH 2/5] phy: berlin-sata: Add support for BG2 SATA PHY Sebastian Hesselbarth
2014-10-11 15:41 ` Sebastian Hesselbarth
2014-10-11 15:41 ` Sebastian Hesselbarth
2014-10-11 15:41 ` [PATCH 3/5] phy: berlin-sata: Document BG2 compatible Sebastian Hesselbarth
2014-10-11 15:41 ` Sebastian Hesselbarth
2014-10-11 15:41 ` Sebastian Hesselbarth
2014-10-11 15:41 ` [PATCH 4/5] ARM: berlin: Add AHCI and SATA PHY nodes to BG2 Sebastian Hesselbarth
2014-10-11 15:41 ` Sebastian Hesselbarth
2014-10-11 15:41 ` Sebastian Hesselbarth
2014-10-16 9:59 ` Antoine Tenart [this message]
2014-10-16 9:59 ` Antoine Tenart
2014-10-11 15:41 ` [PATCH 5/5] ARM: berlin: Enable SATA on Sony NSZ-GS7 Sebastian Hesselbarth
2014-10-11 15:41 ` Sebastian Hesselbarth
2014-10-11 15:41 ` Sebastian Hesselbarth
2014-10-16 12:53 ` [PATCH 0/5] Berlin BG2 AHCI and SATA PHY Antoine Tenart
2014-10-16 12:53 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141016095946.GB1061@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.