Re: [PATCH v4 2/7] ASoC: Intel: mrfld - Add DSP load and management

[Vinod Koul <vinod.koul@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1257 bytes --]

On Fri, Oct 17, 2014 at 11:44:14AM +0200, Mark Brown wrote:
> On Thu, Oct 16, 2014 at 08:00:14PM +0530, Vinod Koul wrote:
> 
> > +static void memcpy32_toio(void __iomem *dst, const void *src, int count)
> > +{
> > +	int i;
> > +	const u32 *src_32 = src;
> > +	u32 *dst_32 = dst;
> > +
> > +	for (i = 0; i < count/sizeof(u32); i++)
> > +		writel(*src_32++, dst_32++);
> > +}
> 
> We also have a memcpy32_toio in atmel_nand.c which I pointed out before
> and now another in mxc_nand.c.  All of which use different writel
> variants.  This isn't awesome, we should at least try to clean this up
> rather than add another duplicate - by the time we're onto the third
> user there's a clear need for something generic.  Do you have any
> thoughts on dealing with this?
I dont mind moving this and other users to common handler. I can send a
patch to add that. I think Subranshu did send one but that needs to be
improved upon. Also this should be in BYT driver as well.

But creates dependency for us
> 
> Otherwise the patch looks good.
Thanks, since the size is bit on higher size and no other issues, would it
be okay to merge this.

I will work on moving memcpy32_toio to core and move users as well :)


Thanks
-- 
~Vinod

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]