From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, subhransu.s.prusty@intel.com,
lgirdwood@gmail.com
Subject: Re: [PATCH v4 4/7] ASoC: Intel: sst: Add IPC handling
Date: Fri, 17 Oct 2014 17:25:24 +0530 [thread overview]
Message-ID: <20141017115524.GS1638@intel.com> (raw)
In-Reply-To: <20141017120918.GH1820@sirena.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 766 bytes --]
On Fri, Oct 17, 2014 at 02:09:18PM +0200, Mark Brown wrote:
> On Thu, Oct 16, 2014 at 08:00:16PM +0530, Vinod Koul wrote:
>
> > + spin_unlock_bh(&ctx->block_lock);
> > + dev_dbg(ctx->dev,
> > + "Block not found or a response received for a short msg for ipc %d, drv_id %d\n",
> > + ipc, drv_id);
> > + return -EINVAL;
>
> Shouldn't this be a dev_err() or something?
Not really.
We get response from FW which cna be short or long. In former there wont be
anyone waiting as all blocked ones are large.
We cant distiguish between the two thats why we log debug message here. If
its real then finally the message will timeout and we would see that as
error. Yes this is limiation in IPC.
Putting this as err makes log very noisy :(
--
~Vinod
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-10-17 12:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 14:30 [PATCH v4 0/7] ASoC: Intel: sst - add the merrifield IPC driver Vinod Koul
2014-10-16 14:30 ` [PATCH v4 1/7] ASoC: Intel: mrfld - add the dsp sst driver Vinod Koul
2014-10-17 9:11 ` Mark Brown
2014-10-16 14:30 ` [PATCH v4 2/7] ASoC: Intel: mrfld - Add DSP load and management Vinod Koul
2014-10-17 9:44 ` Mark Brown
2014-10-17 9:18 ` Vinod Koul
2014-10-17 10:04 ` Takashi Iwai
2014-10-17 12:01 ` Mark Brown
2014-10-17 12:07 ` Takashi Iwai
2014-10-20 5:41 ` Vinod Koul
2014-10-20 15:29 ` Mark Brown
2014-10-20 16:07 ` Vinod Koul
2014-10-16 14:30 ` [PATCH v4 3/7] ASoC: Intel: sst - add pcm ops handling Vinod Koul
2014-10-17 12:07 ` Mark Brown
2014-10-17 11:35 ` Vinod Koul
2014-10-16 14:30 ` [PATCH v4 4/7] ASoC: Intel: sst: Add IPC handling Vinod Koul
2014-10-17 12:09 ` Mark Brown
2014-10-17 11:55 ` Vinod Koul [this message]
2014-10-17 13:53 ` Mark Brown
2014-10-20 5:18 ` Vinod Koul
2014-10-16 14:30 ` [PATCH v4 5/7] ASoC: Intel: sst: add stream operations Vinod Koul
2014-10-16 14:30 ` [PATCH v4 6/7] ASoC: Intel: sst: Add some helper functions Vinod Koul
2014-10-16 14:30 ` [PATCH v4 7/7] ASoC: Intel: sst: Add makefile and kconfig changes Vinod Koul
2014-10-17 12:15 ` [PATCH v4 0/7] ASoC: Intel: sst - add the merrifield IPC driver Mark Brown
2014-10-17 11:56 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141017115524.GS1638@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=subhransu.s.prusty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.