From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_net: fix use after free
Date: Fri, 17 Oct 2014 12:20:11 +0300 [thread overview]
Message-ID: <20141017092011.GA31313@redhat.com> (raw)
In-Reply-To: <20141015.164727.298073723527552510.davem@davemloft.net>
On Wed, Oct 15, 2014 at 04:47:27PM -0400, David Miller wrote:
> From: "Michael S. Tsirkin" <mst@redhat.com>
> Date: Wed, 15 Oct 2014 16:23:28 +0300
>
> > You used __netif_subqueue_stopped but that seems to use
> > a slightly more expensive test_bit internally.
>
> More expensive in what sense? It should be roughly the same
> as "x & y" sans the volatile.
I really just meant volatile - this might prevent some compiler
optimizations. I have't actually checked the produced binary so
I don't know for sure.
> Anyways I'm ambivalent and I want to see this bug fixes, so I'll
> apply your patch.
>
> Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, jasowang@redhat.com
Subject: Re: [PATCH] virtio_net: fix use after free
Date: Fri, 17 Oct 2014 12:20:11 +0300 [thread overview]
Message-ID: <20141017092011.GA31313@redhat.com> (raw)
In-Reply-To: <20141015.164727.298073723527552510.davem@davemloft.net>
On Wed, Oct 15, 2014 at 04:47:27PM -0400, David Miller wrote:
> From: "Michael S. Tsirkin" <mst@redhat.com>
> Date: Wed, 15 Oct 2014 16:23:28 +0300
>
> > You used __netif_subqueue_stopped but that seems to use
> > a slightly more expensive test_bit internally.
>
> More expensive in what sense? It should be roughly the same
> as "x & y" sans the volatile.
I really just meant volatile - this might prevent some compiler
optimizations. I have't actually checked the produced binary so
I don't know for sure.
> Anyways I'm ambivalent and I want to see this bug fixes, so I'll
> apply your patch.
>
> Thanks!
next prev parent reply other threads:[~2014-10-17 9:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 13:23 [PATCH] virtio_net: fix use after free Michael S. Tsirkin
2014-10-15 13:23 ` Michael S. Tsirkin
2014-10-15 13:24 ` David Laight
2014-10-15 13:24 ` David Laight
2014-10-15 13:37 ` Michael S. Tsirkin
2014-10-15 13:37 ` Michael S. Tsirkin
2014-10-15 20:47 ` David Miller
2014-10-17 9:20 ` Michael S. Tsirkin [this message]
2014-10-17 9:20 ` Michael S. Tsirkin
2014-10-15 20:47 ` David Miller
2014-10-31 3:36 ` Eric Dumazet
2014-10-31 3:36 ` Eric Dumazet
2014-10-31 6:07 ` Jason Wang
2014-10-31 6:07 ` Jason Wang
2014-10-31 12:24 ` Eric Dumazet
2014-10-31 12:24 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141017092011.GA31313@redhat.com \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.