All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@denx.de>
To: Hui Zhu <zhuhui@xiaomi.com>
Cc: rjw@rjwysocki.net, len.brown@intel.com, m.szyprowski@samsung.com,
	akpm@linux-foundation.org, mina86@mina86.com,
	aneesh.kumar@linux.vnet.ibm.com, iamjoonsoo.kim@lge.com,
	hannes@cmpxchg.org, riel@redhat.com, mgorman@suse.de,
	minchan@kernel.org, nasa4836@gmail.com, ddstreet@ieee.org,
	hughd@google.com, mingo@kernel.org, rientjes@google.com,
	peterz@infradead.org, keescook@chromium.org, atomlin@redhat.com,
	raistlin@linux.it, axboe@fb.com, paulmck@linux.vnet.ibm.com,
	kirill.shutemov@linux.intel.com, n-horiguchi@ah.jp.nec.com,
	k.khlebnikov@samsung.com, msalter@redhat.com, deller@gmx.de,
	tangchen@cn.fujitsu.com, ben@decadent.org.uk,
	akinobu.mita@gmail.com, lauraa@codeaurora.org, vbabka@suse.cz,
	sasha.levin@oracle.com, vdavydov@parallels.com,
	suleiman@google.com, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/4] (CMA_AGGRESSIVE) Add CMA_AGGRESSIVE to Kconfig
Date: Sun, 19 Oct 2014 00:15:25 +0200	[thread overview]
Message-ID: <20141018221525.GB10843@amd> (raw)
In-Reply-To: <1413430551-22392-2-git-send-email-zhuhui@xiaomi.com>

Hi!

> Add CMA_AGGRESSIVE config that depend on CMA to Linux kernel config.
> Add CMA_AGGRESSIVE_PHY_MAX, CMA_AGGRESSIVE_FREE_MIN and CMA_AGGRESSIVE_SHRINK
> that depend on CMA_AGGRESSIVE.
> 
> If physical memory size (not include CMA memory) in byte less than or equal to
> CMA_AGGRESSIVE_PHY_MAX, CMA aggressive switch (sysctl vm.cma-aggressive-switch)
> will be opened.

Ok...

Do I understand it correctly that there is some problem with
hibernation not working on machines not working on machines with big
CMA areas...?

But adding 4 config options end-user has no chance to set right can
not be the best solution, can it?

> +config CMA_AGGRESSIVE_PHY_MAX
> +	hex "Physical memory size in Bytes that auto turn on the CMA aggressive switch"
> +	depends on CMA_AGGRESSIVE
> +	default 0x40000000
> +	help
> +	  If physical memory size (not include CMA memory) in byte less than or
> +	  equal to this value, CMA aggressive switch will be opened.
> +	  After the Linux boot, sysctl "vm.cma-aggressive-switch" can control
> +	  the CMA AGGRESSIVE switch.

For example... how am I expected to figure right value to place here?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@denx.de>
To: Hui Zhu <zhuhui@xiaomi.com>
Cc: rjw@rjwysocki.net, len.brown@intel.com, m.szyprowski@samsung.com,
	akpm@linux-foundation.org, mina86@mina86.com,
	aneesh.kumar@linux.vnet.ibm.com, iamjoonsoo.kim@lge.com,
	hannes@cmpxchg.org, riel@redhat.com, mgorman@suse.de,
	minchan@kernel.org, nasa4836@gmail.com, ddstreet@ieee.org,
	hughd@google.com, mingo@kernel.org, rientjes@google.com,
	peterz@infradead.org, keescook@chromium.org, atomlin@redhat.com,
	raistlin@linux.it, axboe@fb.com, paulmck@linux.vnet.ibm.com,
	kirill.shutemov@linux.intel.com, n-horiguchi@ah.jp.nec.com,
	k.khlebnikov@samsung.com, msalter@redhat.com, deller@gmx.de,
	tangchen@cn.fujitsu.com, ben@decadent.org.uk,
	akinobu.mita@gmail.com, lauraa@codeaurora.org, vbabka@suse.cz,
	sasha.levin@oracle.com, vdavydov@parallels.com,
	suleiman@google.com, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/4] (CMA_AGGRESSIVE) Add CMA_AGGRESSIVE to Kconfig
Date: Sun, 19 Oct 2014 00:15:25 +0200	[thread overview]
Message-ID: <20141018221525.GB10843@amd> (raw)
In-Reply-To: <1413430551-22392-2-git-send-email-zhuhui@xiaomi.com>

Hi!

> Add CMA_AGGRESSIVE config that depend on CMA to Linux kernel config.
> Add CMA_AGGRESSIVE_PHY_MAX, CMA_AGGRESSIVE_FREE_MIN and CMA_AGGRESSIVE_SHRINK
> that depend on CMA_AGGRESSIVE.
> 
> If physical memory size (not include CMA memory) in byte less than or equal to
> CMA_AGGRESSIVE_PHY_MAX, CMA aggressive switch (sysctl vm.cma-aggressive-switch)
> will be opened.

Ok...

Do I understand it correctly that there is some problem with
hibernation not working on machines not working on machines with big
CMA areas...?

But adding 4 config options end-user has no chance to set right can
not be the best solution, can it?

> +config CMA_AGGRESSIVE_PHY_MAX
> +	hex "Physical memory size in Bytes that auto turn on the CMA aggressive switch"
> +	depends on CMA_AGGRESSIVE
> +	default 0x40000000
> +	help
> +	  If physical memory size (not include CMA memory) in byte less than or
> +	  equal to this value, CMA aggressive switch will be opened.
> +	  After the Linux boot, sysctl "vm.cma-aggressive-switch" can control
> +	  the CMA AGGRESSIVE switch.

For example... how am I expected to figure right value to place here?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-10-18 22:15 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-16  3:35 [PATCH 0/4] (CMA_AGGRESSIVE) Make CMA memory be more aggressive about allocation Hui Zhu
2014-10-16  3:35 ` Hui Zhu
2014-10-16  3:35 ` [PATCH 1/4] (CMA_AGGRESSIVE) Add CMA_AGGRESSIVE to Kconfig Hui Zhu
2014-10-16  3:35   ` Hui Zhu
2014-10-18 22:15   ` Pavel Machek [this message]
2014-10-18 22:15     ` Pavel Machek
     [not found]   ` <201410220126.s9M1Qita026502@spam.xiaomi.com>
2014-10-22  5:44     ` 朱辉
2014-10-22  5:44       ` 朱辉
2014-10-22  5:44       ` 朱辉
2014-10-16  3:35 ` [PATCH 2/4] (CMA_AGGRESSIVE) Add argument hibernation to function shrink_all_memory Hui Zhu
2014-10-16  3:35   ` Hui Zhu
2014-10-16  3:35   ` Hui Zhu
2014-10-16  8:45   ` Rafael J. Wysocki
2014-10-16  8:45     ` Rafael J. Wysocki
2014-10-17  6:18     ` 朱辉
2014-10-17  6:18       ` 朱辉
2014-10-17  9:28     ` [PATCH v2 2/4] (CMA_AGGRESSIVE) Add new function shrink_all_memory_for_cma Hui Zhu
2014-10-17  9:28       ` Hui Zhu
2014-10-17  9:28       ` Hui Zhu
2014-10-18  4:50       ` PINTU KUMAR
2014-10-18  4:50         ` PINTU KUMAR
2014-10-16  3:35 ` [PATCH 3/4] (CMA_AGGRESSIVE) Update reserve custom contiguous area code Hui Zhu
2014-10-16  3:35   ` Hui Zhu
2014-10-17  9:30   ` [PATCH v2 " Hui Zhu
2014-10-17  9:30     ` Hui Zhu
2014-10-17  9:30     ` Hui Zhu
2014-10-16  3:35 ` [PATCH 4/4] (CMA_AGGRESSIVE) Update page alloc function Hui Zhu
2014-10-16  3:35   ` Hui Zhu
2014-10-24  5:28   ` Joonsoo Kim
2014-10-24  5:28     ` Joonsoo Kim
2014-11-28  3:45     ` Hui Zhu
2014-11-28  3:45       ` Hui Zhu
2014-11-28  3:45       ` Hui Zhu
2014-10-16  5:13 ` [PATCH 0/4] (CMA_AGGRESSIVE) Make CMA memory be more aggressive about allocation Weijie Yang
2014-10-16  5:13   ` Weijie Yang
2014-10-16  8:55 ` Laura Abbott
2014-10-16  8:55   ` Laura Abbott
2014-10-17  7:44   ` 朱辉
2014-10-17  7:44     ` 朱辉
2014-10-17  7:44     ` 朱辉
2014-10-22 12:01   ` Peter Hurley
2014-10-22 12:01     ` Peter Hurley
2014-10-23  0:40     ` 朱辉
2014-10-23  0:40       ` 朱辉
2014-10-23  0:40       ` 朱辉
2014-10-29 14:43   ` Vlastimil Babka
2014-10-29 14:43     ` Vlastimil Babka
2014-11-03  8:46     ` Hui Zhu
2014-11-03  8:46       ` Hui Zhu
2014-11-03  8:46       ` Hui Zhu
2014-11-04  7:53     ` Minchan Kim
2014-11-04  7:53       ` Minchan Kim
2014-11-04  8:59       ` Hui Zhu
2014-11-04  8:59         ` Hui Zhu
2014-11-04  8:59         ` Hui Zhu
2014-11-04  9:29       ` Vlastimil Babka
2014-11-04  9:29         ` Vlastimil Babka
2014-11-07  7:06         ` Minchan Kim
2014-11-07  7:06           ` Minchan Kim
2014-10-24  5:25 ` Joonsoo Kim
2014-10-24  5:25   ` Joonsoo Kim
2014-11-03  7:28   ` Hui Zhu
2014-11-03  7:28     ` Hui Zhu
2014-11-03  7:28     ` Hui Zhu
2014-11-03  8:05     ` Joonsoo Kim
2014-11-03  8:05       ` Joonsoo Kim
2014-11-03  8:05       ` Joonsoo Kim
2014-11-04  2:31       ` Joonsoo Kim
2014-11-04  2:31         ` Joonsoo Kim
2014-11-04  2:31         ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141018221525.GB10843@amd \
    --to=pavel@denx.de \
    --cc=akinobu.mita@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=atomlin@redhat.com \
    --cc=axboe@fb.com \
    --cc=ben@decadent.org.uk \
    --cc=ddstreet@ieee.org \
    --cc=deller@gmx.de \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=k.khlebnikov@samsung.com \
    --cc=keescook@chromium.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=lauraa@codeaurora.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mgorman@suse.de \
    --cc=mina86@mina86.com \
    --cc=minchan@kernel.org \
    --cc=mingo@kernel.org \
    --cc=msalter@redhat.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=nasa4836@gmail.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=raistlin@linux.it \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=rjw@rjwysocki.net \
    --cc=sasha.levin@oracle.com \
    --cc=suleiman@google.com \
    --cc=tangchen@cn.fujitsu.com \
    --cc=vbabka@suse.cz \
    --cc=vdavydov@parallels.com \
    --cc=zhuhui@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.