From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH for-xen-4.5] Add configure --with-extra-cflags-*
Date: Tue, 21 Oct 2014 11:07:43 +0200 [thread overview]
Message-ID: <20141021090743.GB17073@aepfle.de> (raw)
In-Reply-To: <1413808836.4087.15.camel@citrix.com>
On Mon, Oct 20, Ian Campbell wrote:
> On Thu, 2014-10-09 at 11:43 +0200, Olaf Hering wrote:
>
> Please do not use the "for-xen-4.5" without making some sort of argument
> as to why it should be acceptable for 4.5, usually after the ---
> separator.
>
> To me this looks like a feature, but in any case neither Konrad nor I
> should be expected to make the argument for you.
The point is that the build system should not take "random" environment
variables. Instead such things should be passed in via configure. Now
that configure does already most of the settings it should do also this.
Olaf
prev parent reply other threads:[~2014-10-21 9:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 9:43 [PATCH for-xen-4.5] Add configure --with-extra-cflags-* Olaf Hering
2014-10-10 6:55 ` Olaf Hering
2014-10-20 12:39 ` Ian Campbell
2014-10-21 9:03 ` Olaf Hering
2014-10-20 12:40 ` Ian Campbell
2014-10-21 9:07 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021090743.GB17073@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.